Don't print each symbol that is iterated.
Make the error message more clear by prefixing "error: ".
Signed-off-by: Joe Stringer <joestrin...@nicira.com>
---
datapath/Makefile.am | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/datapath/Makefile.am b/datapath/Makefile.am
index a8e9be4..458fa5b 100644
--- a/datapath/Makefile.am
+++ b/datapath/Makefile.am
@@ -42,15 +42,15 @@ COMPAT_EXPORTS := $(shell $(COMPAT_GET_EXPORTS))
check-export-symbol:
@for fun_ in $(COMPAT_FUNCTIONS); do \
if ! grep -- $${fun_}
$(top_srcdir)/datapath/linux/compat/build-aux/export-check-whitelist >
/dev/null; then \
- if ! echo $${fun_} | grep -E '^(rpl|ovs)_'; then \
- echo "Should prefix $${fun_} with rpl_ or ovs_."; \
+ if ! echo $${fun_} | grep -q -E '^(rpl|ovs)_'; then \
+ echo "error: $${fun_}() needs to be prefixed with 'rpl_' or
'ovs_'."; \
exit 1; \
fi; \
fi; \
done
@for fun_ in $(COMPAT_EXPORTS); do \
- if ! echo $${fun_} | grep -E '^(rpl|ovs)_'; then \
- echo "Should prefix $${fun_} with rpl_ or ovs_."; \
+ if ! echo $${fun_} | grep -q -E '^(rpl|ovs)_'; then \
+ echo "error: $${fun_}() needs to be prefixed with 'rpl_' or
'ovs_'."; \
exit 1; \
fi; \
done
--
1.7.10.4
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
