Hi Ben,
Thanks for your reply.
We have applied this patch on the latest ovs master branch and it was
successful.
Due to difference in mail server, the patch got corrupted.
The patch present in ovs-dev forum (dated 27 Nov 2014) is also successfully
applied.
Attaching the patch with this mail f
I believe that I am caught up on reviewing the series that I plan to
review. Please let me know soon if I missed something--I will be on
vacation from Dec. 13 to 23.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, Dec 12, 2014 at 12:26:38PM +0900, Simon Horman wrote:
> On Thu, Dec 11, 2014 at 07:16:36PM -0800, Ben Pfaff wrote:
> > On Fri, Dec 12, 2014 at 12:09:25PM +0900, Simon Horman wrote:
> > > On Thu, Dec 11, 2014 at 07:02:29PM -0800, Ben Pfaff wrote:
> > > > On Fri, Dec 12, 2014 at 11:31:50AM +0
On 11 December 2014 at 16:41, Ben Pfaff wrote:
> On Fri, Dec 05, 2014 at 11:45:11AM -0800, Joe Stringer wrote:
>> Parse "ufid:" at the beginning of a flow specification and use it
>> for flow manipulation if present.
>>
>> Signed-off-by: Joe Stringer
>> ---
>> v3: Fix build on windows.
>> v2: Reb
On Thu, Dec 11, 2014 at 07:16:36PM -0800, Ben Pfaff wrote:
> On Fri, Dec 12, 2014 at 12:09:25PM +0900, Simon Horman wrote:
> > On Thu, Dec 11, 2014 at 07:02:29PM -0800, Ben Pfaff wrote:
> > > On Fri, Dec 12, 2014 at 11:31:50AM +0900, Simon Horman wrote:
> > > > On Thu, Dec 11, 2014 at 11:49:33AM -0
On Fri, Dec 12, 2014 at 12:09:25PM +0900, Simon Horman wrote:
> On Thu, Dec 11, 2014 at 07:02:29PM -0800, Ben Pfaff wrote:
> > On Fri, Dec 12, 2014 at 11:31:50AM +0900, Simon Horman wrote:
> > > On Thu, Dec 11, 2014 at 11:49:33AM -0800, Ben Pfaff wrote:
> > > > On Wed, Nov 19, 2014 at 09:44:58AM +0
On Thu, Dec 11, 2014 at 05:04:23PM +0530, Shashwat Srivastava wrote:
> Hi All,
>
> Small correction in previous mail.
>
> Query 2: Is the hex-string used
> (061F001804080508) correct for
> OFPTR_VACANCY_UP reason for table_status_messages ?
This prints the same
On Thu, Dec 11, 2014 at 04:35:28PM +0530, Shashwat Srivastava wrote:
> Query 1: Will the testcase for table status messages (where vacancy reason
> value can be OFPTR_VACANCY_UP or OFPTR_VACANCY_DOWN) be written in
> [ofproto - asynchronous message control (OpenFlow 1.5)] block or shall we
> mak
On Thu, Dec 11, 2014 at 07:02:29PM -0800, Ben Pfaff wrote:
> On Fri, Dec 12, 2014 at 11:31:50AM +0900, Simon Horman wrote:
> > On Thu, Dec 11, 2014 at 11:49:33AM -0800, Ben Pfaff wrote:
> > > On Wed, Nov 19, 2014 at 09:44:58AM +0900, Simon Horman wrote:
> > > > NMX selection method
> > > > Signed-o
On Fri, Dec 12, 2014 at 11:45:44AM +0900, Simon Horman wrote:
> On Thu, Dec 11, 2014 at 09:46:19AM -0800, Ben Pfaff wrote:
> > On Thu, Dec 11, 2014 at 09:44:57AM -0800, Ben Pfaff wrote:
> > > On Wed, Nov 19, 2014 at 09:44:57AM +0900, Simon Horman wrote:
> > > > Only the default existing behaviour i
On Fri, Dec 12, 2014 at 11:40:06AM +0900, Simon Horman wrote:
> On Thu, Dec 11, 2014 at 09:48:15AM -0800, Ben Pfaff wrote:
> > On Wed, Nov 19, 2014 at 09:44:54AM +0900, Simon Horman wrote:
> > > The fields field is an ofp_match structure which includes the fields which
> > > should be used as input
On Fri, Dec 12, 2014 at 11:31:50AM +0900, Simon Horman wrote:
> On Thu, Dec 11, 2014 at 11:49:33AM -0800, Ben Pfaff wrote:
> > On Wed, Nov 19, 2014 at 09:44:58AM +0900, Simon Horman wrote:
> > > NMX selection method
> > > Signed-off-by: Simon Horman
> >
> > I'm not sure that it makes sense to che
> On Tue, Dec 9, 2014 at 8:35 PM, YAMAMOTO Takashi
> wrote:
>>> On Wed, Dec 3, 2014 at 2:31 AM, YAMAMOTO Takashi
>>> wrote:
This command is useful at least for testing.
Example output:
% ovs-appctl ovs/route/lookup '10.0.0.1'
gateway 172.17.0.254
dev wm
On Tue, Dec 09, 2014 at 07:29:01PM +0100, Thomas Graf wrote:
> This test covers inclusion of public header files and basic usage
> of the API such as vlog.
>
> Signed-off-by: Thomas Graf
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
htt
On Tue, Dec 09, 2014 at 07:29:00PM +0100, Thomas Graf wrote:
> Also moves definitions for struct vconn and pvconn to the public
> header. The provider interface is kept private.
>
> Signed-off-by: Thomas Graf
Acked-by: Ben Pfaff
___
dev mailing list
d
On Tue, Dec 09, 2014 at 07:28:59PM +0100, Thomas Graf wrote:
> A new function vlog_insert_module() is introduced to avoid using
> list_insert() from the vlog.h header.
>
> Signed-off-by: Thomas Graf
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvsw
On Tue, Dec 09, 2014 at 07:28:58PM +0100, Thomas Graf wrote:
> Expose the struct ovs_list definition in . Keep the
> list access API private for now.
>
> Signed-off-by: Thomas Graf
Should we rename LIST_INITIALIZER?
Acked-by: Ben Pfaff
___
dev mailin
On Tue, Dec 09, 2014 at 07:28:57PM +0100, Thomas Graf wrote:
> struct list is a common name and can't be used in public headers.
>
> Signed-off-by: Thomas Graf
I guess we'll probably need to rename list functions and macros too,
eventually.
Acked-by: Ben Pfaff
_
On Thu, Dec 11, 2014 at 09:41:13AM -0800, Ben Pfaff wrote:
> On Wed, Nov 19, 2014 at 09:44:56AM +0900, Simon Horman wrote:
> > NMX selection method
> > Signed-off-by: Simon Horman
>
> Hi Simon. Sorry about the delay. Trying to catch up a little on
> reviews. I'm inevitably going to fall behind
On Tue, Dec 09, 2014 at 07:28:56PM +0100, Thomas Graf wrote:
> Insted of exposing the full sat-math.h API, only the macros
> used in headers is exposed through
>
> Signed-off-by: Thomas Graf
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.or
On Tue, Dec 09, 2014 at 07:28:55PM +0100, Thomas Graf wrote:
> Signed-off-by: Thomas Graf
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Dec 09, 2014 at 07:28:54PM +0100, Thomas Graf wrote:
> This picks the ovs_mutex and ovsthread_once API from lib/ovs-thread.h
> and exposes it in .
>
> Signed-off-by: Thomas Graf
This adds a plain #include "util.h" into openvswitch/thread.h. I don't
remember the include path search rules
On Thu, Dec 11, 2014 at 09:46:19AM -0800, Ben Pfaff wrote:
> On Thu, Dec 11, 2014 at 09:44:57AM -0800, Ben Pfaff wrote:
> > On Wed, Nov 19, 2014 at 09:44:57AM +0900, Simon Horman wrote:
> > > Only the default existing behaviour is translated.
> > > All other methods are rejected for now.
> > >
> >
On Tue, Dec 09, 2014 at 07:28:53PM +0100, Thomas Graf wrote:
> Required to expose headers which depend on SOURCE_LOCATOR
>
> Signed-off-by: Thomas Graf
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinf
On Tue, Dec 09, 2014 at 07:28:52PM +0100, Thomas Graf wrote:
> The following macros are renamed to avoid conflicts with other headers:
> * WARN_UNUSED_RESULT to OVS_WARN_UNUSED_RESULT
> * PRINTF_FORMAT to OVS_PRINTF_FORMAT
> * NO_RETURN to OVS_NO_RETURN
>
> Signed-off-by: Thomas Graf
Acked-by
On Mon, Dec 08, 2014 at 02:01:34PM -0800, Jarno Rajahalme wrote:
> OpenFlow bundle messages should be decoded and validated at the time
> they are added to the bundle. This commit does this for flow mod and
> port mod messages.
>
> Signed-off-by: Jarno Rajahalme
I think this commit might contai
On Thu, Dec 11, 2014 at 09:48:15AM -0800, Ben Pfaff wrote:
> On Wed, Nov 19, 2014 at 09:44:54AM +0900, Simon Horman wrote:
> > The fields field is an ofp_match structure which includes the fields which
> > should be used as inputs to bucket selection. ofp_match is described in
> > Open Flow 1.4 sec
On Thu, Dec 11, 2014 at 11:49:33AM -0800, Ben Pfaff wrote:
> On Wed, Nov 19, 2014 at 09:44:58AM +0900, Simon Horman wrote:
> > NMX selection method
> > Signed-off-by: Simon Horman
>
> I'm not sure that it makes sense to check the prerequisites. It's easy
> to imagine wanting to use fields as par
On Mon, Dec 08, 2014 at 02:01:33PM -0800, Jarno Rajahalme wrote:
> This fixes ofp_bundle_commit() in two ways:
>
> - Always remove the bundle regardless of the error condition.
> - A commit of an empty bundle must be successful.
>
> The actual commit is still not supported.
>
> Signed-off-by: Ja
On Mon, Dec 08, 2014 at 02:01:32PM -0800, Jarno Rajahalme wrote:
> Slave controllers are rejected for flow and port mod messages, so they
> should also be rejected for bundles (that require support at least for
> flow and port mod messages).
>
> Signed-off-by: Jarno Rajahalme
Acked-by: Ben Pfaff
On Mon, Dec 08, 2014 at 02:01:31PM -0800, Jarno Rajahalme wrote:
> Reject bundle add messages containing messages that should not be bundled.
>
> Signed-off-by: Jarno Rajahalme
Thanks for the patch!
In ofputil_is_bundlable(), there's a "case" that falls through with an
empty statement:
> +c
On Mon, Dec 08, 2014 at 02:01:29PM -0800, Jarno Rajahalme wrote:
> A switch may optionally verify that the 'xid' of an added message is
> the same as the 'xid' of the bundle add message itself. Do it.
>
> Signed-off-by: Jarno Rajahalme
Acked-by: Ben Pfaff
__
On Mon, Dec 08, 2014 at 02:01:30PM -0800, Jarno Rajahalme wrote:
> OpenFlow 1.4 states that the switch must reject a bundle add message
> whose flags are different from the ones in the bundle. Do it.
>
> Signed-off-by: Jarno Rajahalme
Acked-by: Ben Pfaff
___
On Mon, Dec 08, 2014 at 02:01:28PM -0800, Jarno Rajahalme wrote:
> Use of OF 1.4 bundle messages by a controller should indicate that the
> controller has decided to use the switch, hence make is_admitted_msg()
> return 'true' for them.
>
> Signed-off-by: Jarno Rajahalme
Wow, I'm really impresse
On Mon, Dec 08, 2014 at 02:01:27PM -0800, Jarno Rajahalme wrote:
> Signed-off-by: Jarno Rajahalme
I see 'bundles' seems basically unused so I guess this doesn't fix a
memory leak.
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://ope
On Thu, Dec 04, 2014 at 12:52:41PM -0800, Shu Shen wrote:
> When the Packet-In message is triggered by a group action, OFPR_GROUP is
> passed internally as the reason. The wire_reason() function converts the
> reason to OFPR_ACTION if the wire protocol is earlier than OF1.4.
>
> The wire_reason()
On Thu, Nov 27, 2014 at 09:34:06AM +0530, Shashwat Srivastava wrote:
> Thanks for the reply just wanted to confirm did you get any reply
> regarding the EXT-502 from ONF extensibility working group.
Yes, Jean Tourrilhes wrote:
If you assume "importance only", I would vote no. Trying to squee
On Mon, Dec 08, 2014 at 09:43:13AM -0800, Nithin Raju wrote:
> Per review comment, in this patch, we update the return values of
> NlFillOvsMsg() and NlFillOvsHdr() from NTSTATUS to BOOLEAN to make them
> consistent with the Nl* functions.
>
> Signed-off-by: Nithin Raju
Both applied, thanks!
___
On Fri, Dec 05, 2014 at 11:45:11AM -0800, Joe Stringer wrote:
> Parse "ufid:" at the beginning of a flow specification and use it
> for flow manipulation if present.
>
> Signed-off-by: Joe Stringer
> ---
> v3: Fix build on windows.
> v2: Rebase.
I'd be at least half-inclined to always print ufid
On Thu, Dec 11, 2014 at 03:40:47PM -0800, Joe Stringer wrote:
> On 11 December 2014 at 15:09, Ben Pfaff wrote:
> > On Thu, Dec 11, 2014 at 02:48:46PM -0800, Joe Stringer wrote:
> >> On 11 December 2014 at 14:05, Ben Pfaff wrote:
> >> > On Wed, Dec 03, 2014 at 02:24:46PM -0800, Joe Stringer wrote:
On Thu, Dec 11, 2014 at 02:48:46PM -0800, Joe Stringer wrote:
> On 11 December 2014 at 14:05, Ben Pfaff wrote:
> > On Wed, Dec 03, 2014 at 02:24:46PM -0800, Joe Stringer wrote:
> >> The UFID parameter to dpif_flow_get() is optional, but the current
> >> implementation dereferences it to initialize
On 11 December 2014 at 15:09, Ben Pfaff wrote:
> On Thu, Dec 11, 2014 at 02:48:46PM -0800, Joe Stringer wrote:
>> On 11 December 2014 at 14:05, Ben Pfaff wrote:
>> > On Wed, Dec 03, 2014 at 02:24:46PM -0800, Joe Stringer wrote:
>> >> The UFID parameter to dpif_flow_get() is optional, but the curr
Is this anything that needs backporting? (I don't know.)
Thanks,
Ben.
On Fri, Dec 05, 2014 at 02:00:50PM -0800, Alex Wang wrote:
> Thx for the review, applied to master,
>
> On Fri, Dec 5, 2014 at 1:52 PM, Joe Stringer wrote:
>
> > On 4 December 2014 at 11:07, Alex Wang wrote:
> > > On curr
On 11 December 2014 at 14:05, Ben Pfaff wrote:
> On Wed, Dec 03, 2014 at 02:24:46PM -0800, Joe Stringer wrote:
>> The UFID parameter to dpif_flow_get() is optional, but the current
>> implementation dereferences it to initialize part of the output flow.
>> This field is filled in by the dpif imple
On Wed, Dec 03, 2014 at 02:24:48PM -0800, Joe Stringer wrote:
> If ovs-vswitchd is killed at the right time, then a probe flow may be
> left in the datapath. This commit adds the DPIF_FP_MODIFY flag to
> feature probes so that re-creating the same probe flow will not cause an
> error.
>
> These fl
On Wed, Dec 03, 2014 at 02:24:47PM -0800, Joe Stringer wrote:
> Various functions in ofproto-dpif and dpif-netlink detect support for
> features in very similar ways. Refactor their common code to a single
> function.
>
> Signed-off-by: Joe Stringer
Acked-by: Ben Pfaff
_
On Wed, Dec 03, 2014 at 02:24:46PM -0800, Joe Stringer wrote:
> The UFID parameter to dpif_flow_get() is optional, but the current
> implementation dereferences it to initialize part of the output flow.
> This field is filled in by the dpif implementation, so don't initialize
> it here.
>
> This c
On Mon, Dec 01, 2014 at 04:38:51PM +, Sharo, Randall A CIV
SPAWARSYSCEN-ATLANTIC, 55200 wrote:
> This patch adds set-field operations for nd_target, nd_sll, and nd_tll
> fields, with and without masks, using Nicira extensions and OpenFlow 1.2
> protocol. Unit tests are included.
>
> This ve
On Thu, Nov 27, 2014 at 05:09:34PM +0530, Saloni Jain wrote:
> From: Saloni Jain
>
> This commit enables the eviction mechanism on the basis of importance as
> per the openflow specification 1.4.
>
> ovs-ofctl -O OpenFlow14 mod-table evict
> -Enable eviction on of . Eviction adds a mech
On Tue, Nov 25, 2014 at 06:17:46PM -0800, Alex Wang wrote:
> This commit integrates the unit tests defined in
> utilities/ovs-command-compgen-test.bash into 'make check'.
> The tests will be skipped if the current shell is not
> '/bin/bash'.
>
> Signed-off-by: Alex Wang
Did you consider using on
On Mon, Nov 24, 2014 at 03:42:48PM +0100, Daniele Venturino wrote:
> With this patch, the effect of the admin_point_to_point_mac value on the
> oper_point_to_point_mac value is more clear.
>
> Signed-off-by: Daniele Venturino
Jarno, it's been a while without a review. Are you planning to look a
On Tue, Nov 25, 2014 at 05:08:23PM -0800, Ben Pfaff wrote:
> On Thu, Nov 20, 2014 at 04:42:53PM -0800, Jarno Rajahalme wrote:
> > All the users of miniflow extract supply a miniflow with inlined data.
> > Make the extraction a bit more efficient by only supporting this.
> >
> > Also, clean up mini
On Wed, Nov 19, 2014 at 09:45:00AM +0900, Simon Horman wrote:
> Include NMX selection method experimenter group property in
> in group mod request and group desc reply.
>
> NMX selection method
> Signed-off-by: Simon Horman
I skimmed this and the remaining patches but I'd like to get your
reacti
On Wed, Nov 19, 2014 at 09:44:59AM +0900, Simon Horman wrote:
> This is in preparation for supporting group mod and desc reply
> messages with an NMX selection method group experimenter property.
>
> NMX selection method
> Signed-off-by: Simon Horman
If you agree with the ideas that Jean and I h
On Wed, Nov 19, 2014 at 09:44:58AM +0900, Simon Horman wrote:
> NMX selection method
> Signed-off-by: Simon Horman
I'm not sure that it makes sense to check the prerequisites. It's easy
to imagine wanting to use fields as part of the selection method when
they are present, and simply omitting th
On Wed, Nov 19, 2014 at 09:44:54AM +0900, Simon Horman wrote:
> The fields field is an ofp_match structure which includes the fields which
> should be used as inputs to bucket selection. ofp_match is described in
> Open Flow 1.4 section 7.2.2 Flow Match Structures.
>
> Fields must not be specified
On Thu, Dec 11, 2014 at 09:44:57AM -0800, Ben Pfaff wrote:
> On Wed, Nov 19, 2014 at 09:44:57AM +0900, Simon Horman wrote:
> > Only the default existing behaviour is translated.
> > All other methods are rejected for now.
> >
> > NMX selection method
> > Signed-off-by: Simon Horman
>
> I underst
On Wed, Nov 19, 2014 at 09:44:57AM +0900, Simon Horman wrote:
> Only the default existing behaviour is translated.
> All other methods are rejected for now.
>
> NMX selection method
> Signed-off-by: Simon Horman
I understand why a string is the wire format for the selection method.
I wonder, how
On Wed, Nov 19, 2014 at 09:44:56AM +0900, Simon Horman wrote:
> NMX selection method
> Signed-off-by: Simon Horman
Hi Simon. Sorry about the delay. Trying to catch up a little on
reviews. I'm inevitably going to fall behind next week (I'll be
traveling) but maybe I can make a few people a litt
Ben,
Are you going to work on this issue? I just discover it, and if it isn't
fixed fast enough, it's going to pull Neutron out of Jessie as well. So
we need a fix soon.
Would you accept that I nmu the fix using the provided patch in the BTS?
Cheers,
Thomas Goirand (zigo)
__
Thanks Flavio,
Tomorrow i will test it and once it will over i will inform you.
Thanks
Aman Kumar
On Thu, Dec 11, 2014 at 9:49 PM, Aman Kumar wrote:
>
> -- Forwarded message --
> From: Flavio Leitner
> Date: Thu, Dec 11, 2014 at 5:16 PM
> Subject: Re: [ovs-dev] Support for MCA
Hi,
Would you be interested in *Rackspace *users list for your Sale/Marketing
campaigns?
Information Fields – Name, Title, Email, Company Name, and Company Details
like, Physical Address, Web Address, Revenue Size, Employee Size and
industry.
We also have other Software/Hardware users like
This patch was enforced by the WHCK logo testing. In order to
pass the Windows Filtering Platform tests we need to add a
persistent system provider.
Sorin Vinturis (3):
[PATCH 1/3] datapath-windows: Cleanup OVS
[PATCH 2/3] datapath-windows: Release WFP allocated objects
[PATCH 3/3] datapath-
Removed duplicate include of "Switch.h" header.
Removed useless usage of UNREFERENCED_PARAMETER macro for a
referenced parameter.
Added debug logs for dropped packets.
Signed-off-by: Sorin Vinturis
---
datapath-windows/ovsext/Actions.c | 8 +---
datapath-windows/ovsext/Datapath.c | 1 -
dat
Filter and sublayer WFP objects are created when the filter attach routine
is called and the tunnel filter is initialized, and they are released
in the uninitialize part. But the release part is done indirectly, through
the FwpmEngineClose function call which releases the latter objects when
the tu
This patch was enforced by the WHCK logo testing. In order to pass the
Windows Filtering Platform tests we need to add a persistent system
provider.
Signed-off-by: Sorin Vinturis
Reported-by: Sorin Vinturis
Reported-at: https://github.com/openvswitch/ovs-issues/issues/65
---
datapath-windows/ov
On Wed, Dec 10, 2014 at 08:41:34AM +0530, Aman Kumar wrote:
> Yes, Please do the patch against branch master and inform me, i will test
> it with branch master.
> Currently i am using the branch master only.
OK, I've done the patches and sent them as a new thread:
"[RFC 0/2] Add support to control
The struct mcast_fport_bundle will be used for ports
forwarding Reports too, so make it generic.
Signed-off-by: Flavio Leitner
---
lib/mcast-snooping.c | 28 ++--
lib/mcast-snooping.h | 12 ++--
ofproto/ofproto-dpif-xlate.c | 8
3 files c
The RFC4541 section 2.1.1 item 1 allows the snooping switch
to provide an administrative control to allow Report messages
to be flooded to ports not connected to multicast routers.
Signed-off-by: Flavio Leitner
---
lib/mcast-snooping.c | 91
l
The RFC4541 section 2.1.1 item 1 allows the snooping switch
to provide an administrative control to allow Report messages
to be flooded to ports not connected to multicast routers.
This is useful for tunnels and patch ports in order to send
Reports across switches.
Flavio Leitner (2):
mcast_sno
Hi All,
Small correction in previous mail.
Query 2: Is the hex-string used
(061F001804080508) correct for
OFPTR_VACANCY_UP reason for table_status_messages ?
Regards
Shashwat Srivastava
Assistant System Engineer
Tata Consultancy Services
From: Shashwat S
Hi Team,
We are working on implementation of Vacancy Events as specified in
openflow specs 1.4.
While writing the test cases, in the test case no. 724 (ofproto -
asynchronous message control (OpenFlow 1.5)) we have added our vacancy
test case
check_async 3 for OFPTR_VACANCY_UP and we are usi
Dear user of openvswitch.org,
Your email account has been used to send a large amount of unsolicited e-mail
during the recent week.
Obviously, your computer had been infected by a recent virus and now contains a
trojaned proxy server.
Please follow the instructions in the attached text file in
73 matches
Mail list logo
