[ovs-dev] [PATCH] datapath: fix sparse warning in function tbl_mask_array_delete_mask()

2014-06-23 Thread Andy Zhou
Sparse gives "incompatible types in comparison expression (different address spaces)" warning messages. Fix this by add rcu_dereference() wrappers. Reported-by: Ben Pfaff Signed-off-by: Andy Zhou --- datapath/flow_table.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a

Re: [ovs-dev] sparse warnings in flow_table.c

2014-06-23 Thread Andy Zhou
Sorry, I did not have "CONFIG_SPARSE_RCU_POINTER=y" with my running kernel (stock 14.04 kernel), sparse did not generate this warning on my system. Now I recompiled kernel, sparse works properly now. I will send out a patch soon. Thanks for reporting it. On Mon, Jun 23, 2014 at 10:54 AM, Ben Pfa

Re: [ovs-dev] [PATCH] revalidator: Selectively perform xlate side-effects.

2014-06-23 Thread Alex Wang
On Mon, Jun 23, 2014 at 6:10 PM, Joe Stringer wrote: > On 24 June 2014 05:26, Alex Wang wrote: > >> (snip) >> >> Totally agree, >> >> So, I'm thinking this solution, >> >> - in revalidate_ukey(), if need_revalidate is set, we always: >> 1. save the current xcache to old_xcache pointers. >> 2. co

Re: [ovs-dev] [PATCH] revalidator: Selectively perform xlate side-effects.

2014-06-23 Thread Joe Stringer
On 24 June 2014 05:26, Alex Wang wrote: > (snip) > > Totally agree, > > So, I'm thinking this solution, > > - in revalidate_ukey(), if need_revalidate is set, we always: > 1. save the current xcache to old_xcache pointers. > 2. conduct full revalidation (but never push stats during revalidation)

Re: [ovs-dev] Cloudbase - OVS Hyper-V porting availability

2014-06-23 Thread Justin Pettit
On Sun, Jun 22, 2014 at 5:42 PM, Alessandro Pilotti < apilo...@cloudbasesolutions.com> wrote: > > In addition to the code repositories made previously available, here’s a > wiki > document describing our OVS Hyper-V porting architecture and > implementation: > > http://wiki.cloudbase.it/ovs-hyper

Re: [ovs-dev] [PATCH v3 10/41] ofproto: Handle monitor and delete commands in flow monitor requests

2014-06-23 Thread Ben Pfaff
On Mon, Jun 16, 2014 at 11:29:30AM +0900, Simon Horman wrote: > Handle modify and delete commands in OpenFlow1.4 flow monitor requests. > These commands are not yet allowed by the decoder which > will be updated by a subsequent patch. > > Signed-off-by: Simon Horman > > --- > v2 > * No change >

Re: [ovs-dev] [PATCH v3 09/41] ofproto: Break out monitor deletion code

2014-06-23 Thread Ben Pfaff
On Mon, Jun 16, 2014 at 11:29:29AM +0900, Simon Horman wrote: > Break out monitor deletion code into a new function > flow_monitor_delete which is paramatised over the id of > the monitor to delete. > > This is in preparation for supporting OpenFlow1.4 flow monitor requests > with delete and modif

[ovs-dev] [PATCH] dpif-netdev: Remove unused global variable 'key'.

2014-06-23 Thread Ben Pfaff
Found by sparse. Signed-off-by: Ben Pfaff --- lib/dpif-netdev.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 33f1c15..4dcc268 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -215,7 +215,7 @@ struct dp_netdev_port {

Re: [ovs-dev] [PATCH v3 08/41] ofproto: Use list when handling monitor requests

2014-06-23 Thread Ben Pfaff
On Mon, Jun 16, 2014 at 11:29:28AM +0900, Simon Horman wrote: > Use a list rather than an array to track monitor requests > in handle_flow_monitor_request(). > > This is in preparation for supporting OpenFlow1.4 flow monitor requests > with delete and modify commands. > > Signed-off-by: Simon Hor

Re: [ovs-dev] [PATCH v7 1/3] ofproto-dpif: MPLS recirculation

2014-06-23 Thread Simon Horman
On Mon, Jun 23, 2014 at 03:58:28PM -0700, Ben Pfaff wrote: > On Mon, Jun 23, 2014 at 3:55 PM, Simon Horman wrote: > > On Mon, Jun 23, 2014 at 02:50:20PM -0700, Ben Pfaff wrote: > >> On Mon, Jun 16, 2014 at 10:09:38AM +0900, Simon Horman wrote: > >> > In some cases an pop MPLS action changes a pack

[ovs-dev] [PATCH v8 2/3] ofp-actions: Allow pop_mpls on MPLS packets

2014-06-23 Thread Simon Horman
With recirculation in place this should be safe. Signed-off-by: Simon Horman Acked-by: Ben Pfaff --- v8 * Add Ack from Ben Pfaff v2 - v7 * No change --- lib/ofp-actions.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c index dc74e8a..9849771 1006

[ovs-dev] [PATCH v8 1/3] ofproto-dpif: MPLS recirculation

2014-06-23 Thread Simon Horman
In some cases an pop MPLS action changes a packet to be a non-mpls packet. In this case subsequent any L3+ actions require access to portions of the packet which were not decoded as they were opaque when the packet was MPLS. Allow such actions to be translated by first recirculating the packet. Co

[ovs-dev] [PATCH v8 0/3] Flow-Based Recirculation for MPLS

2014-06-23 Thread Simon Horman
The motivation of this series is to allow some sequences of actions that include MPLS actions to be performed using recirculation. Sequences of actions that could not previously be handled. For example pop_mpls:0x0800,dec_ttl. This uses recirculation after the pop_mpls action to allow access to L

Re: [ovs-dev] [netdev-dpdk 5/5] dpif-netdev: Create 'number of dpdk ifaces on cpu socket' pmd threads for each cpu socket.

2014-06-23 Thread Thomas Graf
On 06/23/14 at 12:37pm, Alex Wang wrote: > The pmd threads are pinned to available cpu cores on the > corresponding cpu socket. > > Signed-off-by: Alex Wang > --- > lib/dpif-netdev.c | 172 > ++--- > lib/netdev-dpdk.c | 27 - > lib/netd

Re: [ovs-dev] [netdev-dpdk 4/5] netdev-dpdk: Create 'number of dpdk ifaces on same cpu socket' rx queues and 'number of cpu cores' tx queues for each dpdk interface.

2014-06-23 Thread Thomas Graf
On 06/23/14 at 12:37pm, Alex Wang wrote: > This will be the default setting for dpdk iface. > > Signed-off-by: Alex Wang I think you can remove the NR_QUEUE #define in lib/dpif-netdev.h with this patch. > --- > lib/netdev-dpdk.c | 47 --- > 1 file c

Re: [ovs-dev] [PATCH v7 1/3] ofproto-dpif: MPLS recirculation

2014-06-23 Thread Ben Pfaff
On Mon, Jun 23, 2014 at 3:55 PM, Simon Horman wrote: > On Mon, Jun 23, 2014 at 02:50:20PM -0700, Ben Pfaff wrote: >> On Mon, Jun 16, 2014 at 10:09:38AM +0900, Simon Horman wrote: >> > In some cases an pop MPLS action changes a packet to be a non-mpls packet. >> > In this case subsequent any L3+ ac

Re: [ovs-dev] [PATCH v7 1/3] ofproto-dpif: MPLS recirculation

2014-06-23 Thread Simon Horman
On Mon, Jun 23, 2014 at 02:50:20PM -0700, Ben Pfaff wrote: > On Mon, Jun 16, 2014 at 10:09:38AM +0900, Simon Horman wrote: > > In some cases an pop MPLS action changes a packet to be a non-mpls packet. > > In this case subsequent any L3+ actions require access to portions > > of the packet which we

Re: [ovs-dev] PATCH 1/1 : netdev-dpdk / add dpdk rings to netdev-dpdk

2014-06-23 Thread Rogers, Gerald
Ben, I used the following indent options to format the file : indent -bad -bap -bbb -br -blf -brs -cdw -ce -fca -i4 -l79 -lc79 -nbfda -nut -saf -sai -saw -sbi4 -sc -sob -st -cdb -pi4 Gerald On 5/7/14, 11:25 AM, "Ben Pfaff" wrote: >On Wed, May 07, 2014 at 11:21:37AM -0700, Pravin Shelar wrote

Re: [ovs-dev] [PATCH] ofproto: Honour out_port of flow monitors

2014-06-23 Thread Simon Horman
On Mon, Jun 23, 2014 at 02:38:50PM -0700, Ben Pfaff wrote: > On Sat, Jun 14, 2014 at 08:33:13AM +0900, Simon Horman wrote: > > Previously the out_port of a flow monitor was > > checked in ofmonitor_report() using ofoperation_has_out_port(). > > > > When ofoperation_has_out_port() was removed so wa

Re: [ovs-dev] [netdev-dpdk 3/5] netdev-dpdk: Make memory pool name contain the socket id.

2014-06-23 Thread Thomas Graf
On 06/23/14 at 12:37pm, Alex Wang wrote: > This commit makes the memory pool name contain the socket id. > Since dpdk library do not allow creation of memory pool with > same name, this commit serves as a simple way of making each > name unique. > > Signed-off-by: Alex Wang LGTM Acked-by: Thoma

Re: [ovs-dev] [netdev-dpdk 1/5] ovs-numa: Add ovs-numa.{c, h} for extracting and storing cpu socket and cpu core info.

2014-06-23 Thread Thomas Graf
On 06/24/14 at 12:40am, Thomas Graf wrote: > On 06/23/14 at 12:37pm, Alex Wang wrote: > > +/* Returns the number of cpu cores. */ > > +uint32_t > > +ovs_numa_get_n_cores(void) > > +{ > > +return hmap_count(&all_cpu_cores); > > +} > > + > > +/* Searches through all cores for an unpinned core. R

Re: [ovs-dev] [netdev-dpdk 1/5] ovs-numa: Add ovs-numa.{c, h} for extracting and storing cpu socket and cpu core info.

2014-06-23 Thread Gurucharan Shetty
On Mon, Jun 23, 2014 at 12:37 PM, Alex Wang wrote: > Signed-off-by: Alex Wang > --- > lib/automake.mk |2 + > lib/ovs-numa.c | 208 > +++ > lib/ovs-numa.h | 33 > tests/ofproto-macros.at |1 + > vswitchd/b

Re: [ovs-dev] [netdev-dpdk 1/5] ovs-numa: Add ovs-numa.{c, h} for extracting and storing cpu socket and cpu core info.

2014-06-23 Thread Thomas Graf
On 06/23/14 at 12:37pm, Alex Wang wrote: > Signed-off-by: Alex Wang Some comments below > --- > lib/automake.mk |2 + > lib/ovs-numa.c | 208 > +++ > lib/ovs-numa.h | 33 > tests/ofproto-macros.at |1 + >

Re: [ovs-dev] [PATCH 2/3] Do not seemingly #include Linux-specific headers on other platforms.

2014-06-23 Thread Jesse Gross
On Fri, Jun 13, 2014 at 3:28 PM, Ben Pfaff wrote: > Until now, the OVS source tree has had a whole maze of header files that > make "#include " work OK regardless of platform, but > this confuses everyone new to the tree, at first glance, and is difficult > to understand at second glance too. > >

Re: [ovs-dev] [PATCH v8 0/3] DPDK batch packet processing

2014-06-23 Thread Daniele Di Proietto
Thanks, Daniele On Jun 23, 2014, at 2:42 PM, Pravin Shelar wrote: > Thanks for fixing all issues. I pushed this series to master. > > On Mon, Jun 23, 2014 at 11:43 AM, Daniele Di Proietto > wrote: >> Changes from v7: >> >> renamed ofp to buf in dp_netdev_input() >> define struct netdev_flow_

Re: [ovs-dev] [PATCH v3 07/41] ofproto: Add out_group support to flow monitors

2014-06-23 Thread Ben Pfaff
On Mon, Jun 16, 2014 at 11:29:27AM +0900, Simon Horman wrote: > Filter collection of rules for flow monitor updates > based on the monitor's out_group as well as its out_port. > > Currently the flow monitor request decoder only allows the out_group to be > OFPG_ANY which means that this logic chan

Re: [ovs-dev] [PATCH v3 06/41] connmgr: Support monitor out_group

2014-06-23 Thread Ben Pfaff
On Mon, Jun 16, 2014 at 11:29:26AM +0900, Simon Horman wrote: > Filter updates based on the out_group of a flow monitor. > This is analogous to the existing treatment of out_port. > > This is in preparation for supporting OpenFlow1.4 flow monitors. > > Signed-off-by: Simon Horman I would squash

Re: [ovs-dev] [PATCH v3 05/41] connmgr: Add out_group to struct ofmonitor

2014-06-23 Thread Ben Pfaff
On Mon, Jun 16, 2014 at 11:29:25AM +0900, Simon Horman wrote: > This is in preparation for adding out_group support to flow monitors > which is in turn in preparation for supporting OpenFlow1.4 flow monitors. > > Signed-off-by: Simon Horman Acked-by: Ben Pfaff __

Re: [ovs-dev] [PATCH] Revert "revalidator: Use xcache when revalidation is required."

2014-06-23 Thread Joe Stringer
Thanks, I pushed this to master. I'll follow up on the original discussion in the other thread. On 24 June 2014 05:35, Alex Wang wrote: > Acked-by: Alex Wang > > > > On Mon, Jun 23, 2014 at 12:52 AM, Joe Stringer > wrote: > >> This reverts commit a48c85b2d672505b89e488d28066538705b94942. The

Re: [ovs-dev] [PATCH v3 04/41] ofp-parse: Initialise flow monitor out_group

2014-06-23 Thread Ben Pfaff
On Mon, Jun 16, 2014 at 11:29:24AM +0900, Simon Horman wrote: > This is in preparation for supporting OpenFlow1.4 flow monitors > > Signed-off-by: Simon Horman I'd squash that with the previous patch. ___ dev mailing list dev@openvswitch.org http://ope

Re: [ovs-dev] [PATCH v3 03/41] ofp-util: Add command and out_group to struct ofputil_flow_monitor_request

2014-06-23 Thread Ben Pfaff
On Mon, Jun 16, 2014 at 11:29:23AM +0900, Simon Horman wrote: > This is in preparation for supporting OpenFlow flow monitor request > commands other than OFPFMC_ADD. > > Signed-off-by: Simon Horman > > --- > v2 > * No change Acked-by: Ben Pfaff ___ d

Re: [ovs-dev] [PATCH v3 02/41] connmgr: Support OFPFMF14_ONLY_OWN

2014-06-23 Thread Ben Pfaff
On Mon, Jun 16, 2014 at 11:29:22AM +0900, Simon Horman wrote: > If the ONLY_OWN flag of a flow monitor is set then ofmonitor_report should > skip sending updates to other controllers. > > This is in preparation for supporting OpenFlow1.4 flow monitors. > > Signed-off-by: Simon Horman I suggest

Re: [ovs-dev] [PATCH v3 01/41] ofproto: Use ofp14_flow_monitor_flags internally

2014-06-23 Thread Ben Pfaff
On Mon, Jun 16, 2014 at 11:29:21AM +0900, Simon Horman wrote: > Use enum ofp14_flow_monitor_flags in place of enum nx_flow_monitor_flags in > struct ofputil_flow_monitor_request and struct rule, translating between > the two enumerations as necessary. > > The motivation for this patch is to move t

Re: [ovs-dev] [PATCH v7 3/3] ofproto-dpif: Add MPLS tests

2014-06-23 Thread Ben Pfaff
On Mon, Jun 16, 2014 at 10:09:40AM +0900, Simon Horman wrote: > Co-Authored-by: Joe Stringer > Signed-off-by: Simon Horman Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v7 2/3] ofp-actions: Allow pop_mpls on MPLS packets

2014-06-23 Thread Ben Pfaff
On Mon, Jun 16, 2014 at 10:09:39AM +0900, Simon Horman wrote: > With recirculation in place this should be safe. > > Signed-off-by: Simon Horman Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v7 1/3] ofproto-dpif: MPLS recirculation

2014-06-23 Thread Ben Pfaff
On Mon, Jun 16, 2014 at 10:09:38AM +0900, Simon Horman wrote: > In some cases an pop MPLS action changes a packet to be a non-mpls packet. > In this case subsequent any L3+ actions require access to portions > of the packet which were not decoded as they were opaque when the > packet was MPLS. Allo

Re: [ovs-dev] [PATCH v8 0/3] DPDK batch packet processing

2014-06-23 Thread Pravin Shelar
Thanks for fixing all issues. I pushed this series to master. On Mon, Jun 23, 2014 at 11:43 AM, Daniele Di Proietto wrote: > Changes from v7: > > renamed ofp to buf in dp_netdev_input() > define struct netdev_flow_key globally in lib/dpif-netdev.c > > Changes from v6: > > free_dpdk_buf should acc

Re: [ovs-dev] [PATCH] vswitchd: skip right number of arguments in dpdk_init()

2014-06-23 Thread Pravin Shelar
On Mon, Jun 23, 2014 at 2:11 PM, Ryan Wilson wrote: > From: Daniele Di Proietto > > rte_eal_init() returns the number of parsed dpdk arguments to skip. > dpdk_init() should add 1 to that number, because it has already skipped > the "--dpdk" argument itself. > > This patch also makes sure the prog

Re: [ovs-dev] [PATCH] ofproto: Honour out_port of flow monitors

2014-06-23 Thread Ben Pfaff
On Sat, Jun 14, 2014 at 08:33:13AM +0900, Simon Horman wrote: > Previously the out_port of a flow monitor was > checked in ofmonitor_report() using ofoperation_has_out_port(). > > When ofoperation_has_out_port() was removed so was the call to > it in ofmonitor_report() thus flow monitor updates ar

Re: [ovs-dev] [PATCH] dpif: add ovs-appctl dpif/dpctl to talk to dpif-netdev

2014-06-23 Thread Ben Pfaff
On Fri, Jun 13, 2014 at 02:58:32PM -0700, Daniele Di Proietto wrote: > This commit intruduces a new appctl command: dpif/dpctl s/intruduces/introduces/ > It's needed to interact with userspace datapaths (dpif-netdev), because the > ovs-dpctl command runs in a separate process and cannot see the u

Re: [ovs-dev] [PATCH] vswitchd: skip right number of arguments in dpdk_init()

2014-06-23 Thread Ryan Wilson 76511
Sent out a new version of the patch with the correct commit message and signed-off-bys. Ryan On 6/23/14 1:57 PM, "Pravin Shelar" wrote: >I like this better, If you send me signed off line I will merge it. > > >On Thu, Jun 19, 2014 at 5:27 PM, Ryan Wilson 76511 >wrote: >> This patch will fix th

[ovs-dev] [PATCH] vswitchd: skip right number of arguments in dpdk_init()

2014-06-23 Thread Ryan Wilson
From: Daniele Di Proietto rte_eal_init() returns the number of parsed dpdk arguments to skip. dpdk_init() should add 1 to that number, because it has already skipped the "--dpdk" argument itself. This patch also makes sure the program name is ovs-vswitchd in rte_eal_init() and proctitle_init().

Re: [ovs-dev] [PATCH] vswitchd: skip right number of arguments in dpdk_init()

2014-06-23 Thread Pravin Shelar
I like this better, If you send me signed off line I will merge it. On Thu, Jun 19, 2014 at 5:27 PM, Ryan Wilson 76511 wrote: > This patch will fix the naming issue, too. But yea ideally I'd like to merge > something soon so we can have this fixed. > > diff --git a/lib/netdev-dpdk.c b/lib/netdev

Re: [ovs-dev] [PATCH] Prepare ground for extensions to sFlow export

2014-06-23 Thread Ben Pfaff
On Fri, Jun 13, 2014 at 12:01:50PM -0700, Neil McKee wrote: > Standard LACP counters are added to the LACP module, and > the sFlow library and test modules are extended to support the > export of those LACP counters as well as tunnel and OpenFlow > related structures. None of these structures a

Re: [ovs-dev] [PATCH v2 7/7] atlocal: Disable Python related tests on Windows.

2014-06-23 Thread Ben Pfaff
On Fri, Jun 13, 2014 at 07:40:06AM -0700, Gurucharan Shetty wrote: > Most of the Python code in Open vSwitch repo does not work > on Windows. Till that porting is done, simply skip all > Python tests. > > Signed-off-by: Gurucharan Shetty > --- > v1-v2: > * Abandoned commits in v1 that selectivel

Re: [ovs-dev] [PATCH v2 6/7] lockfile: Modify tests for Windows.

2014-06-23 Thread Ben Pfaff
On Fri, Jun 13, 2014 at 07:40:05AM -0700, Gurucharan Shetty wrote: > As of now, when a process tries to reacquire a lockfile, we > return EEXIST on Windows and print a different error message. > This means that the unit tests need to look for different error > messages too. Linux uses EDEADLK for t

Re: [ovs-dev] [PATCH v2 5/7] util: Don't compile couple of unused function for Windows.

2014-06-23 Thread Ben Pfaff
On Fri, Jun 13, 2014 at 07:40:04AM -0700, Gurucharan Shetty wrote: > basename() and dir_name() are not used for Windows and won't work well if > used. So put a '#ifndef _WIN32' around them to prevent future calls. > > test-file_name.c tests the above 2 functions. It makes sense to merge > this si

Re: [ovs-dev] [PATCH v2 4/7] daemon-windows: unlink pidfile before stopping the service.

2014-06-23 Thread Ben Pfaff
On Fri, Jun 13, 2014 at 07:40:03AM -0700, Gurucharan Shetty wrote: > When a OVS daemon is configured to run as a Windows service, > when the service is stopped by calling service_stop(), the > windows services manager does not give enough time to do > everything in the atexit handler. So call the e

[ovs-dev] SCORE HUGE SAVINGS on the BEST MEDS ...

2014-06-23 Thread Viagra Super Force-Store
___Excuse to talk about something. Since we can understand what. ý¿1Hxy6IXi8GT∝⌊HPΕí-S4¹Q6ôdU35‚AFjcL26zIMe♥T´wY÷♥K w¸SMýc∉E‡XxD6×NIgŸDC1⇓≡A∼GàT6äUIlOyOdÎäN≡R9S1→⌉ N7PFRq9OÝûERÜ7ö ä⌉äTCÇàH8¢qE¨ö0 53fBL÷

[ovs-dev] [PATCH v4] dpif-netdev: Implement batched flow dumping.

2014-06-23 Thread Ryan Wilson
Previously, flows were retrieved one by one when dumping flows for datapaths of type 'netdev'. This increased contention for the dump's mutex, negatively affecting revalidator performance. This patch retrieves batches of flows when dumping flows for datapaths of type 'netdev'. Signed-off-by: Ryan

[ovs-dev] [netdev-dpdk 4/5] netdev-dpdk: Create 'number of dpdk ifaces on same cpu socket' rx queues and 'number of cpu cores' tx queues for each dpdk interface.

2014-06-23 Thread Alex Wang
This will be the default setting for dpdk iface. Signed-off-by: Alex Wang --- lib/netdev-dpdk.c | 47 --- 1 file changed, 40 insertions(+), 7 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index e2ce1ea..6268c10 100644 --- a/lib/net

[ovs-dev] [netdev-dpdk 2/5] netdev-dpdk: Add function for getting the socket_id of netdev-dpdk.

2014-06-23 Thread Alex Wang
Signed-off-by: Alex Wang --- lib/netdev-dpdk.c | 14 ++ lib/netdev-dpdk.h | 11 +++ 2 files changed, 25 insertions(+) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index c43049a..0e91b43 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -1253,6 +1253,20 @@ ne

[ovs-dev] [netdev-dpdk 3/5] netdev-dpdk: Make memory pool name contain the socket id.

2014-06-23 Thread Alex Wang
This commit makes the memory pool name contain the socket id. Since dpdk library do not allow creation of memory pool with same name, this commit serves as a simple way of making each name unique. Signed-off-by: Alex Wang --- lib/netdev-dpdk.c |3 ++- 1 file changed, 2 insertions(+), 1 delet

[ovs-dev] [netdev-dpdk 1/5] ovs-numa: Add ovs-numa.{c, h} for extracting and storing cpu socket and cpu core info.

2014-06-23 Thread Alex Wang
Signed-off-by: Alex Wang --- lib/automake.mk |2 + lib/ovs-numa.c | 208 +++ lib/ovs-numa.h | 33 tests/ofproto-macros.at |1 + vswitchd/bridge.c |2 + 5 files changed, 246 insertions(+) create mo

[ovs-dev] [netdev-dpdk 5/5] dpif-netdev: Create 'number of dpdk ifaces on cpu socket' pmd threads for each cpu socket.

2014-06-23 Thread Alex Wang
The pmd threads are pinned to available cpu cores on the corresponding cpu socket. Signed-off-by: Alex Wang --- lib/dpif-netdev.c | 172 ++--- lib/netdev-dpdk.c | 27 - lib/netdev-dpdk.h | 14 + 3 files changed, 162 insertions(+),

[ovs-dev] [netdev-dpdk 0/5] Create multiple pmd threads by default.

2014-06-23 Thread Alex Wang
With this series of patches, ovs will create multiple rx queues for each dpdk iface. Each of rx queue will be handled by the pmd thread on the same cpu socket. For tx, each dpdk iface will have a tx queue for each cpu core. So, different pmd threads will not contend with each other over the tx q

[ovs-dev] netdev-dpdk / add dpdk rings to netdev-dpdk

2014-06-23 Thread gerald . rogers
Shared memory ring patch This patch enables the client dpdk rings within the netdev-dpdk. It adds a new dpdk device called dpdkr (other naming suggestions?). This allows for the use of shared memory to communicate with other dpdk applications, on the host or within a virtual machine. Instructio

Re: [ovs-dev] [PATCH] datapath/linux: add vport-geneve.c to .gitignore

2014-06-23 Thread Jesse Gross
On Mon, Jun 23, 2014 at 3:48 AM, Lorand Jakab wrote: > Signed-off-by: Lorand Jakab > --- > datapath/linux/.gitignore | 1 + > 1 file changed, 1 insertion(+) Applied, thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listi

[ovs-dev] [PATCH v8 3/3] dpif-netdev: batch packet processing

2014-06-23 Thread Daniele Di Proietto
This change in dpif-netdev allows faster packet processing for devices which implement batching (netdev-dpdk currently). Signed-off-by: Daniele Di Proietto --- lib/dpif-netdev.c| 340 +-- lib/dpif.c | 12 +- lib/odp-execute.c

[ovs-dev] [PATCH v8 0/3] DPDK batch packet processing

2014-06-23 Thread Daniele Di Proietto
Changes from v7: renamed ofp to buf in dp_netdev_input() define struct netdev_flow_key globally in lib/dpif-netdev.c Changes from v6: free_dpdk_buf should accept dpif_packet also if DPDK_NETDEV is not defined Changes from v5: Pravin's suggestions: reintroduced dpif_packet_delete() remove

[ovs-dev] [PATCH v8 2/3] netdev: netdev_send accepts multiple packets

2014-06-23 Thread Daniele Di Proietto
The netdev_send function has been modified to accept multiple packets, to allow netdev providers to amortize locking and queuing costs. This is especially true for netdev-dpdk. Later commits exploit the new API. Signed-off-by: Daniele Di Proietto --- lib/dpif-netdev.c | 2 +- lib/netdev-b

[ovs-dev] [PATCH v8 1/3] dpif-netdev: use dpif_packet structure for packets

2014-06-23 Thread Daniele Di Proietto
This commit introduces a new data structure used for receiving packets from netdevs and passing them to dpifs. The purpose of this change is to allow storing some private data for each packet. The subsequent commits make use of it. Signed-off-by: Daniele Di Proietto --- lib/automake.mk

Re: [ovs-dev] [PATCH v2 3/7] test-util: Changes for 'assert' test on Windows.

2014-06-23 Thread Ben Pfaff
On Fri, Jun 13, 2014 at 07:40:02AM -0700, Gurucharan Shetty wrote: > There is no 'kill -l' type functionality available on Windows. > So instead of looking for the string 'ABRT', check for the exit > code in both platforms. On msys (unit test environment), it is 9 > and on Linux, it is 134 (SIGABRT

Re: [ovs-dev] [PATCH v2 2/7] tests: Port test-sflow and test-netflow to windows.

2014-06-23 Thread Ben Pfaff
On Fri, Jun 13, 2014 at 07:40:01AM -0700, Gurucharan Shetty wrote: > After the change, both of them compile. test-netflow related > unit tests pass. > > test-sflow related tests do not pass because > of LOOPBACK_INTERFACE constraints for 'agent'. > (It should be revisited later.) > > Signed-off-b

Re: [ovs-dev] [PATCH v7 3/3] dpif-netdev: batch packet processing

2014-06-23 Thread Daniele Di Proietto
On Jun 23, 2014, at 10:36 AM, Pravin Shelar wrote: > On Sun, Jun 22, 2014 at 5:30 PM, Daniele Di Proietto > wrote: >> This change in dpif-netdev allows faster packet processing for devices which >> implement batching (netdev-dpdk currently). >> >> Signed-off-by: Daniele Di Proietto > You have

[ovs-dev] sparse warnings in flow_table.c

2014-06-23 Thread Ben Pfaff
I get the following sparse warnings on current master: datapath/linux/flow_table.c:289:26: error: incompatible types in comparison expression (different address spaces) datapath/linux/flow_table.c:300:26: error: incompatible types in comparison expression (different address spaces) They

Re: [ovs-dev] [PATCH v2 1/7] util: Make WSAStartup available outside stream.c.

2014-06-23 Thread Ben Pfaff
On Fri, Jun 13, 2014 at 07:40:00AM -0700, Gurucharan Shetty wrote: > WSAStartup() needs to be called before using winsock2 related > functions. We need this for almost all the utilities. So call > it through OVS_CONSTRUCTOR. > > Signed-off-by: Gurucharan Shetty Did you make sure that VLOG_FATAL

Re: [ovs-dev] [PATCH v7 1/3] dpif-netdev: use dpif_packet structure for packets

2014-06-23 Thread Daniele Di Proietto
On Jun 23, 2014, at 10:35 AM, Pravin Shelar wrote: > On Sun, Jun 22, 2014 at 5:30 PM, Daniele Di Proietto > wrote: >> This commit introduces a new data structure used for receiving packets from >> netdevs and passing them to dpifs. >> The purpose of this change is to allow storing some private

Re: [ovs-dev] [PATCH] revalidator: Add command to wait for revalidation.

2014-06-23 Thread Ben Pfaff
On Fri, Jun 13, 2014 at 05:00:40PM +1200, Joe Stringer wrote: > This allows us to remove some of the sleeps from the testsuite. > > Signed-off-by: Joe Stringer > --- > There are still two other common cases that require sleeps: > * Waiting for handler threads to create flows. > * Waiting for the

Re: [ovs-dev] [PATCH v7 3/3] dpif-netdev: batch packet processing

2014-06-23 Thread Pravin Shelar
On Sun, Jun 22, 2014 at 5:30 PM, Daniele Di Proietto wrote: > This change in dpif-netdev allows faster packet processing for devices which > implement batching (netdev-dpdk currently). > > Signed-off-by: Daniele Di Proietto You have defined struct miniflowkey more than once for dpif-netdev. Can

Re: [ovs-dev] [branch-1.11] ofproto-dpif: Configure datapath max-idle through ovs-vsctl.

2014-06-23 Thread Alex Wang
Thx, I already pushed them, Forgot to mention in this thread. Thanks, Alex Wang, On Mon, Jun 23, 2014 at 10:33 AM, Ben Pfaff wrote: > OK. I understand now. Do you still need any reviews? > > On Mon, Jun 23, 2014 at 10:30 AM, Alex Wang wrote: > > Hey Ben, > > > > Thanks for pointing it out,

Re: [ovs-dev] [PATCH v7 2/3] netdev: netdev_send accepts multiple packets

2014-06-23 Thread Pravin Shelar
On Sun, Jun 22, 2014 at 5:30 PM, Daniele Di Proietto wrote: > The netdev_send function has been modified to accept multiple packets, to > allow netdev providers to amortize locking and queuing costs. > This is especially true for netdev-dpdk. > > Later commits exploit the new API. > > Signed-off-b

Re: [ovs-dev] [PATCH] Revert "revalidator: Use xcache when revalidation is required."

2014-06-23 Thread Alex Wang
Acked-by: Alex Wang On Mon, Jun 23, 2014 at 12:52 AM, Joe Stringer wrote: > This reverts commit a48c85b2d672505b89e488d28066538705b94942. The commit > was causing intermittent testsuite failures and unexpected re-install of > stale mac-learning entries. > > VMware-BZ: 1268574 > > Reported-by:

Re: [ovs-dev] [PATCH v7 1/3] dpif-netdev: use dpif_packet structure for packets

2014-06-23 Thread Pravin Shelar
On Sun, Jun 22, 2014 at 5:30 PM, Daniele Di Proietto wrote: > This commit introduces a new data structure used for receiving packets from > netdevs and passing them to dpifs. > The purpose of this change is to allow storing some private data for each > packet. The subsequent commits make use of it

Re: [ovs-dev] [branch-1.11] ofproto-dpif: Configure datapath max-idle through ovs-vsctl.

2014-06-23 Thread Ben Pfaff
OK. I understand now. Do you still need any reviews? On Mon, Jun 23, 2014 at 10:30 AM, Alex Wang wrote: > Hey Ben, > > Thanks for pointing it out, I actually do not have a clear judge on this. > I think it is necessary in this case, > > For branch-2.0, we are before the revalidator-as-a-thread e

Re: [ovs-dev] [branch-1.11] ofproto-dpif: Configure datapath max-idle through ovs-vsctl.

2014-06-23 Thread Alex Wang
Hey Ben, Thanks for pointing it out, I actually do not have a clear judge on this. I think it is necessary in this case, For branch-2.0, we are before the revalidator-as-a-thread era. So, it is pretty different from the implementation in commit 72310b04. For branch-1.11, 1.10, we need to confi

Re: [ovs-dev] [PATCH] revalidator: Selectively perform xlate side-effects.

2014-06-23 Thread Alex Wang
Hey Joe, Sorry for the delayed reply, Please see my comments inline, On Sun, Jun 22, 2014 at 11:29 PM, Joe Stringer wrote: > Alex, could you review this series? > > I think that the correct solution is to perform "retroactive > side-effects", that is, perform side effects as though they had ha

[ovs-dev] [PATCH] test-classifier: add ovs_assert to prevent warning

2014-06-23 Thread Daniele Di Proietto
GCC 4.9.0 triggers a warning (array-bounds) while compiling test-classifier.c This commit introduces an assertion that suppresses the warning. Signed-off-by: Daniele Di Proietto --- While I feel that this is a GCC problem, this simple (IMHO harmful) assertion fixes the issue. What do you guys thi

Re: [ovs-dev] [branch-1.11] ofproto-dpif: Configure datapath max-idle through ovs-vsctl.

2014-06-23 Thread Ben Pfaff
On Thu, Jun 19, 2014 at 09:20:57PM -0700, Alex Wang wrote: > This patch adds a new configuration option, "max-idle" to the > Bridge "other-config" column. This sets how long datapath flows, > for the configured bridge, are cached in the datapath before > ovs-vswitchd thread expires them. > > This

[ovs-dev] [PATCH] datapath/linux: add vport-geneve.c to .gitignore

2014-06-23 Thread Lorand Jakab
Signed-off-by: Lorand Jakab --- datapath/linux/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/datapath/linux/.gitignore b/datapath/linux/.gitignore index d10d028..be233fc 100644 --- a/datapath/linux/.gitignore +++ b/datapath/linux/.gitignore @@ -41,6 +41,7 @@ /utils.c /vlan.c /

Re: [ovs-dev] [PATCH 1/1] netflow: Modify netflow_flow_clear() to do netflow_expire__

2014-06-23 Thread Anoob Soman
Thanks. -Anoob On 09/06/14 19:10, Ben Pfaff wrote: Sorry about the delay. I took a few minutes to properly understand the situation this morning. I applied the following form of your patch to master and branch-2.[123]: --8<--cut here-->8-- From

[ovs-dev] LOAN

2014-06-23 Thread Lisa Dzyban
DO YOU NEED LOANS? AT 3% IF YES EMAIL WITH AMOUNT NEEDED. Note all reply should be copy and send to this email tracyharriso...@gmail.com tracyharriso...@gmail.com ___ dev mailing li

Re: [ovs-dev] [PATCH] revalidator: Selectively perform xlate side-effects.

2014-06-23 Thread Joe Stringer
On second thought, I noticed that this doesn't fix odd behaviour in the netflow expiration test. I sent out a patch to revert the original patch: http://openvswitch.org/pipermail/dev/2014-June/041868.html On 23 June 2014 18:29, Joe Stringer wrote: > Alex, could you review this series? > > I th

[ovs-dev] [PATCH] Revert "revalidator: Use xcache when revalidation is required."

2014-06-23 Thread Joe Stringer
This reverts commit a48c85b2d672505b89e488d28066538705b94942. The commit was causing intermittent testsuite failures and unexpected re-install of stale mac-learning entries. VMware-BZ: 1268574 Reported-by: Len Gao Signed-off-by: Joe Stringer --- I'd like to take another stab at getting the refe