On Mon, Jun 16, 2014 at 11:29:28AM +0900, Simon Horman wrote: > Use a list rather than an array to track monitor requests > in handle_flow_monitor_request(). > > This is in preparation for supporting OpenFlow1.4 flow monitor requests > with delete and modify commands. > > Signed-off-by: Simon Horman <ho...@verge.net.au>
I took a really cursory look at later patches and didn't immediately spot how the change from an array to a list helped. Can you explain? Instead of list_insert(), I would use list_push_back(). It has the same effect but the meaning is more obvious: > + list_insert(&monitor_list, &m->list_node); Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
