On Mon, Jun 23, 2014 at 3:55 PM, Simon Horman <ho...@verge.net.au> wrote: > On Mon, Jun 23, 2014 at 02:50:20PM -0700, Ben Pfaff wrote: >> On Mon, Jun 16, 2014 at 10:09:38AM +0900, Simon Horman wrote: >> > In some cases an pop MPLS action changes a packet to be a non-mpls packet. >> > In this case subsequent any L3+ actions require access to portions >> > of the packet which were not decoded as they were opaque when the >> > packet was MPLS. Allow such actions to be translated by >> > first recirculating the packet. >> > >> > Co-authored-by: Ben Pfaff <b...@nicira.com> >> > Signed-off-by: Ben Pfaff <b...@nicira.com> >> > Signed-off-by: Simon Horman <ho...@verge.net.au> >> >> I'm pretty happy with this. >> >> One final question: I think that compose_recirculate_action() needs to >> set ctx->exit unconditionally, not just in the failure cases. Do you agree? > > Yes I agree. > > Let me know if you would like me to re-spin.
Please. That would save me a minute or two. Thanks! _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev