Commit 03fbdf8d9c80a (lib/flow: Retain ODPP_NONE on flow_extract())
replaced packet metadata initialization function by a macro.
Visual studio does not like nested structure initialization that
is done in that macro.
This commit, reverts the above mentioned commit partially by
re-introducing the m
On Thu, Mar 20, 2014 at 5:57 PM, Gurucharan Shetty wrote:
> Commit 03fbdf8d9c80a (lib/flow: Retain ODPP_NONE on flow_extract())
> replaced packet metadata initialization function by a macro.
> Visual studio does not like nested structure initialization that
> is done in that macro.
>
> This commit
Commit 03fbdf8d9c80a (lib/flow: Retain ODPP_NONE on flow_extract())
replaced packet metadata initialization function by a macro.
Visual studio does not like nested structure initialization that
is done in that macro.
This commit, reverts the above mentioned commit partially by
re-introducing the m
On Thu, Mar 20, 2014 at 5:42 PM, Gurucharan Shetty wrote:
> Commit 03fbdf8d9c80a (lib/flow: Retain ODPP_NONE on flow_extract())
> replaced packet metadata initialization function by a macro.
> Visual studio does not like nested structure initialization that
> is done in that macro.
>
> This commit
Commit 03fbdf8d9c80a (lib/flow: Retain ODPP_NONE on flow_extract())
replaced packet metadata initialization function by a macro.
Visual studio does not like nested structure initialization that
is done in that macro.
This commit, reverts the above mentioned commit partially by
re-introducing the m
On Thu, Mar 20, 2014 at 05:31:02PM -0700, Gurucharan Shetty wrote:
> Commit 03fbdf8d9c80a (lib/flow: Retain ODPP_NONE on flow_extract())
> replaced packet metadata initialization function by a macro.
> Visual studio does not like nested structure initialization that
> is done in that macro.
>
> Th
Commit 03fbdf8d9c80a (lib/flow: Retain ODPP_NONE on flow_extract())
replaced packet metadata initialization function by a macro.
Visual studio does not like nested structure initialization that
is done in that macro.
This commit, reverts the above mentioned commit partially by
re-introducing the m
With the foundation laid in previous commits, this commit
removes the 'dispatcher' thread by allowing 'handler'
threads to read upcalls directly from dpif.
This commit significantly simplifies the flow miss handling
code and brings slight improvement to flow setup rate.
Note:
- the flow setup rat
Signed-off-by: Alex Wang
---
V5 -> V6:
- remove the 'struct dpif_epoll' and move its content in 'struct dpif_handler'.
- fix typos based on review.
- refine refresh_channels() comments.
- rename 'n_pids' of 'struct dpif_linux_vport' to 'n_upcall_pids'.
V4 -> V5:
- rebase.
V3 -> V4:
- add check
In order to allow handlers directly read upcalls from datapath,
we need to support per-handler netlink socket for each vport in
datapath. This commit makes this happen. Also, it is guaranteed
backward and forward compatibility with previous branch.
Signed-off-by: Alex Wang
Acked-by: Thomas Graf
On Thu, Mar 20, 2014 at 03:39:05PM -0700, Alex Wang wrote:
> Thanks for the review, Ben
>
>
> I am confused by upcall_destroy()'s free_upcall parameter: all of the
> > callers pass 'false'.
>
>
>
> I think I'll remove the input argument 'free_upcall' in upall_destroy(),
> since
> the array of
Thanks for the review, Ben
I am confused by upcall_destroy()'s free_upcall parameter: all of the
> callers pass 'false'.
I think I'll remove the input argument 'free_upcall' in upall_destroy(),
since
the array of upcalls is defined as local variable in udpif_upcall_handler().
>
>
It might n
On 03/20/2014 05:02 PM, Zoltan Kiss wrote:
--- a/net/openvswitch/datapath.c
+++ b/net/openvswitch/datapath.c
@@ -464,7 +464,9 @@ static int queue_userspace_packet(struct datapath *dp,
struct sk_buff *skb,
}
nla->nla_len = nla_attr_size(skb->len);
- skb_zerocopy(user_skb, s
Going through patchwork, I got very confused about whether several
MPLS patches from mid-February were still current and ended up
marking them "Deferred". Would you mind doing a repost of all the
current MPLS patches? I'd really like to get all of them put to bed
someday soon.
--
"I don't norma
Thanks for the review Ben,
> This is a lot of code, but it looks well crafted. I only have a few
> comments.
>
> dpif-linux.c
>
>
> The comment on dpif_linux_refresh_channels() mentions dpif->channels,
> which no longer exists
>
Fixed,
> It looks like there are always 'n_handl
On Thu, Mar 13, 2014 at 03:52:56PM +0900, Simon Horman wrote:
> OpenFlow 1.1 and 1.2 specify that if a table-miss occurs then the default
> behaviour is to forward the packet the controller using a packet-in
> message. And until this patch this is the default behaviour that Open
> vSwitch uses for
On Thu, Mar 13, 2014 at 03:52:55PM +0900, Simon Horman wrote:
> Replace the generated_by_table_miss field of struct ofproto_packet_in
> with a miss_type field.
>
> The generated_by_table_miss field allowed packet-in messages generated
> by table-miss rules to be differentiated. This differentiatio
On Thu, Mar 13, 2014 at 03:52:54PM +0900, Simon Horman wrote:
> Cc: YAMAMOTO Takashi
> Signed-off-by: Simon Horman
Thanks, I'll apply this in a minute.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
From: Zoltan Kiss
Date: Thu, 20 Mar 2014 16:02:34 +
> skb_zerocopy can copy elements of the frags array between skbs, but it doesn't
> orphan them. Also, it doesn't handle errors, so this patch takes care of that
> as well, and modify the callers accordingly. skb_tx_error() is also added to
>
From: Jesse Gross
Date: Thu, 20 Mar 2014 11:09:10 -0700
> Four small fixes for net/3.14. I realize that these are late in the cycle -
> just got back from vacation.
>
> The following changes since commit c14e0953ca51dbcb8d1ac92acbdcff23d0caa158:
>
> openvswitch: Suppress error messages on me
I finally applied this (I had forgotten about it until I found it in
patchwork just now).
On Fri, Jan 17, 2014 at 06:01:54PM -0800, Alex Wang wrote:
> Looks good to me,
>
>
> On Tue, Dec 31, 2013 at 11:39 AM, Ben Pfaff wrote:
>
> > Anytime there is a VLAN the flow needs to properly reflect tha
On Wed, Mar 12, 2014 at 03:21:34PM +0900, Simon Horman wrote:
> This reworks lookup of rules for both table 0 and table action translation.
> The result is that Table Mod settings, which can alter the miss-behaviour
> of tables, including table 0, on a per-table basis may be honoured.
>
> Previous
From: Jiri Pirko
This fixes crash when userspace does "ovs-dpctl add-dp dev" where dev is
existing non-dp netdevice.
Introduced by:
commit 44da5ae5fbea4686f667dc854e5ea16814e44c59
"openvswitch: Drop user features if old user space attempted to create datapath"
Signed-off-by: Jiri Pirko
Signed-
From: Jarno Rajahalme
ovs_vport_cmd_dump() did rcu_read_lock() only after getting the
datapath, which could have been deleted in between. Resolved by
taking rcu_read_lock() before the get_dp() call.
Signed-off-by: Jarno Rajahalme
Signed-off-by: Pravin B Shelar
---
net/openvswitch/datapath.c
From: Jarno Rajahalme
Only the first IP fragment can have a TCP header, check for this.
Signed-off-by: Jarno Rajahalme
Signed-off-by: Jesse Gross
---
net/openvswitch/flow.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/openvswitch/flow.c b/net/openvswitch/flow.c
index 16f4b46..d71e6
Four small fixes for net/3.14. I realize that these are late in the cycle -
just got back from vacation.
The following changes since commit c14e0953ca51dbcb8d1ac92acbdcff23d0caa158:
openvswitch: Suppress error messages on megaflow updates (2014-02-04 22:32:38
-0800)
are available in the git
From: Ben Pfaff
The kernel starts out its "jiffies" timer as 5 minutes below zero, as
shown in include/linux/jiffies.h:
/*
* Have the 32 bit jiffies value wrap 5 minutes after boot
* so jiffies wrap bugs show up earlier.
*/
#define INITIAL_JIFFIES ((unsigned long)(unsigned int) (-30
On Thu, Mar 20, 2014 at 9:55 AM, Ben Pfaff wrote:
> On Wed, Mar 19, 2014 at 06:31:10PM -0700, Jesse Gross wrote:
>> On Fri, Feb 28, 2014 at 1:14 PM, Ben Pfaff wrote:
>> > diff --git a/datapath/flow.c b/datapath/flow.c
>> > index c3e3fcb..e9a2a27 100644
>> > --- a/datapath/flow.c
>> > +++ b/datapa
Jesse could you review this patch when you are available? Thx
Hope it is close,
On Wed, Mar 19, 2014 at 4:33 PM, Ben Pfaff wrote:
> On Wed, Mar 19, 2014 at 04:33:17PM -0700, Ben Pfaff wrote:
> > On Wed, Mar 19, 2014 at 01:35:05PM -0700, Alex Wang wrote:
> > > In order to allow handlers directly
Applied and backported, thx
On Thu, Mar 20, 2014 at 10:09 AM, Ben Pfaff wrote:
> On Wed, Mar 19, 2014 at 05:44:35PM -0700, Alex Wang wrote:
> > CFM fault variable type has been changed to 'enum cfm_fault_reason' for
> > long time. However, inside cfm_run(), the old_cfm_fault is still defined
>
Applied to master, thx
On Thu, Mar 20, 2014 at 10:10 AM, Ben Pfaff wrote:
> On Wed, Mar 19, 2014 at 05:44:36PM -0700, Alex Wang wrote:
> > Since daemons can use the cfm status from OVSDB, it is useful
> > to add a test to guarantee that the update is in time.
> >
> > Signed-off-by: Alex Wang
>
After discussion with Pravin, he thinks I can push my changes first.
So, applied the first to patches to master, thx,
On Wed, Mar 19, 2014 at 4:44 PM, Alex Wang wrote:
> Thx Ben,
>
> I'll hold off the push and discuss with Pravin tmr,
>
>
> On Wed, Mar 19, 2014 at 4:32 PM, Ben Pfaff wrote:
>
On Wed, Mar 19, 2014 at 05:44:36PM -0700, Alex Wang wrote:
> Since daemons can use the cfm status from OVSDB, it is useful
> to add a test to guarantee that the update is in time.
>
> Signed-off-by: Alex Wang
Acked-by: Ben Pfaff
___
dev mailing list
d
On Wed, Mar 19, 2014 at 05:44:35PM -0700, Alex Wang wrote:
> CFM fault variable type has been changed to 'enum cfm_fault_reason' for
> long time. However, inside cfm_run(), the old_cfm_fault is still defined
> as boolean. This commit fixes the issue.
>
> Found by inspection.
>
> Signed-off-by:
I am going to try to come up with a patch for 802.1ad/ah.
--Tom
> On Mar 20, 2014, at 12:19 PM, Ben Pfaff wrote:
>
>> On Thu, Mar 20, 2014 at 12:20:17PM +0530, Deba Prasad Das wrote:
>> This is regarding the VLAN QinQ (802.1AD ) support in OpenvSwitch .
>> We are planning to work on VLAN QinQ
On Fri, Mar 14, 2014 at 04:19:52PM +0900, Simon Horman wrote:
> When creating a flow in the datapath as the result of an upcall
> the match itself is the match supplied in the upcall while
> the mask of the match, if supplied, is generated based on the
> flow and mask composed during action transla
On Wed, Mar 19, 2014 at 06:31:10PM -0700, Jesse Gross wrote:
> On Fri, Feb 28, 2014 at 1:14 PM, Ben Pfaff wrote:
> > diff --git a/datapath/flow.c b/datapath/flow.c
> > index c3e3fcb..e9a2a27 100644
> > --- a/datapath/flow.c
> > +++ b/datapath/flow.c
> > @@ -1,5 +1,5 @@
> > /*
> > - * Copyright (c
On Wed, Mar 19, 2014 at 7:06 PM, Jesse Gross wrote:
> On Mon, Mar 10, 2014 at 12:32 PM, Pravin Shelar wrote:
>> On Thu, Mar 6, 2014 at 1:57 PM, Kyle Mestery
>> wrote:
>>> On Thu, Feb 27, 2014 at 3:28 PM, Pravin Shelar wrote:
On Thu, Feb 27, 2014 at 12:41 PM, Kyle Mestery
wrote:
On Thu, Mar 20, 2014 at 05:34:23PM +0900, Simon Horman wrote:
> When revalidating a flow convert xout.wc.masks, the mask calculated by
> translation, to a key that relates to the flow present in the datapath. Only
> mask elements that relate to the flow will be included in the resulting key.
> Thi
On Thu, Mar 20, 2014 at 03:00:14PM +0900, YAMAMOTO Takashi wrote:
> Fix a regression introduced by commit fce314cd.
> ("socket-util: Fix definition of LINUX.")
>
> Signed-off-by: YAMAMOTO Takashi
Oops. Thanks, applied.
___
dev mailing list
dev@openvsw
On Thu, Mar 20, 2014 at 12:20:17PM +0530, Deba Prasad Das wrote:
> This is regarding the VLAN QinQ (802.1AD ) support in OpenvSwitch .
> We are planning to work on VLAN QinQ support in Openvswitch.
> Please let us know whether if some people are already working on this feature.
I don't know of any
skb_zerocopy can copy elements of the frags array between skbs, but it doesn't
orphan them. Also, it doesn't handle errors, so this patch takes care of that
as well, and modify the callers accordingly. skb_tx_error() is also added to
the callers so they will signal the failed delivery towards the c
On 20/03/14 12:33, Thomas Graf wrote:
On 03/20/2014 01:16 PM, Thomas Graf wrote:
On 03/19/2014 10:07 PM, Zoltan Kiss wrote:
skb_zerocopy can copy elements of the frags array between skbs, but it
doesn't
orphan them. Also, it doesn't handle errors, so this patch takes care
of that
as well.
Sign
On 03/19/2014 10:07 PM, Zoltan Kiss wrote:
skb_zerocopy can copy elements of the frags array between skbs, but it doesn't
orphan them. Also, it doesn't handle errors, so this patch takes care of that
as well.
Signed-off-by: Zoltan Kiss
Acked-by: Thomas Graf
---
+ if (unlikely(skb_orp
On 03/20/2014 01:16 PM, Thomas Graf wrote:
On 03/19/2014 10:07 PM, Zoltan Kiss wrote:
skb_zerocopy can copy elements of the frags array between skbs, but it
doesn't
orphan them. Also, it doesn't handle errors, so this patch takes care
of that
as well.
Signed-off-by: Zoltan Kiss
Acked-by: Tho
Hi Jesse,
I hope you had a great vacation.
Now that you're back, please take a look at suggested fixes before I
formally submit v3 of the L3 patch for review.
On 1/6/14, 7:55 PM, Jesse Gross wrote:
On Tue, Dec 24, 2013 at 9:02 AM, Lorand Jakab wrote:
Implementation of the pop_eth and push_
When revalidating a flow convert xout.wc.masks, the mask calculated by
translation, to a key that relates to the flow present in the datapath. Only
mask elements that relate to the flow will be included in the resulting key.
This has the effect of filtering the mask based on 'flow'.
In particular
On Tue, Mar 11, 2014 at 04:56:20PM -0700, Andy Zhou wrote:
> Add basic recirculation infrastructure and user space
> data path support for it. The following bond mega flow patch will
> make use of this infrastructure.
>
> Signed-off-by: Andy Zhou
>
> ---
> v1->v2: Rewritten based on having post
48 matches
Mail list logo
