On Thu, Mar 20, 2014 at 05:31:02PM -0700, Gurucharan Shetty wrote: > Commit 03fbdf8d9c80a (lib/flow: Retain ODPP_NONE on flow_extract()) > replaced packet metadata initialization function by a macro. > Visual studio does not like nested structure initialization that > is done in that macro. > > This commit, reverts the above mentioned commit partially by > re-introducing the metadata initialization function. > > CC: Jarno Rajahalme <jrajaha...@nicira.com> > Signed-off-by: Gurucharan Shetty <gshe...@nicira.com>
... This use of ?: really bugs me (I know it was there before) so would you mind switching it to an "if" statement? > + tnl ? memcpy(&md->tunnel, tnl, sizeof(md->tunnel)) > + : memset(&md->tunnel, 0, sizeof(md->tunnel)); I didn't look at the rest of the patch, I hope someone will beat me to it. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
