On Thu, Mar 20, 2014 at 03:39:05PM -0700, Alex Wang wrote: > Thanks for the review, Ben > > > I am confused by upcall_destroy()'s free_upcall parameter: all of the > > callers pass 'false'. > > > > I think I'll remove the input argument 'free_upcall' in upall_destroy(), > since > the array of upcalls is defined as local variable in udpif_upcall_handler(). > > > > > > > > It might not be worth it to destroy the upcalls one by one as one > > decides that they're no longer needed. I believe that > > udpif_upcall_handler() could just destroy all of them, if > > handle_upcalls() didn't destroy any. > > > > > > I like the idea of destroying all upcalls together. I still want to do it > in the end of > handle_upalls(). Basically, I will mark ''is_valid = false" for invalid or > erroneous. > And in the end of handle_upalls() destroys all upcalls. > > > I like the simplification.
OK, thanks, that sounds fine. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
