On 03/19/2014 10:07 PM, Zoltan Kiss wrote:
skb_zerocopy can copy elements of the frags array between skbs, but it doesn't
orphan them. Also, it doesn't handle errors, so this patch takes care of that
as well.

Signed-off-by: Zoltan Kiss <[email protected]>

Acked-by: Thomas Graf <[email protected]>

---
+       if (unlikely(skb_orphan_frags(to, GFP_ATOMIC))) {
+               skb_tx_error(to);
+               return -ENOMEM;
+       }

Did you consider calling skb_tx_error() for Netlink message
allocation failures for the upcall as well? That memory pressure
is currently not reported back.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to