Hi Ben,
Thanks a lot for response.
data flow means Ethernet net packet traversing, so my doubt is:
1) After the packet receiving from Ethernet driver packet will traverse in
kernel space or in user space.
2) This rule is applicable for all packet or first packet
Thanks,
Vivek
-Origin
Allow datapath to recognize and extract MPLS labels into flow keys
and execute actions which push, pop, and set labels on packets.
Based heavily on work by Leo Alterman, Ravi K, Isaku Yamahata and Joe Stringer.
Cc: Ravi K
Cc: Leo Alterman
Cc: Isaku Yamahata
Cc: Joe Stringer
Signed-off-by: Sim
Hi,
This series implements MPLS actions and matches based on work by
Ravi K, Leo Alterman, Yamahata-san and Joe Stringer.
This series provides three changes
* Patches 1 - 3
Provide user-space support for the VLAN/MPLS tag insertion order
up to and including OpenFlow 1.2, and the different o
From: Joe Stringer
OpenFlow 1.1 and 1.2, and 1.3 differ in their handling of MPLS actions in the
presence of VLAN tags. To allow correct behaviour to be committed in
each situation, this patch adds a second round of VLAN tag action
handling to commit_odp_actions(), which occurs after MPLS actions
This patch modifies the push_mpls behaviour to allow
pushing of an MPLS LSE either before any VLAN tag that may be present.
Pushing the MPLS LSE before any VLAN tag that is present is the
behaviour specified in OpenFlow 1.3.
Pushing the MPLS LSE after the any VLAN tag that is present is the
behav
Break out deacceleration portion of vlan_push into vlan_put
so that it may be re-used by mpls_push.
For both vlan_push and mpls_push if there is an accelerated VLAN tag
present then it should be deaccelerated, adding it to the data of
the skb, before the new tag is added.
Signed-off-by: Simon Hor
The aim of this patch is to support provide infrastructure for verification
of VLAN actions after an mpls_push action for OpenFlow1.3. This supplements
existing support for verifying these actions for pre-OpenFlow1.3.
In OpenFlow1.1 and 1.2 MPLS tags are pushed after any VLAN tags that
immediately
On Wed, Nov 20, 2013 at 09:28:47AM -0800, Ben Pfaff wrote:
> On Mon, Nov 18, 2013 at 03:48:29PM +0900, Simon Horman wrote:
> > On Fri, Nov 15, 2013 at 02:33:14PM -0800, Ben Pfaff wrote:
> > > Until now ofpacts_check() has been told either to enforce consistency or
> > > not, but that means that the
On Wed, Nov 20, 2013 at 04:59:19PM -0800, Ben Pfaff wrote:
> On Wed, Nov 13, 2013 at 01:25:22PM +0900, Simon Horman wrote:
> > Add table config to to struct ofproto and set it
> > when a table mod message is received.
> >
> > This is in preparation for changing the behaviour of the switch
> > base
Include stdlib.h in include/sparse/sys/socket.h to ensure
that NULL is defined and thus avoid the following sparse warning.
./include/sparse/sys/socket.h:74:15: error: undefined identifier 'NULL'
Signed-off-by: Simon Horman
---
include/sparse/sys/socket.h | 2 ++
1 file changed, 2 insertions(+)
On Wed, Nov 13, 2013 at 01:25:22PM +0900, Simon Horman wrote:
> Add table config to to struct ofproto and set it
> when a table mod message is received.
>
> This is in preparation for changing the behaviour of the switch
> based on table config.
>
> Cc: Andy Zhou
> Signed-off-by: Simon Horman
On Nov 20, 2013, at 4:37 PM, Ben Pfaff wrote:
> On Wed, Nov 20, 2013 at 10:57:52AM -0800, Romain Lenglet wrote:
>> Guard any access to an IPFIX row referenced from
>> Flow_Sample_Collector_Set by a test that the reference is not NULL.
>>
>> Signed-off-by: Romain Lenglet
>
> I removed the "inli
Putting "static inline" on a function definition in a .c file does not help
the compiler and does suppress warnings for unused functions that one would
want, should the function ever become unused.
Signed-off-by: Ben Pfaff
---
vswitchd/bridge.c |2 +-
1 file changed, 1 insertion(+), 1 deleti
On 11/21/2013 01:40 AM, Jesse Gross wrote:
On Wed, Nov 20, 2013 at 1:43 AM, Thomas Graf wrote:
On 11/20/2013 10:14 AM, Jesse Gross wrote:
On Wed, Nov 20, 2013 at 1:08 AM, Thomas Graf wrote:
I might be missing something but what about the rxhash == 0 case?
VXLAN does:
hash = skb_ge
On Wed, Nov 20, 2013 at 1:43 AM, Thomas Graf wrote:
> On 11/20/2013 10:14 AM, Jesse Gross wrote:
>> On Wed, Nov 20, 2013 at 1:08 AM, Thomas Graf wrote:
>>> I might be missing something but what about the rxhash == 0 case?
>>>
>>> VXLAN does:
>>> hash = skb_get_rxhash(skb);
>>> i
On Wed, Nov 20, 2013 at 10:57:53AM -0800, Romain Lenglet wrote:
> The "targets" column in IPFIX had a min=1 constraints, so OVSDB
> implicitly adds an empty string "" into that column if no value is
> given. No connection can be opened to a target with address "", so
> the whole IPFIX exporter for
On Wed, Nov 20, 2013 at 10:57:52AM -0800, Romain Lenglet wrote:
> Guard any access to an IPFIX row referenced from
> Flow_Sample_Collector_Set by a test that the reference is not NULL.
>
> Signed-off-by: Romain Lenglet
I removed the "inline" keyword from the new function. It doesn't help
the co
On Wed, Nov 20, 2013 at 11:38:29AM -0800, Alex Wang wrote:
> This commit adds a new key "flap_count" to "bfd_status" to count
> the number of bfd "forwarding" flag flaps. A flap is considered
> as a change of the "forwarding" flag value.
>
> Signed-off-by: Alex Wang
I applied these patches to m
On Wed, Nov 20, 2013 at 01:52:59PM -0800, Gurucharan Shetty wrote:
> Open vSwitch bridges and ports can be configured through
> the /etc/network/interfaces script. During system startup,
> Open vSwitch startup script reads the interfaces file
> and creates the bridges and ports. During system shutd
On Wed, Nov 20, 2013 at 01:17:11PM -0800, Bill Sommerfeld wrote:
> Unlike all the other releases I checked, I don't see a published tag
> in the git repo for openvswitch 2.0.0.
>
> I'm guessing this is a minor oversight and not intentional ...
Yeah, I'm waiting for Justin to tell me which commit
On Fri, Nov 15, 2013 at 03:25:00PM -0800, Joe Stringer wrote:
> When profiling CPU usage in situations involving high numbers of ports,
> coverage_clear() was highlighted as a commonly called function. It
> appears that it can be quite expensive to access all of the per-thread
> coverage counters w
On Thu, Nov 14, 2013 at 03:28:29PM -0800, Joe Stringer wrote:
> This patch adds a new field to "struct ofproto" to track which protocols
> are active on that bridge. This is updated whenever bfd, cfm, lacp or
> stp is enabled. In instant_stats_run(), we query this to determine
> whether it is worth
On Mon, Nov 18, 2013 at 03:27:18PM -0800, Joe Stringer wrote:
> On 14 November 2013 15:28, Joe Stringer wrote:
> > @@ -2529,6 +2538,7 @@ bridge_wait(void)
> >
> > HMAP_FOR_EACH (br, node, &all_bridges) {
> > ofproto_wait(br->ofproto);
> > +netdev_seq_wait(br->chan
On Thu, Nov 14, 2013 at 03:28:28PM -0800, Joe Stringer wrote:
> Previously, we iterated through all interfaces in instant_stats_run(),
> grabbing up-to-date information about device status. After assembling
> all of this information for all interfaces, we would determine whether
> anything changed
On Wed, Nov 20, 2013 at 01:50:42PM -0800, Joe Stringer wrote:
> On 20 November 2013 11:15, Ben Pfaff wrote:
> > I think that it is a little surprising to use a netdev sequence number
> > to track changes to things that are not network devices. If we are
> > going to do that, then I think we need
Hmm, right you are. I'll try to be more careful in future.
On 20 November 2013 11:23, Ben Pfaff wrote:
> On Thu, Nov 14, 2013 at 03:28:27PM -0800, Joe Stringer wrote:
>> When dealing with a large number of ports, bundle_run() and
>> bundle_wait() add significant unnecessary processing to the mai
Open vSwitch bridges and ports can be configured through
the /etc/network/interfaces script. During system startup,
Open vSwitch startup script reads the interfaces file
and creates the bridges and ports. During system shutdown,
the bridges and ports are removed.
The same behavior also can occur w
On 20 November 2013 11:15, Ben Pfaff wrote:
> I think that this introduces a strict but easy to miss dependency on the
> order in which ofproto_run() calls the provider's 'run' function and
> that it updates the ofproto's change_seq: it works with the current
> order but if the order were reversed
ESCUELA CHINA ARGENTINA
www.escuelachina.com.ar
i...@escuelachina.com.ar
¿Ya pensaste en estudiar chino mandarin?
El idioma chino es el mayor cercimiento en nuestro mundo actual.
Ya habla chino más del 25% de la población mundial.
Aprovechá los descuentos y promociones que
Unlike all the other releases I checked, I don't see a published tag
in the git repo for openvswitch 2.0.0.
I'm guessing this is a minor oversight and not intentional ...
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/de
On Wed, Nov 20, 2013 at 1:43 AM, Thomas Graf wrote:
> On 11/20/2013 10:14 AM, Jesse Gross wrote:
>>
>> On Wed, Nov 20, 2013 at 1:08 AM, Thomas Graf wrote:
>>>
>>> On 11/19/2013 10:50 PM, Pravin B Shelar wrote:
Rather than using complete flow hash, we can use skb->rxhash for
ca
This commit adds a new key "flap_count" to "bfd_status" to count
the number of bfd "forwarding" flag flaps. A flap is considered
as a change of the "forwarding" flag value.
Signed-off-by: Alex Wang
---
v1 -> v2:
- define what is a flap.
---
lib/bfd.c| 11 -
tests/bfd.at
On 20 November 2013 10:59, Ben Pfaff wrote:
> I think we could delete netdev_dummy_changed() and
> netdev_vport_changed() entirely and just call netdev_notify() from the
> caller.
OK, sure. I can change the bsd version as well.
> I think that every netdev construct function now calls netdev_noti
On Thu, Nov 14, 2013 at 03:28:27PM -0800, Joe Stringer wrote:
> When dealing with a large number of ports, bundle_run() and
> bundle_wait() add significant unnecessary processing to the main run
> loop, even when there are no bonds and lacp is not configured. This
> patch skips such execution if it
>
> The only suggestion I have here is to make it clear in the documentation
> what a "flap" is. I guess that we are defining it as any change in
> status. That's fine, I think, but off-hand I might have guessed that a
> flap was a full transition from up to down and then back to up.
>
Yes, I s
On Thu, Nov 14, 2013 at 03:28:26PM -0800, Joe Stringer wrote:
> Currently, as part of ofproto-dpif run() processing, we loop through all
> ports and poll corresponding devices for changes in carrier, cfm and bfd
> status. This allows us to determine how it may affect bundles. For the
> average case
This commit adds a forwarding flag to "struct bfd". This flag
is for indicating the interface's capability of packet I/O.
Also, this flag makes it possible to count the number of interface
state flapping. bfd_forwarding__() will update this flag at
each invocation.
Signed-off-by: Alex Wang
---
On Thu, Nov 14, 2013 at 03:28:25PM -0800, Joe Stringer wrote:
> Previously, we tracked status changes for ofports on a per-device basis.
> Each time in the main thread's loop, we would loop through all ofports
> and manually check whether the status has changed for corresponding
> devices.
>
> Thi
Guard any access to an IPFIX row referenced from
Flow_Sample_Collector_Set by a test that the reference is not NULL.
Signed-off-by: Romain Lenglet
---
vswitchd/bridge.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index
The "targets" column in IPFIX had a min=1 constraints, so OVSDB
implicitly adds an empty string "" into that column if no value is
given. No connection can be opened to a target with address "", so
the whole IPFIX exporter for that row was disabled until that ""
target was removed by users. That
Thanks both of you for the comments,
I'll adjust accordingly,
On Wed, Nov 20, 2013 at 10:19 AM, Joe Stringer wrote:
> On 15 November 2013 13:58, Alex Wang wrote:
> > static uint64_t
> > @@ -1081,6 +1088,8 @@ bfd_check_rx(struct bfd *bfd) OVS_REQUIRES(mutex)
> > }
> > if (bfd->forwar
On Fri, Nov 15, 2013 at 01:58:25PM -0800, Alex Wang wrote:
> This commit adds a new key "flap_count" to "bfd_status" to count
> the number of bfd "forwarding" flag flaps.
>
> Signed-off-by: Alex Wang
The only suggestion I have here is to make it clear in the documentation
what a "flap" is. I gu
On 15 November 2013 13:58, Alex Wang wrote:
> static uint64_t
> @@ -1081,6 +1088,8 @@ bfd_check_rx(struct bfd *bfd) OVS_REQUIRES(mutex)
> }
> if (bfd->forwarding_if_rx && diff > 0) {
> bfd_forwarding_if_rx_update(bfd);
> +/* Updates the forwarding flag. */
> +bf
On Wed, Nov 20, 2013 at 10:12:43AM -0800, Gurucharan Shetty wrote:
> On Wed, Nov 20, 2013 at 9:42 AM, Ben Pfaff wrote:
> > Fixes a build failure:
> > The distribution is missing the following files:
> > BUILD.Windows
> >
> > CC: Gurucharan Shetty
> > Signed-off-by: Ben Pfaff
>
> Oops. L
On Wed, Nov 20, 2013 at 9:42 AM, Ben Pfaff wrote:
> Fixes a build failure:
> The distribution is missing the following files:
> BUILD.Windows
>
> CC: Gurucharan Shetty
> Signed-off-by: Ben Pfaff
Oops. Looks good to me.
> ---
> Makefile.am |1 +
> 1 file changed, 1 insertion(+)
>
>
On Wed, Nov 20, 2013 at 05:19:25PM +0900, Simon Horman wrote:
> On Mon, Nov 18, 2013 at 03:48:29PM +0900, Simon Horman wrote:
> > On Fri, Nov 15, 2013 at 02:33:14PM -0800, Ben Pfaff wrote:
> > > Until now ofpacts_check() has been told either to enforce consistency or
> > > not, but that means that
On Fri, Nov 15, 2013 at 01:58:24PM -0800, Alex Wang wrote:
> This commit adds a forwarding flag to "struct bfd". And
> bfd_forwarding__() will update this flag at each invocation.
>
> Signed-off-by: Alex Wang
This seems reasonable but I'd think that the commit message should
explain why adding
Tested-by: Nithin Nayak Sujir
On 11/20/2013 09:50 AM, Pravin B Shelar wrote:
On 3.11 kernel, gre module exports IP_GRE demux API, ovs needs
to use it to register for GRE protocol handler.
Reported-by: Nithin Nayak Sujir
Signed-off-by: Pravin B Shelar
---
datapath/linux/compat/gre.c
Thanks for pointing out the commit message is wrong.
I don't think that this patch has a real effect on behavior, so I'm
dropping it. Let me know if you disagree, and I'll pick it back up (or
you can) and fix the commit message.
On Fri, Nov 15, 2013 at 03:50:06PM -0800, Jarno Rajahalme wrote:
>
On Mon, Nov 18, 2013 at 03:51:15PM +0900, Simon Horman wrote:
> [ Cc Jarno Rajahalme ]
>
> On Fri, Nov 15, 2013 at 02:33:15PM -0800, Ben Pfaff wrote:
> > Currently Open vSwitch does not implement OpenFlow1.3+ tag ordering
> > so it makes sense to enforce consistency checking in the way that OVS do
On Tue, Nov 19, 2013 at 8:56 PM, Jesse Gross wrote:
> On Tue, Nov 19, 2013 at 6:49 PM, Nithin Nayak Sujir
> wrote:
>>
I see these errors which don't appear with the inbox openvswitch driver.
[ 4198.153985] gre_compat_init: cannot register gre_cisco protocol
handler
>>>
>>>
>>
On 3.11 kernel, gre module exports IP_GRE demux API, ovs needs
to use it to register for GRE protocol handler.
Reported-by: Nithin Nayak Sujir
Signed-off-by: Pravin B Shelar
---
datapath/linux/compat/gre.c |8 ++--
datapath/linux/compat/include/net/gre.h |4
2 file
Thanks, both applied!
On Wed, Nov 20, 2013 at 09:39:35AM -0800, Justin Pettit wrote:
> Acked-by: Justin Pettit
>
> --Justin
>
>
> On Nov 20, 2013, at 9:08 AM, Ben Pfaff wrote:
>
> > Signed-off-by: Ben Pfaff
> > ---
> > FAQ | 16 ++--
> > 1 file changed, 14 insertions(+), 2 dele
Fixes a build failure:
The distribution is missing the following files:
BUILD.Windows
CC: Gurucharan Shetty
Signed-off-by: Ben Pfaff
---
Makefile.am |1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile.am b/Makefile.am
index 3d2165f..08ccb8d 100644
--- a/Makefile.am
+++ b/Mak
Acked-by: Justin Pettit
--Justin
On Nov 20, 2013, at 9:08 AM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> FAQ | 16 ++--
> 1 file changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/FAQ b/FAQ
> index ffe63cc..2912ae3 100644
> --- a/FAQ
> +++ b/FAQ
> @@ -418,7 +41
Acked-by: Justin Pettit
--Justin
On Nov 20, 2013, at 9:08 AM, Ben Pfaff wrote:
> They have not been exact-match only for a while.
>
> Signed-off-by: Ben Pfaff
> ---
> FAQ | 23 ---
> 1 file changed, 12 insertions(+), 11 deletions(-)
>
> diff --git a/FAQ b/FAQ
> index 4
Thanks Jarno and Simon, I'll apply this soon.
On Fri, Nov 15, 2013 at 03:21:36PM -0800, Jarno Rajahalme wrote:
> I like this, especially the fact that you got rid of the duplicate calls to
> of pacts_check()
>
> Acked-by: Jarno Rajahalme
>
> On Nov 15, 2013, at 2:33 PM, Ben Pfaff wrote:
>
>
On Mon, Nov 18, 2013 at 03:48:29PM +0900, Simon Horman wrote:
> On Fri, Nov 15, 2013 at 02:33:14PM -0800, Ben Pfaff wrote:
> > Until now ofpacts_check() has been told either to enforce consistency or
> > not, but that means that the caller has to know exactly what protocol is
> > going to be in use
OK, I look forward to patches.
On Wed, Nov 20, 2013 at 07:07:23AM +, Alessandro Pilotti wrote:
> +1
>
>
> > On 20.11.2013, at 00:17, "Ethan Jackson" wrote:
> >
> > Ben's the authority on this, but FWIW a macro sounds fine to me.
> > We've already got PRI_U32 etc, adding a PRI_ZU seems reas
On Wed, Nov 20, 2013 at 10:40:31AM +, Vivek Kumar (EPG) wrote:
> 1) could you please confirm in OpenVswitch data flow to be @ kernel level or
> user level.
What's a data flow?
> 2) As some document says that When the first packet of a flow comes to
> the datapath, the datapath transmit it to
They have not been exact-match only for a while.
Signed-off-by: Ben Pfaff
---
FAQ | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/FAQ b/FAQ
index 4a8a5be..ffe63cc 100644
--- a/FAQ
+++ b/FAQ
@@ -434,16 +434,17 @@ A: Open vSwitch uses different kinds
Signed-off-by: Ben Pfaff
---
FAQ | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/FAQ b/FAQ
index ffe63cc..2912ae3 100644
--- a/FAQ
+++ b/FAQ
@@ -418,7 +418,11 @@ A: First, why do you want to do this? Two connected
bridges are not
ports will not work w
Cette newsletter vous a été envoyée au format graphique HTML.
Si vous lisez cette version, alors votre logiciel de messagerie préfère les
e-mails au format texte.
Vous pouvez lire la version originale en ligne:
http:/
Hi Ben and All,
I have couple of quires regarding OpenVswitch:
1) could you please confirm in OpenVswitch data flow to be @ kernel level or
user level.
2) As some document says that When the first packet of a flow comes to the
datapath, the datapath transmit it to the userspace using netlink.
Ok,
thank for this information,
i'm going to verify my configuration.
Regards,
Nicolas
2013/11/20 Jesse Gross :
> All of these stack traces seem completely different to me (and some
> don't even involve OVS) so it's pretty difficult to tell what's going
> on. However, if I had to guess, I suspect
On 11/20/2013 10:14 AM, Jesse Gross wrote:
On Wed, Nov 20, 2013 at 1:08 AM, Thomas Graf wrote:
On 11/19/2013 10:50 PM, Pravin B Shelar wrote:
Rather than using complete flow hash, we can use skb->rxhash for
calculating source port. Similar calculation is done by vxlan.
Signed-off-by: Pravin
On Wed, Nov 20, 2013 at 1:08 AM, Thomas Graf wrote:
> On 11/19/2013 10:50 PM, Pravin B Shelar wrote:
>>
>> Rather than using complete flow hash, we can use skb->rxhash for
>> calculating source port. Similar calculation is done by vxlan.
>>
>> Signed-off-by: Pravin B Shelar
>> ---
>> datapath/v
On 11/19/2013 10:50 PM, Pravin B Shelar wrote:
Following patch improves rxhash calculation, It is taken from
upstream Linux kernel code.
From kernel 3.8, skb_get_rxhash() can handle hardware generated
l4-rxhash. Therefore compat skb_get_rxhash() is not used on
kernel 3.8 or new.
Signed-off-by:
On 11/19/2013 10:50 PM, Pravin B Shelar wrote:
Rather than using complete flow hash, we can use skb->rxhash for
calculating source port. Similar calculation is done by vxlan.
Signed-off-by: Pravin B Shelar
---
datapath/vport-lisp.c |9 +++--
1 files changed, 3 insertions(+), 6 deleti
On 11/19/2013 10:50 PM, Pravin B Shelar wrote:
Some distribution kernel has backported skb->rxhash (e.g. RHEL)
Following patch allows use precalculated rxhash.
Signed-off-by: Pravin B Shelar
Reviewed-by: Thomas Graf
___
dev mailing list
dev@openvs
On Mon, Nov 18, 2013 at 03:48:29PM +0900, Simon Horman wrote:
> On Fri, Nov 15, 2013 at 02:33:14PM -0800, Ben Pfaff wrote:
> > Until now ofpacts_check() has been told either to enforce consistency or
> > not, but that means that the caller has to know exactly what protocol is
> > going to be in use
71 matches
Mail list logo
