On 20 November 2013 10:59, Ben Pfaff <b...@nicira.com> wrote:
> I think we could delete netdev_dummy_changed() and
> netdev_vport_changed() entirely and just call netdev_notify() from the
> caller.

OK, sure. I can change the bsd version as well.

> I think that every netdev construct function now calls netdev_notify().
> If so, I guess we could call it centrally from netdev_open().

I see. That sounds more consistent with moving the seq to the netdev
provider layer.

> I'd expect that bond_wait() should use netdev_seq_wait() instead of
> a direct comparison followed by poll_immediate_wake().

I'll replace that.

> In the new comment here:
> + * although implementations should try to avoid this. netdev.c contains more
> + * information about this notification interface. */
> I'd be more specific about where to look, naming the related functions.

OK, thanks.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to