On 11/19/2013 10:50 PM, Pravin B Shelar wrote:
Rather than using complete flow hash, we can use skb->rxhash for
calculating source port. Similar calculation is done by vxlan.
Signed-off-by: Pravin B Shelar <pshe...@nicira.com>
---
datapath/vport-lisp.c | 9 +++------
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/datapath/vport-lisp.c b/datapath/vport-lisp.c
index e4e603f..0938e84 100644
--- a/datapath/vport-lisp.c
+++ b/datapath/vport-lisp.c
@@ -165,16 +165,13 @@ static __be64 instance_id_to_tunnel_id(__u8 *iid)
*/
static u16 get_src_port(struct sk_buff *skb)
{
- int low;
- int high;
unsigned int range;
- struct sw_flow_key *pkt_key = OVS_CB(skb)->pkt_key;
- u32 hash = jhash2((const u32 *)pkt_key,
- sizeof(*pkt_key) / sizeof(u32), 0);
+ int high;
+ int low;
inet_get_local_port_range(&low, &high);
range = (high - low) + 1;
- return (((u64) hash * range) >> 32) + low;
+ return (((u64) skb_get_rxhash(skb) * range) >> 32) + low;
}
static void lisp_build_header(const struct vport *vport,
I might be missing something but what about the rxhash == 0 case?
VXLAN does:
hash = skb_get_rxhash(skb);
if (!hash)
hash = jhash(skb->data, 2 * ETH_ALEN,
(__force u32) skb->protocol);
Shouldn't we hash the pkt_key then?
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
