On Wed, Nov 20, 2013 at 04:59:19PM -0800, Ben Pfaff wrote:
> On Wed, Nov 13, 2013 at 01:25:22PM +0900, Simon Horman wrote:
> > Add table config to to struct ofproto and set it
> > when a table mod message is received.
> > 
> > This is in preparation for changing the behaviour of the switch
> > based on table config.
> > 
> > Cc: Andy Zhou <az...@nicira.com>
> > Signed-off-by: Simon Horman <ho...@verge.net.au>
> 
> The 'config' member seems like a perfect place to use an atomic.  A
> rwlock is overkill.

Thanks, that makes sense to me.

> I don't see anything in handle_table_mod() that validates that the
> table_id is in the supported range.

Thanks, I'll fix that.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to