Re: [ovs-dev] [PATCH] OVS: add some tips for kvm guest env

2013-05-30 Thread Zhi Yong Wu
On Fri, May 31, 2013 at 12:15 PM, Ben Pfaff wrote: > On Fri, May 31, 2013 at 10:02:32AM +0800, Zhi Yong Wu wrote: >> On Fri, May 31, 2013 at 7:18 AM, Ben Pfaff wrote: >> > On Fri, May 31, 2013 at 06:47:34AM +0800, Zhi Yong Wu wrote: >> >> If multiple vswitches exist on the same host, how about th

Re: [ovs-dev] skb_gso_segment() bad offloads warnings fixed?

2013-05-30 Thread Jesse Gross
On Mon, May 27, 2013 at 3:26 PM, Rajahalme, Jarno (NSN - FI/Espoo) wrote: > > On May 24, 2013, at 19:26 , ext Jesse Gross wrote: > >> On Thu, May 23, 2013 at 9:41 PM, Rajahalme, Jarno (NSN - FI/Espoo) >> wrote: >>> >>> On May 23, 2013, at 20:28 , ext Jesse Gross wrote: The upstream commit is

Re: [ovs-dev] [PATCH V4] ofproto-dpif.c: Modify vsp_realdev_to_vlandev() function

2013-05-30 Thread Ben Pfaff
On Thu, May 30, 2013 at 06:24:44PM -0700, Alex Wang wrote: > Commit 52a90c29 (Implement new "VLAN splinters" feature) passed in OpenFlow > port number to vsp_realdev_to_vlandev() function which asks for datapath port > number. > > This patch fixes this bug by making the vsp_realdev_to_vlandev() fu

[ovs-dev] [branch-1.10] ofproto-dpif.c: Modify vsp_realdev_to_vlandev() function

2013-05-30 Thread Ben Pfaff
From: Alex Wang Commit 52a90c29 (Implement new "VLAN splinters" feature) passed in OpenFlow port number to vsp_realdev_to_vlandev() function which asks for datapath port number. This patch fixes this bug by making the vsp_realdev_to_vlandev() function take in and return OpenFlow port number. Si

Re: [ovs-dev] [PATCH] OVS: add some tips for kvm guest env

2013-05-30 Thread Ben Pfaff
On Fri, May 31, 2013 at 10:02:32AM +0800, Zhi Yong Wu wrote: > On Fri, May 31, 2013 at 7:18 AM, Ben Pfaff wrote: > > On Fri, May 31, 2013 at 06:47:34AM +0800, Zhi Yong Wu wrote: > >> If multiple vswitches exist on the same host, how about the routes > >> on the host? > > > > I don't understand thi

Re: [ovs-dev] [PATCH] OVS: add some tips for kvm guest env

2013-05-30 Thread Zhi Yong Wu
On Fri, May 31, 2013 at 7:18 AM, Ben Pfaff wrote: > On Fri, May 31, 2013 at 06:47:34AM +0800, Zhi Yong Wu wrote: >> If multiple vswitches exist on the same host, how about the routes >> on the host? > > I don't understand this question. It appears to ask whether multiple ah, sorry for my unclear

[ovs-dev] [PATCH V4] ofproto-dpif.c: Modify vsp_realdev_to_vlandev() function

2013-05-30 Thread Alex Wang
Commit 52a90c29 (Implement new "VLAN splinters" feature) passed in OpenFlow port number to vsp_realdev_to_vlandev() function which asks for datapath port number. This patch fixes this bug by making the vsp_realdev_to_vlandev() function take in and return OpenFlow port number. Signed-off-by: Alex

Re: [ovs-dev] [PATCH] ofproto-dpif: Simplify subfacet stat calculations.

2013-05-30 Thread Ben Pfaff
On Thu, May 30, 2013 at 02:45:12PM -0700, Ethan Jackson wrote: > Along with some minor minor cleanups, this patch simplifies the > calculation of the average subfacet count, and average subfacet > lifespan. They are both calculated as exponentially weighted > moving averages updated immediately af

Re: [ovs-dev] [PATCH V3] ofproto-dpif.c: Modify vsp_realdev_to_vlandev() function

2013-05-30 Thread Alex Wang
Sure, On Thu, May 30, 2013 at 4:26 PM, Ben Pfaff wrote: > On Thu, May 30, 2013 at 03:50:46PM -0700, Alex Wang wrote: > > Commit 52a90c29 (Implement new "VLAN splinters" feature) passed in > OpenFlow > > port number to vsp_realdev_to_vlandev() function which asks for datapath > port > > number.

Re: [ovs-dev] [PATCH V3] ofproto-dpif.c: Modify vsp_realdev_to_vlandev() function

2013-05-30 Thread Ben Pfaff
On Thu, May 30, 2013 at 03:50:46PM -0700, Alex Wang wrote: > Commit 52a90c29 (Implement new "VLAN splinters" feature) passed in OpenFlow > port number to vsp_realdev_to_vlandev() function which asks for datapath port > number. > > This patch fixes this bug by making the vsp_realdev_to_vlandev() fu

Re: [ovs-dev] [PATCH v4] ovs-vswitchd: An option to wait for userspace flow restore to complete.

2013-05-30 Thread Ben Pfaff
On Thu, May 30, 2013 at 01:53:06PM +, Gurucharan Shetty wrote: > While upgrading openvswitch, it helps to restore openflow flows before > starting packet processing. Typically we want to restart openvswitch, > add the openflow flows and then start packet processing. > > To do this, we look fo

Re: [ovs-dev] [PATCH] OVS: add some tips for kvm guest env

2013-05-30 Thread Ben Pfaff
On Fri, May 31, 2013 at 06:47:34AM +0800, Zhi Yong Wu wrote: > If multiple vswitches exist on the same host, how about the routes > on the host? I don't understand this question. It appears to ask whether multiple rules may exist on a host. The answer to that question is "yes", but I doubt it is

Re: [ovs-dev] [PATCH] OVS: add some tips for kvm guest env

2013-05-30 Thread Ben Pfaff
Please don't drop the mailing list. On Fri, May 31, 2013 at 06:42:50AM +0800, Zhi Yong Wu wrote: > On Fri, May 31, 2013 at 6:26 AM, Ben Pfaff wrote: > > Q: I created a bridge and added my Ethernet port to it, using commands > >like these: > > > >ovs-vsctl add-br br0 > >ovs-vsc

Re: [ovs-dev] OpenvSwitch version for Ubuntu Saucy + Kernel 3.9/3.10

2013-05-30 Thread Jesse Gross
On Wed, May 29, 2013 at 11:16 PM, James Page wrote: > Hi OpenvSwitch Devs > > Ubuntu Saucy development has been open for a while and the Ubuntu kernel > team are currently targeting either Linux 3.9 or 3.10 for this release. > > Currently the 1.9.0 DKMS source is unhappy with 3.9 - I've hacked on

Re: [ovs-dev] [PATCH v3 3/4] ovs-ctl.in: Restore flows with vswitchd packet processing disabled.

2013-05-30 Thread Ben Pfaff
On Thu, May 30, 2013 at 03:44:49PM -0700, Gurucharan Shetty wrote: > On Thu, May 30, 2013 at 1:47 PM, Ben Pfaff wrote: > > > On Thu, May 30, 2013 at 09:19:37AM +, Gurucharan Shetty wrote: > > > It has been observed that when we upgrade openvswitch with > > > thousands of openflow flows alread

[ovs-dev] [PATCH v4] ovs-vswitchd: An option to wait for userspace flow restore to complete.

2013-05-30 Thread Gurucharan Shetty
While upgrading openvswitch, it helps to restore openflow flows before starting packet processing. Typically we want to restart openvswitch, add the openflow flows and then start packet processing. To do this, we look for the other_config:flow-restore-wait column in the Open_vSwitch table during

Re: [ovs-dev] [PATCH] OVS: add some tips for kvm guest env

2013-05-30 Thread Zhi Yong Wu
If multiple vswitches exist on the same host, how about the routes on the host? by the way, can i consult another question? Why did OVS introduce two internal devices for each vswitch? ovs-dpctl show system@ovs-system: lookups: hit:2635398 missed:145705 lost:0 flows: 12 port 0: ovs-sys

Re: [ovs-dev] [PATCH v3 3/4] ovs-ctl.in: Restore flows with vswitchd packet processing disabled.

2013-05-30 Thread Gurucharan Shetty
On Thu, May 30, 2013 at 1:47 PM, Ben Pfaff wrote: > On Thu, May 30, 2013 at 09:19:37AM +, Gurucharan Shetty wrote: > > It has been observed that when we upgrade openvswitch with > > thousands of openflow flows already established and there is heavy > > traffic going through the switch, restor

[ovs-dev] [PATCH V3] ofproto-dpif.c: Modify vsp_realdev_to_vlandev() function

2013-05-30 Thread Alex Wang
Commit 52a90c29 (Implement new "VLAN splinters" feature) passed in OpenFlow port number to vsp_realdev_to_vlandev() function which asks for datapath port number. This patch fixes this bug by making the vsp_realdev_to_vlandev() function take in and return OpenFlow port number. Signed-off-by: Alex

Re: [ovs-dev] [PATCH] OVS: add some tips for kvm guest env

2013-05-30 Thread Ben Pfaff
Q: I created a bridge and added my Ethernet port to it, using commands like these: ovs-vsctl add-br br0 ovs-vsctl add-port br0 eth0 and as soon as I ran the "add-port" command I lost all connectivity through eth0. Help! A: A physical Ethernet device that is part of an Ope

Re: [ovs-dev] [PATCH v3 1/4] ovs-vswitchd: An option to wait for userspace flow restore to complete.

2013-05-30 Thread Ben Pfaff
On Thu, May 30, 2013 at 03:17:16PM -0700, Gurucharan Shetty wrote: > On Thu, May 30, 2013 at 1:36 PM, Ben Pfaff wrote: > > > On Thu, May 30, 2013 at 09:19:35AM +, Gurucharan Shetty wrote: > > > While upgrading openvswitch, it helps to restore openflow flows before > > > starting packet proces

Re: [ovs-dev] [PATCH] OVS: add some tips for kvm guest env

2013-05-30 Thread Zhi Yong Wu
Yes # ovs-vsctl show a9dc55a3-6755-4b91-957a-75cd9f27692e Bridge "br0" Port "em1" Interface "em1" Port "br0" Interface "br0" type: internal On Fri, May 31, 2013 at 6:17 AM, Ben Pfaff wrote: > Is em1 on bridge br0? > > On Fri, May 31, 2

Re: [ovs-dev] [PATCH] OVS: add some tips for kvm guest env

2013-05-30 Thread Ben Pfaff
Is em1 on bridge br0? On Fri, May 31, 2013 at 05:59:32AM +0800, Zhi Yong Wu wrote: > I tried to install OVS on my workstation, before starting kvm guest, > its route table is below: > default via 9.115.122.1 dev em1 > 9.115.122.0/24 dev em1 scope link > > then i started kvm guest: > qemu-system-

Re: [ovs-dev] [PATCH v3 1/4] ovs-vswitchd: An option to wait for userspace flow restore to complete.

2013-05-30 Thread Gurucharan Shetty
On Thu, May 30, 2013 at 1:36 PM, Ben Pfaff wrote: > On Thu, May 30, 2013 at 09:19:35AM +, Gurucharan Shetty wrote: > > While upgrading openvswitch, it helps to restore openflow flows before > > starting packet processing. Typically we want to restart openvswitch, > > add the openflow flows a

Re: [ovs-dev] [PATCH] OVS: add some tips for kvm guest env

2013-05-30 Thread Zhi Yong Wu
I tried to install OVS on my workstation, before starting kvm guest, its route table is below: default via 9.115.122.1 dev em1 9.115.122.0/24 dev em1 scope link then i started kvm guest: qemu-system-x86_64 -drive file=/home/zwu/misc/image/debian_squeeze_i386_desktop.qcow2,if=virtio -kernel arch/x

Re: [ovs-dev] [PATCH] OVS: add some tips for kvm guest env

2013-05-30 Thread Ben Pfaff
I don't know. I think that you would have to describe your scenario, before we can say what (if anything) you are doing wrong. On Fri, May 31, 2013 at 05:45:06AM +0800, Zhi Yong Wu wrote: > If i don't add such a route, it seem to not work, do i miss other something? > > On Fri, May 31, 2013 at 2

[ovs-dev] [PATCH] ofproto-dpif: Simplify subfacet stat calculations.

2013-05-30 Thread Ethan Jackson
Along with some minor minor cleanups, this patch simplifies the calculation of the average subfacet count, and average subfacet lifespan. They are both calculated as exponentially weighted moving averages updated immediately after statistics are pulled from the datapath. This both simplifies the

Re: [ovs-dev] [PATCH] OVS: add some tips for kvm guest env

2013-05-30 Thread Zhi Yong Wu
If i don't add such a route, it seem to not work, do i miss other something? On Fri, May 31, 2013 at 2:23 AM, Ben Pfaff wrote: > On Thu, May 30, 2013 at 06:40:26PM +0800, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> Add some tips for kvm guest; You know, it is a bit difficult >> to p

Re: [ovs-dev] [PATCH] ofproto-dpif: Fix a typo

2013-05-30 Thread Ben Pfaff
On Thu, May 30, 2013 at 02:37:57PM -0700, Alex Wang wrote: > This patch fixes a typo in handle_miss_upcalls() function. > > Signed-off-by: Alex Wang Thanks, applied to master. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/list

Re: [ovs-dev] [PATCH V2] ofproto-dpif.c: Modify vsp_realdev_to_vlandev() function

2013-05-30 Thread Ben Pfaff
Searching the commit logs might be worthwhile to find out where the bug was introduced. If that is what you mean, then that would be valuable information to add to the commit log, so if it only takes a few minutes then it is worthwhile. But I actually meant that the commit message should make it

Re: [ovs-dev] [PATCH v2 1/3] ovs-vswitchd: An option to wait for userspace > flow restore to complete. (Gurucharan Shetty)

2013-05-30 Thread Jing Ai
Date: Thu, 30 May 2013 08:12:16 -0700 Subject: Re: [ovs-dev] [PATCH v2 1/3] ovs-vswitchd: An option to wait for userspace > flow restore to complete. (Gurucharan Shetty) From: shet...@nicira.com To: ai_jing2...@hotmail.com CC: dev@openvswitch.org On Wed, May 29, 2013 at 7:18 PM, Jing Ai wrote:

Re: [ovs-dev] [PATCH V2] ofproto-dpif.c: Modify vsp_realdev_to_vlandev() function

2013-05-30 Thread Alex Wang
Thanks Ben, I'll search the commit logs. On Thu, May 30, 2013 at 2:26 PM, Ben Pfaff wrote: > On Wed, May 29, 2013 at 06:24:04PM -0700, Alex Wang wrote: > > This patch modifies the vsp_realdev_to_vlandev() function. Instead of > taking > > and returning datapath port number, the new implementat

[ovs-dev] [PATCH] ofproto-dpif: Simplify ofproto hit count tracking.

2013-05-30 Thread Ethan Jackson
Oops, that version broke the unit tests. This version is the exact same, except in update_subfacet_stats() we add 'diff.n_packets' not 'stats->n_packets'. I considered this reviewed, and will merge shortly. --- ofproto/ofproto-dpif.c | 18 ++ 1 file changed, 2 insertions(+), 1

Re: [ovs-dev] [PATCH V2] ofproto-dpif.c: Modify vsp_realdev_to_vlandev() function

2013-05-30 Thread Ben Pfaff
On Wed, May 29, 2013 at 06:24:04PM -0700, Alex Wang wrote: > This patch modifies the vsp_realdev_to_vlandev() function. Instead of taking > and returning datapath port number, the new implementation takes and returns > OpenFlow port number. > > Signed-off-by: Alex Wang This looks good. I think

[ovs-dev] [PATCH] ofproto-dpif: Fix a typo

2013-05-30 Thread Alex Wang
This patch fixes a typo in handle_miss_upcalls() function. Signed-off-by: Alex Wang --- ofproto/ofproto-dpif.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index b4308aa..5410b2c 100644 --- a/ofproto/ofproto-dpif

Re: [ovs-dev] [PATCH v3 4/4] INSTALL: Add documentaion for hot upgrades.

2013-05-30 Thread Ben Pfaff
On Thu, May 30, 2013 at 09:19:38AM +, Gurucharan Shetty wrote: > Signed-off-by: Gurucharan Shetty This looks helpful, thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v3 3/4] ovs-ctl.in: Restore flows with vswitchd packet processing disabled.

2013-05-30 Thread Ben Pfaff
On Thu, May 30, 2013 at 09:19:37AM +, Gurucharan Shetty wrote: > It has been observed that when we upgrade openvswitch with > thousands of openflow flows already established and there is heavy > traffic going through the switch, restoring flows can take a very > long time (8 minutes in one use

Re: [ovs-dev] Create bonded trunk with openvswitch

2013-05-30 Thread Ben Pfaff
Please don't drop the mailing list. On Fri, May 31, 2013 at 02:11:51AM +0530, Ashraf Khalid wrote: > I tried the same, but no progress. > > I have cross checked on the physical interfaces of the host, and > physical switch configuration...and everything looks ok. > > Only when I create the bridg

Re: [ovs-dev] [PATCH v3 2/4] ovs-ctl.in: Add manager after restoring flows.

2013-05-30 Thread Ben Pfaff
On Thu, May 30, 2013 at 09:19:36AM +, Gurucharan Shetty wrote: > Currently we are adding the manager after starting ovs-vswitchd. > Instead, add the manager after flow restore is completed. > > Bug #16086. > Signed-off-by: Gurucharan Shetty Looks good, thanks. ___

Re: [ovs-dev] [PATCH] ofproto-dpif: Simplify ofproto hit count tracking.

2013-05-30 Thread Ben Pfaff
On Thu, May 30, 2013 at 01:36:23PM -0700, Ethan Jackson wrote: > Signed-off-by: Ethan Jackson Looks good, thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v3 1/4] ovs-vswitchd: An option to wait for userspace flow restore to complete.

2013-05-30 Thread Ben Pfaff
On Thu, May 30, 2013 at 09:19:35AM +, Gurucharan Shetty wrote: > While upgrading openvswitch, it helps to restore openflow flows before > starting packet processing. Typically we want to restart openvswitch, > add the openflow flows and then start packet processing. > > To do this, we look fo

[ovs-dev] [PATCH] ofproto-dpif: Simplify ofproto hit count tracking.

2013-05-30 Thread Ethan Jackson
Signed-off-by: Ethan Jackson --- ofproto/ofproto-dpif.c | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index ffd2399..6442ffd 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofproto/ofproto-dpif.c @@ -658,8 +658,

Re: [ovs-dev] Create bonded trunk with openvswitch

2013-05-30 Thread Duffie Cooley
There are examples for doing this with the network scripts of most distributions here: RHEL: http://git.openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=blob;f=rhel/README.RHEL DEB: http://git.openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=blob;f=debian/openvswitch-switch.README.Debian

Re: [ovs-dev] [PATCH] Implement duration fields in OpenFlow 1.3 port stats.

2013-05-30 Thread Ben Pfaff
Thanks! I took a few minutes to add a proper test, as follows, and I'll push this to master soon. diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at index 3b816af..37c531b 100644 --- a/tests/ofproto-dpif.at +++ b/tests/ofproto-dpif.at @@ -2194,3 +2194,26 @@ br0 (dummy@ovs-dummy): OVS_V

Re: [ovs-dev] Create bonded trunk with openvswitch

2013-05-30 Thread Ben Pfaff
On Thu, May 30, 2013 at 06:59:10PM +, Ashraf Khalid wrote: > I have 2 KVM nodes using OpenvSwitch 1.10 on CentOS 6.x. The intention is to > have a redundant KVM HA cluster hereafter, and allowing VMs to migrate > easily between the KVM hosts. > > I have not bonded the physical interfaces on th

Re: [ovs-dev] [PATCH] ofproto-dpif: Remove useless odp_in_port from subfacet.

2013-05-30 Thread Ben Pfaff
On Wed, May 29, 2013 at 04:06:53PM -0700, Ethan Jackson wrote: > Signed-off-by: Ethan Jackson Looks good, thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] Create bonded trunk with openvswitch

2013-05-30 Thread Ashraf Khalid
Ben Pfaff writes: > > On Fri, Jul 01, 2011 at 07:10:46AM +0200, Sébastien Riccio wrote: > > On 01.07.2011 06:42, Ben Pfaff wrote: > > >On Fri, Jul 01, 2011 at 06:35:21AM +0200, Sébastien Riccio wrote: > > >>My machine has 6 nics and I wish to user the first two as a bonded > > >>trunk (for vlans

Re: [ovs-dev] [PATCH] OVS: add some tips for kvm guest env

2013-05-30 Thread Ben Pfaff
On Thu, May 30, 2013 at 06:40:26PM +0800, zwu.ker...@gmail.com wrote: > From: Zhi Yong Wu > > Add some tips for kvm guest; You know, it is a bit difficult > to play for one starter if no such tips exist. > > Signed-off-by: Zhi Yong Wu It isn't normally necessary to add such a route.

Re: [ovs-dev] [PATCH] ofproto-dpif: Consolidate facet stat logic.

2013-05-30 Thread Ben Pfaff
On Thu, May 30, 2013 at 12:34:35PM -0500, Ethan Jackson wrote: > > In facet_push_stats(), I wonder whether it is necessary to check all of > > stats.n_packets, stats.n_bytes, and stats.used. Presumably, n_packets > > is nonzero if and only if n_bytes is nonzero, and used can be greater > > than pr

[ovs-dev] [PATCH v3 3/4] ovs-ctl.in: Restore flows with vswitchd packet processing disabled.

2013-05-30 Thread Gurucharan Shetty
It has been observed that when we upgrade openvswitch with thousands of openflow flows already established and there is heavy traffic going through the switch, restoring flows can take a very long time (8 minutes in one use case) with CPU running at 100%. This can make the upgrade very expensive.

[ovs-dev] [PATCH v3 2/4] ovs-ctl.in: Add manager after restoring flows.

2013-05-30 Thread Gurucharan Shetty
Currently we are adding the manager after starting ovs-vswitchd. Instead, add the manager after flow restore is completed. Bug #16086. Signed-off-by: Gurucharan Shetty --- utilities/ovs-ctl.in | 28 +--- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/ut

[ovs-dev] [PATCH v3 4/4] INSTALL: Add documentaion for hot upgrades.

2013-05-30 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty --- INSTALL | 42 ++ 1 file changed, 42 insertions(+) diff --git a/INSTALL b/INSTALL index 68805ee..28bc1a0 100644 --- a/INSTALL +++ b/INSTALL @@ -343,6 +343,48 @@ also upgrade the database schema: 4. Start the Open vSwi

[ovs-dev] [PATCH v3 1/4] ovs-vswitchd: An option to wait for userspace flow restore to complete.

2013-05-30 Thread Gurucharan Shetty
While upgrading openvswitch, it helps to restore openflow flows before starting packet processing. Typically we want to restart openvswitch, add the openflow flows and then start packet processing. To do this, we look for the other_config:flow-restore-wait column in the Open_vSwitch table during

Re: [ovs-dev] [PATCH v2 1/3] ovs-vswitchd: An option to wait for userspace flow restore to complete.

2013-05-30 Thread Gurucharan Shetty
On Wed, May 29, 2013 at 4:46 PM, Ben Pfaff wrote: > On Tue, May 28, 2013 at 02:02:17PM +, Gurucharan Shetty wrote: > > While upgrading openvswitch, it helps to restore openflow flows before > > starting packet processing. Typically we want to restart openvswitch, > > add the openflow flows a

Re: [ovs-dev] [PATCH] ofproto-dpif: Fix facet_lookup_valid().

2013-05-30 Thread Ben Pfaff
On Wed, May 29, 2013 at 04:27:19PM -0700, Ethan Jackson wrote: > facet_lookup_valid() attempted to re-revalidate its facet after > it had been removed. > > Found by inspection (by Justin). > > Reported-by: Justin Pettit > Signed-off-by: Ethan Jackson How'd I miss that? Thanks, looks good. Th

Re: [ovs-dev] [PATCH] ofproto-dpif: Consolidate facet stat logic.

2013-05-30 Thread Ethan Jackson
> In facet_push_stats(), I wonder whether it is necessary to check all of > stats.n_packets, stats.n_bytes, and stats.used. Presumably, n_packets > is nonzero if and only if n_bytes is nonzero, and used can be greater > than prev_used only if n_packets (or n_bytes) is nonzero. I definitely agree

Re: [ovs-dev] OpenvSwitch version for Ubuntu Saucy + Kernel 3.9/3.10

2013-05-30 Thread Pravin Shelar
On Wed, May 29, 2013 at 7:16 AM, James Page wrote: > Hi OpenvSwitch Devs > > Ubuntu Saucy development has been open for a while and the Ubuntu kernel > team are currently targeting either Linux 3.9 or 3.10 for this release. > > Currently the 1.9.0 DKMS source is unhappy with 3.9 - I've hacked on i

Re: [ovs-dev] [xlate 1.11 9/9] ofproto-dpif: Revamp xlate_actions() interface.

2013-05-30 Thread Ethan Jackson
> > orig_tunnel_ip_dst is not used in 1.11 yet, so it should be deleted from this > patch. > There is only one use of it later in the patch, which should also be removed. > ... That's why I wanted someone to peek at it =). Thanks Jarno, I'll delete it. Ethan >> >> - >> -/* Translates the 'ofpa

Re: [ovs-dev] [PATCH v2 1/3] ovs-vswitchd: An option to wait for userspace > flow restore to complete. (Gurucharan Shetty)

2013-05-30 Thread Gurucharan Shetty
On Wed, May 29, 2013 at 7:18 PM, Jing Ai wrote: > > > -- > Date: Wed, 29 May 2013 13:46:05 -0700 > Subject: Re: [ovs-dev] [PATCH v2 1/3] ovs-vswitchd: An option to wait for > userspace > flow restore to complete. (Gurucharan Shetty) > From: shet...@nicira.com > To: ai_

Re: [ovs-dev] [PATCH] ofproto-dpif: Consolidate facet stat logic.

2013-05-30 Thread Ben Pfaff
On Wed, May 29, 2013 at 03:43:34PM -0700, Ethan Jackson wrote: > The logic for updating statistics at the facet level had been > spread through ofproto-dpif in a rather confusing manner. This > patch consolidates as much of this logic as is reasonable into > facet_push_stats(). > > On a side note

[ovs-dev] [PATCH] OVS: add some tips for kvm guest env

2013-05-30 Thread zwu . kernel
From: Zhi Yong Wu Add some tips for kvm guest; You know, it is a bit difficult to play for one starter if no such tips exist. Signed-off-by: Zhi Yong Wu --- INSTALL.KVM | 3 +++ 1 file changed, 3 insertions(+) diff --git a/INSTALL.KVM b/INSTALL.KVM index aa7ab92..4a169ee 100644 --- a/INSTAL

Re: [ovs-dev] [xlate 1.11 9/9] ofproto-dpif: Revamp xlate_actions() interface.

2013-05-30 Thread Rajahalme, Jarno (NSN - FI/Espoo)
On May 30, 2013, at 0:24 , ext Ethan Jackson wrote: > +/* Context used by xlate_actions() and its callees. */ > +struct xlate_ctx { > +struct xlate_in *xin; > +struct xlate_out *xout; > > -struct ofpbuf *odp_actions; /* Datapath actions. */ > -tag_type tags; /* Tags

Re: [ovs-dev] [PATCH v11 2/6] Add set skb_mark, set_priority and tunnel support to execute_set_action

2013-05-30 Thread Simon Horman
On Wed, May 29, 2013 at 01:23:51PM -0700, Ben Pfaff wrote: > On Wed, May 29, 2013 at 03:06:39PM +0900, Simon Horman wrote: > > Add set skb_mark support to execute_set_action. > > Now renamed odp_execute_actions(). > > > This also adds support for the user-space datapath > > to honour such actions