Searching the commit logs might be worthwhile to find out where the bug was introduced. If that is what you mean, then that would be valuable information to add to the commit log, so if it only takes a few minutes then it is worthwhile.
But I actually meant that the commit message should make it clear that it is fixing a bug (if it is), as well as some small idea of what the consequences of the bug are. For example: ofproto-dpif: Fix bug in VLAN splinters. vsp_realdev_to_vlandev() took and returned an OpenFlow port number but one caller treated it as if it took and returned an ODP port number, which broke VLAN splinters. This commit fixes the bug, making vsp_realdev_to_vlandev() and its callers consistent. if that's actually correct (not sure). On Thu, May 30, 2013 at 02:30:51PM -0700, Alex Wang wrote: > Thanks Ben, > > I'll search the commit logs. > > > On Thu, May 30, 2013 at 2:26 PM, Ben Pfaff <b...@nicira.com> wrote: > > > On Wed, May 29, 2013 at 06:24:04PM -0700, Alex Wang wrote: > > > This patch modifies the vsp_realdev_to_vlandev() function. Instead of > > taking > > > and returning datapath port number, the new implementation takes and > > returns > > > OpenFlow port number. > > > > > > Signed-off-by: Alex Wang <al...@nicira.com> > > > > This looks good. > > > > I think that this fixes an actual bug in OVS 1.10 and later. Is that > > correct? It is not clear from the commit log, which describes what > > changed but not why. If it fixes a bug, please update the commit > > message to make it clear. Then I'll apply it (and backport as > > necessary). > > > > Thanks, > > > > Ben. > > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
