> In facet_push_stats(), I wonder whether it is necessary to check all of > stats.n_packets, stats.n_bytes, and stats.used. Presumably, n_packets > is nonzero if and only if n_bytes is nonzero, and used can be greater > than prev_used only if n_packets (or n_bytes) is nonzero.
I definitely agree in the case of n_packets and n_bytes, so I've changed the patch to skip the n_bytes check. In terms of used and prev_used, the interaction between the facet timers and statistics is so complicated, that I feel a bit safer leaving the check in. Doesn't cost much, and feels a bit more future proof. Ethan _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
