On Thu, May 30, 2013 at 03:17:16PM -0700, Gurucharan Shetty wrote:
> On Thu, May 30, 2013 at 1:36 PM, Ben Pfaff <b...@nicira.com> wrote:
>
> > On Thu, May 30, 2013 at 09:19:35AM +0000, Gurucharan Shetty wrote:
> > > While upgrading openvswitch, it helps to restore openflow flows before
> > > starting packet processing. Typically we want to restart openvswitch,
> > > add the openflow flows and then start packet processing.
> > >
> > > To do this, we look for the other_config:flow-restore-wait column
> > > in the Open_vSwitch table during startup. If set as true, we disable
> > > receiving packets from the datapath, expiring or flushing flows and
> > > running any periodic ofproto activities. This option does not prevent
> > > the addition and deletion of ports. Once this option is set to false,
> > > we return to normal processing.
> > >
> > > An upcoming commit will use this feature in Open vSwitch startup scripts.
> > >
> > > Bug #16086.
> > > Signed-off-by: Gurucharan Shetty <gshe...@nicira.com>
> >
> > Thanks! I think that this is close. Sorry to nitpick, but I still
> > have some comments.
> >
> > > @@ -1025,7 +1041,10 @@ type_run(const char *type)
> > > }
> > > }
> > >
> > > - if (timer_expired(&backer->next_expiration)) {
> > > + if (!backer->recv_set_enable) {
> > > + /* A minimum of 1000 ms delay. */
> >
> > Doesn't think actually cause the main loop to wake up after at most
> > 1000 ms, that is, a *maximum* of 1000 ms? Or perhaps I misunderstand
> > the intent.
> >
> > I was intending to say that don't wake up immediately because of me. I can
> wait till 1000 ms.
> Previously expire() would setup a MIN(x, 1000). Since I do not have 'x'
> now, I set 1000 ms.
> I think we both mean the same thing? How would the following sound?
> /* Wake up before a max of 1000ms. */
OK.
(and OK on everything else)
Thanks,
Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
