On Wed, May 29, 2013 at 03:43:34PM -0700, Ethan Jackson wrote: > The logic for updating statistics at the facet level had been > spread through ofproto-dpif in a rather confusing manner. This > patch consolidates as much of this logic as is reasonable into > facet_push_stats(). > > On a side note, I'd expect this patch to have a marginal positive > performance impact when using learning (though I haven't bothered > to measure it). It combines facet_learn() and facet_push_stats() > into one step allowing us to avoid a redundant xlate_actions(). > > Signed-off-by: Ethan Jackson <et...@nicira.com>
This is a nice cleanup. Thanks! In facet_push_stats(), I wonder whether it is necessary to check all of stats.n_packets, stats.n_bytes, and stats.used. Presumably, n_packets is nonzero if and only if n_bytes is nonzero, and used can be greater than prev_used only if n_packets (or n_bytes) is nonzero. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
