---
lib/flow.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/flow.c b/lib/flow.c
index ec233bc..8b03e76 100644
--- a/lib/flow.c
+++ b/lib/flow.c
@@ -452,13 +452,13 @@ flow_zero_wildcards(struct flow *flow, const struct
flow_wildcards *wildcards)
}
flo
It's no longer necessary to maintain a "nw_tos_mask" wildcard member,
since we only care about completely wildcarding the DSCP and ECN
portions of the IP TOS field. This commit makes that change. It also
goes a bit further in internally using "tos" to refer to the entire TOS
field (ie, DSCP and E
The MAY_IPV6_ADDR function now includes the IPv6 flow label, so it is
clearer to just call it MAY_IPV6.
---
lib/ofp-util.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 923df05..b6a35b0 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-
Most of the members in structures referring to network elements indicate
the layer (e.g., "tl_", "nw_", "tp_"). The "frag" and "tos" members
didn't, so this commit add them.
---
lib/classifier.c| 61 ---
lib/classifier.h|5 ++-
lib
The meta-flow code enforces IPv4/IPv6 masks, so there's no reason to do
it again in the classifier. This allows a number of functions to be
removed, since the only callers were in this classifier code.
---
lib/classifier.c | 55 +++-
lib/classifier.h
On Thu, Nov 10, 2011 at 1:20 AM, Ben Pfaff wrote:
> OK, great, so what are those issues?
>
> On Wed, Nov 09, 2011 at 05:12:13PM +0900, Jari Sundell wrote:
>> The attached file shows output from dpctl dump-flows for the working,
>> and non-working revisions. I think the mod_dl_dst part might have b
On Thu, Nov 10, 2011 at 10:20:24AM +0900, Simon Horman wrote:
> On Wed, Nov 09, 2011 at 01:19:42PM -0800, Ben Pfaff wrote:
> > On Mon, Nov 07, 2011 at 04:20:19PM +0900, Simon Horman wrote:
> > > Although a very simple and possibly na??ve approach, I wonder if
> > > dynamically extending the interva
On Wed, Nov 9, 2011 at 6:40 PM, Pravin B Shelar wrote:
> Following patch deletes OVS compatibility code related to older kernel,
> bridge, vlan etc and rearranges it for upstreaming.
>
> This patch is against OVS upstream kernel tree.
>
> Signed-off-by: Pravin B Shelar
> Bug #7561
I haven't look
On Wed, Nov 9, 2011 at 11:14 AM, Jesse Gross wrote:
> On Tue, Nov 8, 2011 at 7:51 PM, Pravin B Shelar wrote:
>> commit 6455100f38e9312346f4d58511595f695d813537 (datapath: Fix
>> coding style issues) introduced this issue.
>>
>> Signed-off-by: Pravin B Shelar
>
> Thanks:
> Acked-by: Jesse Gross
Following patch deletes OVS compatibility code related to older kernel,
bridge, vlan etc and rearranges it for upstreaming.
This patch is against OVS upstream kernel tree.
Signed-off-by: Pravin B Shelar
Bug #7561
---
include/linux/openvswitch.h |8 +-
net/openvswitch/actions.c
This function is used for sending notification over
genl_sock.
Signed-off-by: Pravin B Shelar
Bug #7561
---
include/net/genetlink.h |2 ++
net/netlink/genetlink.c | 13 +
2 files changed, 15 insertions(+), 0 deletions(-)
diff --git a/include/net/genetlink.h b/include/n
On Wed, Nov 9, 2011 at 5:54 PM, Ansis Atteka wrote:
> The function flow_metadata_from_nlattrs() is very restrictive
> about the ordering and type of metadata attributes that it receives.
> This patch will change flow_metadata_from_nlattrs() behavior by
> ignoring attributes that it does not unders
The function flow_metadata_from_nlattrs() is very restrictive
about the ordering and type of metadata attributes that it receives.
This patch will change flow_metadata_from_nlattrs() behavior by
ignoring attributes that it does not understand and allowing them
to be passed in arbitrary order.
Issu
On Wed, Nov 09, 2011 at 01:19:42PM -0800, Ben Pfaff wrote:
> On Mon, Nov 07, 2011 at 04:20:19PM +0900, Simon Horman wrote:
> > Although a very simple and possibly na??ve approach, I wonder if
> > dynamically extending the interval at which statistics are collected is
> > a worthwhile approach to mi
I like how this removes over 20 lines of code and ends up more readable.
---
lib/classifier.c | 30 +++---
1 files changed, 3 insertions(+), 27 deletions(-)
diff --git a/lib/classifier.c b/lib/classifier.c
index 8ffc96f..04e545e 100644
--- a/lib/classifier.c
+++ b/lib/cl
On Wed, Nov 09, 2011 at 11:42:04AM -0800, Jesse Gross wrote:
> In order to aid the efforts to upstream the kernel portions of OVS,
> I've created a new tree on kernel.org that's available at:
> git://git.kernel.org/pub/scm/linux/kernel/git/jesse/openvswitch.git
This is a really exciting step, than
On Wed, Nov 9, 2011 at 2:12 PM, Ben Pfaff wrote:
> On Wed, Nov 09, 2011 at 02:15:23PM -0800, Jesse Gross wrote:
>> A few of the recently added fields in struct sw_flow_key had
>> comments that weren't properly aligned.
>>
>> Signed-off-by: Jesse Gross
>
> Acked-by: Ben Pfaff
Pushed, thanks.
___
On Wed, Nov 09, 2011 at 02:15:23PM -0800, Jesse Gross wrote:
> A few of the recently added fields in struct sw_flow_key had
> comments that weren't properly aligned.
>
> Signed-off-by: Jesse Gross
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswit
A few of the recently added fields in struct sw_flow_key had
comments that weren't properly aligned.
Signed-off-by: Jesse Gross
---
datapath/flow.h |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/datapath/flow.h b/datapath/flow.h
index c08d3df..43360cc 100644
--- a/
On Wed, Nov 09, 2011 at 01:28:18PM -0800, Jesse Gross wrote:
> On Wed, Nov 9, 2011 at 1:12 PM, Ben Pfaff wrote:
> > On Tue, Nov 08, 2011 at 06:40:51PM -0800, Jesse Gross wrote:
> >> On Tue, Nov 8, 2011 at 5:03 PM, Ben Pfaff wrote:
> >> > Jesse and I spent some time pondering this face-to-face, so
On Wed, Nov 9, 2011 at 1:12 PM, Ben Pfaff wrote:
> On Tue, Nov 08, 2011 at 06:40:51PM -0800, Jesse Gross wrote:
>> On Tue, Nov 8, 2011 at 5:03 PM, Ben Pfaff wrote:
>> > Jesse and I spent some time pondering this face-to-face, so there's a
>> > bunch of discussion that hasn't shown up on the maili
On Nov 9, 2011, at 12:54 PM, Jesse Gross wrote:
> On Wed, Nov 9, 2011 at 12:12 PM, Justin Pettit wrote:
>> On Nov 9, 2011, at 12:00 PM, Justin Pettit wrote:
>>
Should we make the "ttl=" be "hop_limit=" as well?
Otherwise, looks good.
>>
>> As we discussed off-line, it's probably
On Mon, Nov 07, 2011 at 04:20:19PM +0900, Simon Horman wrote:
> Although a very simple and possibly na??ve approach, I wonder if
> dynamically extending the interval at which statistics are collected is
> a worthwhile approach to mitigating the performance impact of statistics
> collection.
It's o
On Tue, Nov 08, 2011 at 06:40:51PM -0800, Jesse Gross wrote:
> On Tue, Nov 8, 2011 at 5:03 PM, Ben Pfaff wrote:
> > Jesse and I spent some time pondering this face-to-face, so there's a
> > bunch of discussion that hasn't shown up on the mailing list.
> >
> > My understanding of what we concluded
On Tue, Nov 8, 2011 at 8:27 PM, Jesse Gross wrote:
> On Tue, Nov 8, 2011 at 8:20 PM, Ben Pfaff wrote:
>> On Tue, Nov 08, 2011 at 06:40:51PM -0800, Jesse Gross wrote:
>>> On Tue, Nov 8, 2011 at 5:03 PM, Ben Pfaff wrote:
>>> > Jesse and I spent some time pondering this face-to-face, so there's a
>
On Wed, Nov 9, 2011 at 12:12 PM, Justin Pettit wrote:
> On Nov 9, 2011, at 12:00 PM, Justin Pettit wrote:
>
>>> Should we make the "ttl=" be "hop_limit=" as well?
>>>
>>> Otherwise, looks good.
>
> As we discussed off-line, it's probably better to use "hlimit" since it's
> shorter and we're alrea
On Nov 9, 2011, at 12:00 PM, Justin Pettit wrote:
>> Should we make the "ttl=" be "hop_limit=" as well?
>>
>> Otherwise, looks good.
As we discussed off-line, it's probably better to use "hlimit" since it's
shorter and we're already breaking from other kernel naming conventions. An
incrementa
On Wed, Nov 9, 2011 at 12:07 PM, Justin Pettit wrote:
> On Nov 9, 2011, at 11:56 AM, Jesse Gross wrote:
>
>> On Wed, Nov 9, 2011 at 11:50 AM, Justin Pettit wrote:
>>> diff --git a/lib/odp-util.c b/lib/odp-util.c
>>> index 8ced2d4..04c0828 100644
>>> --- a/lib/odp-util.c
>>> +++ b/lib/odp-util.c
>
On Nov 9, 2011, at 11:56 AM, Jesse Gross wrote:
> On Wed, Nov 9, 2011 at 11:50 AM, Justin Pettit wrote:
>> diff --git a/lib/odp-util.c b/lib/odp-util.c
>> index 8ced2d4..04c0828 100644
>> --- a/lib/odp-util.c
>> +++ b/lib/odp-util.c
>> @@ -389,7 +389,7 @@ format_odp_key_attr(const struct nlattr *
On Nov 9, 2011, at 11:53 AM, Jesse Gross wrote:
> On Wed, Nov 9, 2011 at 11:21 AM, Justin Pettit wrote:
>> diff --git a/lib/odp-util.c b/lib/odp-util.c
>> index 3703844..4b0cee4 100644
>> --- a/lib/odp-util.c
>> +++ b/lib/odp-util.c
>> @@ -390,7 +390,7 @@ format_odp_key_attr(const struct nlattr *
On Wed, Nov 9, 2011 at 11:50 AM, Justin Pettit wrote:
> diff --git a/lib/odp-util.c b/lib/odp-util.c
> index 8ced2d4..04c0828 100644
> --- a/lib/odp-util.c
> +++ b/lib/odp-util.c
> @@ -389,7 +389,7 @@ format_odp_key_attr(const struct nlattr *a, struct ds *ds)
> ds_put_format(ds, "ipv6(src=
On Wed, Nov 9, 2011 at 11:21 AM, Justin Pettit wrote:
> diff --git a/lib/odp-util.c b/lib/odp-util.c
> index 3703844..4b0cee4 100644
> --- a/lib/odp-util.c
> +++ b/lib/odp-util.c
> @@ -390,7 +390,7 @@ format_odp_key_attr(const struct nlattr *a, struct ds *ds)
> ",tos=%#"PRIx8
IPv6 uses the term "traffic class" for what IPv4 calls
"type-of-service". This commit renames the the "ipv6_tos" field to
"ipv6_tclass" in the "ovs-key_ipv6" struct to be more consistent with
the IPv6 terminology.
Suggested-by: Jesse Gross
Signed-off-by: Justin Pettit
---
datapath/flow.c
In order to aid the efforts to upstream the kernel portions of OVS,
I've created a new tree on kernel.org that's available at:
git://git.kernel.org/pub/scm/linux/kernel/git/jesse/openvswitch.git
The interesting branch is called upstream-prep. At the moment it
contains just direct copies of the co
On Wed, Nov 09, 2011 at 11:08:11AM -0800, Jesse Gross wrote:
> On Fri, Nov 4, 2011 at 4:43 PM, Ben Pfaff wrote:
> > Feature #4886.
> > ---
> > ??lib/odp-util.c ?? ?? ?? ?? | ??465 +--
> > ??lib/odp-util.h ?? ?? ?? ?? | ?? 17 +-
> > ??ofproto/ofproto-dpif.c | ??724
> >
On Wed, Nov 09, 2011 at 11:21:07AM -0800, Justin Pettit wrote:
> On Nov 8, 2011, at 10:52 PM, Jesse Gross wrote:
> >> @@ -71,22 +71,23 @@ struct flow {
> >> uint8_t dl_dst[6]; /* Ethernet destination address. */
> >> uint8_t nw_proto; /* IP protocol or low 8 bits of ARP
On Nov 9, 2011, at 7:29 AM, Ben Pfaff wrote:
> On Tue, Nov 08, 2011 at 11:06:21PM -0800, Justin Pettit wrote:
>> On Nov 8, 2011, at 4:24 PM, Ben Pfaff wrote:
>>
>>> I think that these |=s can become =s:
>>>
- key->ip.tos_frag |= OVS_FRAG_TYPE_LATER;
+
On Nov 8, 2011, at 10:52 PM, Jesse Gross wrote:
> I got a whitespace error:
> Applying: Support matching and modifying IP TTL.
> /home/jesse/openvswitch/.git/rebase-apply/patch:977: trailing whitespace.
> Matches IP TTL or IPv6 hop limit value \fIttl\fR, which is
> warning: 1 line adds whitespace
On Tue, Nov 8, 2011 at 7:51 PM, Pravin B Shelar wrote:
> commit 6455100f38e9312346f4d58511595f695d813537 (datapath: Fix
> coding style issues) introduced this issue.
>
> Signed-off-by: Pravin B Shelar
Thanks:
Acked-by: Jesse Gross
___
dev mailing list
On Fri, Nov 4, 2011 at 4:43 PM, Ben Pfaff wrote:
> Feature #4886.
> ---
> lib/odp-util.c | 465 +--
> lib/odp-util.h | 17 +-
> ofproto/ofproto-dpif.c | 724
> +---
> tests/automake.mk | 2 +
> 4
Looks reasonable to me.
--Justin
On Nov 9, 2011, at 8:35 AM, Ben Pfaff wrote:
> This doesn't fix a visible bug, since there's no epoch in the Open vSwitch
> version used in Debian, but some Nicira internal build scripts were
> inserting an epoch so it was visible in our builds.
>
> Reported-by
On Nov 9, 2011, at 9:17 AM, Jesse Gross wrote:
>> If you have a better suggestion, let me know. I'm hoping that we can get
>> some sanity in 1.2, and then we can just adopt that convention in the
>> userspace.
>
> Yeah, I remember that conversation. What specifically caught my eye
> though wa
On Wed, Nov 9, 2011 at 9:10 AM, Justin Pettit wrote:
> On Nov 9, 2011, at 8:50 AM, Jesse Gross wrote:
>
>>> An incremental is at the end of this message.
>>
>> Looks good, thanks.
>
>
> Thanks. If it all looks good, did you want to include an Acked-by?
Sure:
Acked-by: Jesse Gross
I just didn't
On Wed, Nov 9, 2011 at 9:18 AM, Ansis Atteka wrote:
> On Tue, Nov 8, 2011 at 4:02 PM, Jesse Gross wrote:
>> On Tue, Nov 8, 2011 at 3:11 PM, Ansis Atteka wrote:
>> > - switch (TRANSITION(prev_type, type)) {
>> > - case TRANSITION(OVS_KEY_ATTR_UNSPEC,
>> > OVS_KEY_ATTR_
On Wed, Nov 9, 2011 at 12:43 AM, Justin Pettit wrote:
> On Nov 8, 2011, at 10:56 PM, Jesse Gross wrote:
>
>> I think after this patch we actually do need to update the comment in
>> datapath/flow.h on tos (it talks about DSCP). Also that block of
>> comments in misaligned.
>
> Okay. Updated.
>
>
On Tue, Nov 8, 2011 at 4:02 PM, Jesse Gross wrote:
> On Tue, Nov 8, 2011 at 3:11 PM, Ansis Atteka wrote:
> > The function flow_metadata_from_nlattrs() is very restrictive
> > about the ordering and type of metadata attributes that it receives.
> > This patch will change flow_metadata_from_nlattr
On Wed, Nov 9, 2011 at 12:27 AM, Justin Pettit wrote:
> On Nov 8, 2011, at 8:44 PM, Jesse Gross wrote:
>> I also notice that we print both the
>> individual DSCP/ECN components and the combined ToS in decimal in some
>> places as well, which is a little weird.
>
> Yes, this is because OpenFlow's t
On Nov 9, 2011, at 8:50 AM, Jesse Gross wrote:
>> An incremental is at the end of this message.
>
> Looks good, thanks.
Thanks. If it all looks good, did you want to include an Acked-by?
--Justin
___
dev mailing list
dev@openvswitch.org
http://ope
On Tue, Nov 8, 2011 at 11:56 PM, Justin Pettit wrote:
> On Nov 8, 2011, at 8:12 PM, Jesse Gross wrote:
>
>> On Tue, Nov 8, 2011 at 3:57 PM, Justin Pettit wrote:
>>> diff --git a/datapath/flow.h b/datapath/flow.h
>>> index ba8c66a..f12b11a 100644
>>> --- a/datapath/flow.h
>>> +++ b/datapath/flow.h
On Tue, Nov 8, 2011 at 11:15 PM, Justin Pettit wrote:
> On Nov 8, 2011, at 8:13 PM, Jesse Gross wrote:
>
>> On Tue, Nov 8, 2011 at 4:24 PM, Ben Pfaff wrote:
>>> On Tue, Nov 08, 2011 at 03:57:29PM -0800, Justin Pettit wrote:
This will be useful later when we add support for matching the ECN b
On Tue, Nov 8, 2011 at 11:40 PM, Justin Pettit wrote:
> On Nov 8, 2011, at 5:12 PM, Jesse Gross wrote:
>>> @@ -385,10 +385,10 @@ format_odp_key_attr(const struct nlattr *a, struct ds
>>> *ds)
>>> ...
>>> + ds_put_format(ds,
>>> "ipv6(src=%s,dst=%s,label=0x%"PRIx32",proto=%"PRId8
>>
>> I t
This doesn't fix a visible bug, since there's no epoch in the Open vSwitch
version used in Debian, but some Nicira internal build scripts were
inserting an epoch so it was visible in our builds.
Reported-by: Edwin Chiu
---
AUTHORS |1 +
debian/rules |2 +-
2 files changed, 2 inserti
OK, great, so what are those issues?
On Wed, Nov 09, 2011 at 05:12:13PM +0900, Jari Sundell wrote:
> The attached file shows output from dpctl dump-flows for the working,
> and non-working revisions. I think the mod_dl_dst part might have been
> a red herring, as it seems there's some issues with
On Tue, Nov 08, 2011 at 11:06:21PM -0800, Justin Pettit wrote:
> On Nov 8, 2011, at 4:24 PM, Ben Pfaff wrote:
>
> > I think that these |=s can become =s:
> >
> >> - key->ip.tos_frag |= OVS_FRAG_TYPE_LATER;
> >> + key->ip.frag |= OVS_FRAG_TYPE_LATER;
> >>
> >> -
FROM Desk Of DR PETER WILLIAMS
Dept. International Remittance
Swift ATM Card Payment Center
HSBC BANK LONDON
Dear Beneficiary.
This is to notify you that your over due inheritance funds of US$2.5m has been
programmed to be paid to you through ATM Card Payment.Therefore,you should get
back to
Hello Dear
My name is Lina Michel(female), i saw your mail today and i decided to contact
you. I would like to be your good friend. I will like to know more about
you,learn a lot from you .when i receive your yes answer,i will send you my
picture for you to see me and tell you more about myse
On Nov 8, 2011, at 10:56 PM, Jesse Gross wrote:
> I think after this patch we actually do need to update the comment in
> datapath/flow.h on tos (it talks about DSCP). Also that block of
> comments in misaligned.
Okay. Updated.
> I also discovered that there is ipv4_change_dsfield() function t
On Nov 8, 2011, at 8:44 PM, Jesse Gross wrote:
> On Tue, Nov 8, 2011 at 3:57 PM, Justin Pettit wrote:
>>
>> --- a/lib/odp-util.c
>> +++ b/lib/odp-util.c
>> @@ -370,7 +370,7 @@ format_odp_key_attr(const struct nlattr *a, struct ds
>> *ds)
>> ...
>
> I would use # here as well.
Okay. Changed
The attached file shows output from dpctl dump-flows for the working,
and non-working revisions. I think the mod_dl_dst part might have been
a red herring, as it seems there's some issues with connections
between some services even before a vm is brought up and flows with
mod_dl_dst are inserted.
59 matches
Mail list logo
