On Wed, Nov 9, 2011 at 5:54 PM, Ansis Atteka <aatt...@nicira.com> wrote: > The function flow_metadata_from_nlattrs() is very restrictive > about the ordering and type of metadata attributes that it receives. > This patch will change flow_metadata_from_nlattrs() behavior by > ignoring attributes that it does not understand and allowing them > to be passed in arbitrary order. > > Issue #8167 > > Signed-off-by: Ansis Atteka <aatt...@nicira.com>
Thank you, this looks good to me with one minor nitpick: > diff --git a/datapath/flow.c b/datapath/flow.c > index 2dc87ae..75de5fa 100644 > --- a/datapath/flow.c > +++ b/datapath/flow.c > + if (type <= OVS_KEY_ATTR_MAX && ovs_key_lens[type] != 0) > + { Kernel style is to put the opening brace on the same line. Otherwise: Acked-by: Jesse Gross <je...@nicira.com> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev