On Nov 9, 2011, at 9:17 AM, Jesse Gross wrote: >> If you have a better suggestion, let me know. I'm hoping that we can get >> some sanity in 1.2, and then we can just adopt that convention in the >> userspace. > > Yeah, I remember that conversation. What specifically caught my eye > though was the places (maybe there is only one...) where we print the > full ToS in decimal. For example in flow.c: > > @@ -539,8 +538,7 @@ flow_format(struct ds *ds, const struct flow *flow) > ds_put_format(ds, " proto%"PRIu8 > " tos%"PRIu8 > " ip"IP_FMT"->"IP_FMT, > - flow->nw_proto, > - flow->tos & IP_DSCP_MASK, > + flow->nw_proto, flow->tos, > IP_ARGS(&flow->nw_src), > IP_ARGS(&flow->nw_dst));
Good catch. I've updated flow_format() to print TOS in hex for both IPv4 and IPv6. --Justin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
