On Tue, Nov 8, 2011 at 11:40 PM, Justin Pettit <jpet...@nicira.com> wrote:
> On Nov 8, 2011, at 5:12 PM, Jesse Gross wrote:
>>> @@ -385,10 +385,10 @@ format_odp_key_attr(const struct nlattr *a, struct ds 
>>> *ds)
>>> ...
>>> +        ds_put_format(ds, 
>>> "ipv6(src=%s,dst=%s,label=0x%"PRIx32",proto=%"PRId8
>>
>> I think the more canonical form would be to use # instead of 0x explicitly.
>
>
> That's my preferred form, too.  That file mostly uses "0x", but I went ahead 
> and changed this instance to "#".  We should probably be consistent, 
> regardless.

Oh, I looked at a few and saw that they used # so I assumed that it
was the prevailing style.  Good to move in the right direction at
least, I suppose.

> An incremental is at the end of this message.

Looks good, thanks.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to