On Nov 8, 2011, at 8:12 PM, Jesse Gross wrote:
> On Tue, Nov 8, 2011 at 3:57 PM, Justin Pettit wrote:
>> diff --git a/datapath/flow.h b/datapath/flow.h
>> index ba8c66a..f12b11a 100644
>> --- a/datapath/flow.h
>> +++ b/datapath/flow.h
>> @@ -147,7 +143,7 @@ u64 flow_used_time(unsigned long flow_j
On Nov 8, 2011, at 5:12 PM, Jesse Gross wrote:
> I got some sparse errors:
> /home/jesse/openvswitch/datapath/linux/flow.c:205:40: warning:
> restricted __be32 degrades to integer
> /home/jesse/openvswitch/datapath/linux/flow.c:205:25: warning:
> incorrect type in assignment (different base types)
On Nov 8, 2011, at 4:52 PM, Ben Pfaff wrote:
> On Tue, Nov 08, 2011 at 03:57:32PM -0800, Justin Pettit wrote:
>> Suggested-by: Ben Pfaff
>
> Looks good, thank you.
Thanks for reviewing the series!
--Justin
___
dev mailing list
dev@openvswitch.org
On Nov 8, 2011, at 8:13 PM, Jesse Gross wrote:
> On Tue, Nov 8, 2011 at 4:24 PM, Ben Pfaff wrote:
>> On Tue, Nov 08, 2011 at 03:57:29PM -0800, Justin Pettit wrote:
>>> This will be useful later when we add support for matching the ECN bits
>>> within the TOS field.
>>>
>>> Signed-off-by: Justin
On Nov 8, 2011, at 4:24 PM, Ben Pfaff wrote:
> I think that these |=s can become =s:
>
>> -key->ip.tos_frag |= OVS_FRAG_TYPE_LATER;
>> +key->ip.frag |= OVS_FRAG_TYPE_LATER;
>>
>> -key->ip.tos_frag |= OVS_FRAG_TYPE_FIRST;
>> +
On Tue, Nov 8, 2011 at 8:44 PM, Jesse Gross wrote:
> On Tue, Nov 8, 2011 at 3:57 PM, Justin Pettit wrote:
>> diff --git a/lib/odp-util.c b/lib/odp-util.c
>> index 2853bf7..29abce4 100644
>> --- a/lib/odp-util.c
>> +++ b/lib/odp-util.c
>> @@ -370,7 +370,7 @@ format_odp_key_attr(const struct nlattr
On Tue, Nov 8, 2011 at 3:57 PM, Justin Pettit wrote:
> Add support matching the IPv4 TTL and IPv6 hop limit fields. This
> commit also adds support for modifying the IPv4 TTL. Modifying the IPv6
> hop limit isn't currently supported, since we don't support modifying
> IPv6 headers.
>
> We will l
On Nov 8, 2011, at 4:06 PM, Ben Pfaff wrote:
> On Tue, Nov 08, 2011 at 03:57:28PM -0800, Justin Pettit wrote:
>> +/* The flow label in the IPv6 header.
>> + *
>> + * Prereqs: NXM_OF_ETH_TYPE must match 0x86dd exactly.
>> + *
>> + * Format: 20-bit IPv6 flow label.
>
> In the least-significant 20 b
On Nov 8, 2011, at 4:45 PM, Ben Pfaff wrote:
> On Tue, Nov 08, 2011 at 03:57:30PM -0800, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>
> Does this really add the ability to modify ECN in IPv6:
>
>> @@ -2,6 +2,8 @@ post-v1.3.0
>>
>> - OpenFlow:
>>- A
On Tue, Nov 8, 2011 at 8:12 PM, Jesse Gross wrote:
> On Tue, Nov 8, 2011 at 3:57 PM, Justin Pettit wrote:
>> diff --git a/datapath/flow.h b/datapath/flow.h
>> index ba8c66a..f12b11a 100644
>> --- a/datapath/flow.h
>> +++ b/datapath/flow.h
>> @@ -147,7 +143,7 @@ u64 flow_used_time(unsigned long fl
On Nov 8, 2011, at 8:24 PM, Ben Pfaff wrote:
> On Tue, Nov 08, 2011 at 05:35:20PM -0800, Justin Pettit wrote:
>> When disabling STP on a port that has it enabled on the bridge, STP was
>> not actually being disabled on the port. This commit directly calls the
>> update function in this situation.
On Tue, Nov 8, 2011 at 3:57 PM, Justin Pettit wrote:
> diff --git a/lib/odp-util.c b/lib/odp-util.c
> index 2853bf7..29abce4 100644
> --- a/lib/odp-util.c
> +++ b/lib/odp-util.c
> @@ -370,7 +370,7 @@ format_odp_key_attr(const struct nlattr *a, struct ds *ds)
> case OVS_KEY_ATTR_IPV4:
>
On Tue, Nov 8, 2011 at 8:20 PM, Ben Pfaff wrote:
> On Tue, Nov 08, 2011 at 06:40:51PM -0800, Jesse Gross wrote:
>> On Tue, Nov 8, 2011 at 5:03 PM, Ben Pfaff wrote:
>> > Jesse and I spent some time pondering this face-to-face, so there's a
>> > bunch of discussion that hasn't shown up on the maili
On Tue, Nov 08, 2011 at 05:35:20PM -0800, Justin Pettit wrote:
> When disabling STP on a port that has it enabled on the bridge, STP was
> not actually being disabled on the port. This commit directly calls the
> update function in this situation.
>
> Reported-by: Paul Ingram
Looks good, thank
On Tue, Nov 08, 2011 at 08:13:31PM -0800, Jesse Gross wrote:
> On Tue, Nov 8, 2011 at 4:24 PM, Ben Pfaff wrote:
> > On Tue, Nov 08, 2011 at 03:57:29PM -0800, Justin Pettit wrote:
> > Did you mean to update the comment on 'frag' below?
> >
> >> ??struct sw_flow_key {
> >> ?? ?? ?? struct {
> >> ??
On Tue, Nov 08, 2011 at 06:40:51PM -0800, Jesse Gross wrote:
> On Tue, Nov 8, 2011 at 5:03 PM, Ben Pfaff wrote:
> > Jesse and I spent some time pondering this face-to-face, so there's a
> > bunch of discussion that hasn't shown up on the mailing list.
> >
> > My understanding of what we concluded
On Tue, Nov 8, 2011 at 4:24 PM, Ben Pfaff wrote:
> On Tue, Nov 08, 2011 at 03:57:29PM -0800, Justin Pettit wrote:
>> This will be useful later when we add support for matching the ECN bits
>> within the TOS field.
>>
>> Signed-off-by: Justin Pettit
>
> I think that these |=s can become =s:
There
On Tue, Nov 8, 2011 at 3:57 PM, Justin Pettit wrote:
> diff --git a/datapath/flow.h b/datapath/flow.h
> index ba8c66a..f12b11a 100644
> --- a/datapath/flow.h
> +++ b/datapath/flow.h
> @@ -147,7 +143,7 @@ u64 flow_used_time(unsigned long flow_jiffies);
> * OVS_KEY_ATTR_ETHERNET 12 -- 4
commit 6455100f38e9312346f4d58511595f695d813537 (datapath: Fix
coding style issues) introduced this issue.
Signed-off-by: Pravin B Shelar
---
datapath/dp_sysfs.h|2 +-
datapath/dp_sysfs_if.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/datapath/dp_sysfs.h b/d
On Tue, Nov 8, 2011 at 5:03 PM, Ben Pfaff wrote:
> Jesse and I spent some time pondering this face-to-face, so there's a
> bunch of discussion that hasn't shown up on the mailing list.
>
> My understanding of what we concluded is:
>
> - We will add a new "encap" flow key attribute that cont
When disabling STP on a port that has it enabled on the bridge, STP was
not actually being disabled on the port. This commit directly calls the
update function in this situation.
Reported-by: Paul Ingram
---
ofproto/ofproto-dpif.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff
On Tue, Nov 8, 2011 at 3:57 PM, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
I got some sparse errors:
/home/jesse/openvswitch/datapath/linux/flow.c:205:40: warning:
restricted __be32 degrades to integer
/home/jesse/openvswitch/datapath/linux/flow.c:205:25: warning:
incorrect type in assi
Jesse and I spent some time pondering this face-to-face, so there's a
bunch of discussion that hasn't shown up on the mailing list.
My understanding of what we concluded is:
- We will add a new "encap" flow key attribute that contains
nested attributes. An "encap" is used whene
On Tue, Nov 08, 2011 at 03:57:32PM -0800, Justin Pettit wrote:
> Suggested-by: Ben Pfaff
Looks good, thank you.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Nov 08, 2011 at 03:57:31PM -0800, Justin Pettit wrote:
> Add support matching the IPv4 TTL and IPv6 hop limit fields. This
> commit also adds support for modifying the IPv4 TTL. Modifying the IPv6
> hop limit isn't currently supported, since we don't support modifying
> IPv6 headers.
>
>
On Tue, Nov 08, 2011 at 03:57:30PM -0800, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
Does this really add the ability to modify ECN in IPv6:
> @@ -2,6 +2,8 @@ post-v1.3.0
>
> - OpenFlow:
> - Added ability to match on IPv6 flow label through NXM.
>
UNITED NATIONS in Affilation with the EUROPEAN UNION.
Attention:
We hereby bring to your notice that your Scam Victim's compensation fund
of USD$6000,000.00 is approved and upgraded in your favor and ready to be
release to you within three working days through Central Bank Of Ghana .
You are
On Tue, Nov 08, 2011 at 03:57:29PM -0800, Justin Pettit wrote:
> This will be useful later when we add support for matching the ECN bits
> within the TOS field.
>
> Signed-off-by: Justin Pettit
I think that these |=s can become =s:
> if (offset) {
> - key->ip.t
On Tue, Nov 08, 2011 at 03:57:28PM -0800, Justin Pettit wrote:
> +/* The flow label in the IPv6 header.
> + *
> + * Prereqs: NXM_OF_ETH_TYPE must match 0x86dd exactly.
> + *
> + * Format: 20-bit IPv6 flow label.
In the least-significant 20 bits of the field, right?
> @@ -162,6 +163,7 @@ struct mf
On Tue, Nov 8, 2011 at 3:11 PM, Ansis Atteka wrote:
> The function flow_metadata_from_nlattrs() is very restrictive
> about the ordering and type of metadata attributes that it receives.
> This patch will change flow_metadata_from_nlattrs() behavior by
> ignoring attributes that it does not unders
Suggested-by: Ben Pfaff
---
lib/odp-util.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/odp-util.c b/lib/odp-util.c
index 612cc5c..8f9fa27 100644
--- a/lib/odp-util.c
+++ b/lib/odp-util.c
@@ -369,7 +369,7 @@ format_odp_key_attr(const struct nlattr *a, struct ds
Add support matching the IPv4 TTL and IPv6 hop limit fields. This
commit also adds support for modifying the IPv4 TTL. Modifying the IPv6
hop limit isn't currently supported, since we don't support modifying
IPv6 headers.
We will likely want to change the user-space interface, since basic
matchi
Signed-off-by: Justin Pettit
---
NEWS |2 +
datapath/actions.c| 10 +--
datapath/datapath.c |4 ---
datapath/flow.c | 13 +++--
include/openflow/nicira-ext.h |9 ++
lib/classifier.c | 15 ++
This will be useful later when we add support for matching the ECN bits
within the TOS field.
Signed-off-by: Justin Pettit
---
datapath/datapath.c |6 +--
datapath/flow.c | 73 +-
datapath/flow.h | 10 ++
lib/classifier.
Signed-off-by: Justin Pettit
---
NEWS |3 ++-
datapath/flow.c |7 +--
datapath/flow.h |7 ---
include/linux/openvswitch.h |1 +
include/openflow/nicira-ext.h |9 +
lib/classifier.c | 16 +
Thanks,
Pushed to master.
On Tue, Nov 8, 2011 at 3:22 PM, Jesse Gross wrote:
> On Tue, Nov 8, 2011 at 2:52 PM, Pravin B Shelar wrote:
>> Signed-off-by: Pravin B Shelar
>>
>> Bug #7772
>
> Thanks.
> Acked-by: Jesse Gross
>
___
dev mailing list
dev@ope
On Tue, Nov 8, 2011 at 2:52 PM, Pravin B Shelar wrote:
> Signed-off-by: Pravin B Shelar
>
> Bug #7772
Thanks.
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
The function flow_metadata_from_nlattrs() is very restrictive
about the ordering and type of metadata attributes that it receives.
This patch will change flow_metadata_from_nlattrs() behavior by
ignoring attributes that it does not understand and allowing them
to be passed in arbitrary order.
Issu
Signed-off-by: Pravin B Shelar
Bug #7772
---
datapath/brcompat.c |1 +
datapath/datapath.c |4 ++--
datapath/linux/compat/include/linux/skbuff.h |7 +++
datapath/tunnel.c|2 +-
4 files changed, 11 i
On Nov 7, 2011, at 12:59 PM, Ben Pfaff wrote:
> Again, do we really need a new action just to set this field, since it
> can be done with NXAST_REG_LOAD?
As with ECN, I've switched to using NXAST_REG_LOAD.
> Er, well I guess it can't be done with NXAST_REG_LOAD. Why not?
Just an oversight.
>
On Nov 7, 2011, at 12:50 PM, Ben Pfaff wrote:
> On Mon, Nov 07, 2011 at 10:33:09AM -0800, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>
> In nicira-ext.h, is there value in adding NXAST_SET_NW_ECN given that
> it could be set with NXAST_REG_LOAD without adding a new action?
Good point.
Otherwise we build it in the build directory by default, which breaks the
Debian package build (unless we're working from a "make dist" created
tarball since that has ovs-vswitchd.conf.db.5 in the srcdir as part of
the distribution).
Reported-by: Ansis Atteka
---
vswitchd/automake.mk |2 +-
On Tue, Nov 08, 2011 at 11:50:42AM -0800, Justin Pettit wrote:
> On Nov 7, 2011, at 12:34 PM, Ben Pfaff wrote:
>
> > kernel
> > --
> >
> > Do you plan to use the top 6 bits of ip.frag for something later on?
> > If not, I think we can drop all the bitwise manipulation that assumes
> > that so
I forgot to add that I'm going to resend out the series, since your suggestions
had a large ripple effect.
--Justin
On Nov 8, 2011, at 11:50 AM, Justin Pettit wrote:
> On Nov 7, 2011, at 12:34 PM, Ben Pfaff wrote:
>
>> kernel
>> --
>>
>> Do you plan to use the top 6 bits of ip.frag for s
On Nov 7, 2011, at 12:34 PM, Ben Pfaff wrote:
> kernel
> --
>
> Do you plan to use the top 6 bits of ip.frag for something later on?
> If not, I think we can drop all the bitwise manipulation that assumes
> that something might be in those bits, get rid of OVS_FRAG_TYPE_MASK,
> etc.
My think
Thanks,
Pushed to master.
On Tue, Nov 8, 2011 at 11:11 AM, Jesse Gross wrote:
> On Tue, Nov 8, 2011 at 10:53 AM, Pravin B Shelar wrote:
>> Signed-off-by: Pravin B Shelar
>> ---
>> datapath/vport.c | 14 --
>> 1 files changed, 8 insertions(+), 6 deletions(-)
>
> Acked-by: Jesse Gr
On Tue, Nov 8, 2011 at 10:53 AM, Pravin B Shelar wrote:
> Signed-off-by: Pravin B Shelar
> ---
> datapath/vport.c | 14 --
> 1 files changed, 8 insertions(+), 6 deletions(-)
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
On Mon, Nov 7, 2011 at 4:08 PM, Ben Pfaff wrote:
> On Mon, Nov 07, 2011 at 03:54:40PM -0800, Jesse Gross wrote:
>> On Mon, Nov 7, 2011 at 1:41 PM, Ben Pfaff wrote:
>> > On Mon, Nov 07, 2011 at 11:18:04AM -0800, Jesse Gross wrote:
>> >> On Mon, Nov 7, 2011 at 9:24 AM, Ben Pfaff wrote:
>> >> > On
Signed-off-by: Pravin B Shelar
---
datapath/vport.c | 14 --
1 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/datapath/vport.c b/datapath/vport.c
index 6fe6042..a6b686c 100644
--- a/datapath/vport.c
+++ b/datapath/vport.c
@@ -459,16 +459,18 @@ void vport_receive(struct
49 matches
Mail list logo
