On Tue, Nov 08, 2011 at 03:57:30PM -0800, Justin Pettit wrote:
> Signed-off-by: Justin Pettit <[email protected]>
Does this really add the ability to modify ECN in IPv6:
> @@ -2,6 +2,8 @@ post-v1.3.0
> ------------------------
> - OpenFlow:
> - Added ability to match on IPv6 flow label through NXM.
> + - Added ability to match on ECN bits in IPv4 and IPv6 through NXM.
> + - Added ability to modify ECN bits in IPv4 and IPv6.
> - ovs-appctl:
> - New "fdb/flush" command to flush bridge's MAC learning table.
>
I think that you could just update MFF_IP_TOS -> MFF_IP_DSCP here
instead of deleting the comment:
> @@ -642,8 +654,7 @@ mf_are_prereqs_ok(const struct mf_field *mf, const struct
> flow *flow)
> * all. For example, the MFF_VLAN_TCI field will never have a nonzero value
> * without the VLAN_CFI bit being set, but we can't reject those values
> because
> * it is still legitimate to test just for those bits (see the documentation
> - * for NXM_OF_VLAN_TCI in nicira-ext.h). On the other hand, there is never a
> - * reason to set the low bit of MFF_IP_TOS to 1, so we reject that. */
> + * for NXM_OF_VLAN_TCI in nicira-ext.h). */
> bool
> mf_is_value_valid(const struct mf_field *mf, const union mf_value *value)
> {
I don't have other comments.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
