On Nov 7, 2011, at 12:59 PM, Ben Pfaff wrote: > Again, do we really need a new action just to set this field, since it > can be done with NXAST_REG_LOAD?
As with ECN, I've switched to using NXAST_REG_LOAD. > Er, well I guess it can't be done with NXAST_REG_LOAD. Why not? Just an oversight. > In format_odp_key_attr() I'd expect to use PRIu8 for a uint8_t. > (I see that nw_proto uses PRId8 too but that looks to me like a bug.) Okay. I have a separate patch to change nw_proto, too. > I don't think we need a new MAY_* constant in ofputil_normalize_rule() > since TTL always appears along with tos and frag. I've made it dependent on the new MAY_IPVx enum member introduced in the patch to break out frags from the TOS field. I'll send out the revised series shortly. --Justin _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
