On Tue, Nov 8, 2011 at 3:57 PM, Justin Pettit <jpet...@nicira.com> wrote:
> diff --git a/datapath/flow.h b/datapath/flow.h
> index ba8c66a..f12b11a 100644
> --- a/datapath/flow.h
> +++ b/datapath/flow.h
> @@ -147,7 +143,7 @@ u64 flow_used_time(unsigned long flow_jiffies);
>  *  OVS_KEY_ATTR_ETHERNET     12    --     4     16
>  *  OVS_KEY_ATTR_8021Q         4    --     4      8
>  *  OVS_KEY_ATTR_ETHERTYPE     2     2     4      8
> - *  OVS_KEY_ATTR_IPV6         38     2     4     44
> + *  OVS_KEY_ATTR_IPV6         39     1     4     44

I think this is just a mistake since this patch has nothing IPv6
specific in it but this list is for the userspace interface, which
this doesn't change.

In userspace there's a fair amount of masking with IP_DSCP_MASK even
though it is unnecessary because the userspace flow shouldn't contain
the ECN bits.  I'm guessing that it all gets resolved (or becomes
necessary) in the patch where ECN support is added, so it doesn't
really matter.

I don't have any further comments beyond Ben's
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to