On Tue, Nov 8, 2011 at 4:24 PM, Ben Pfaff <b...@nicira.com> wrote:
> On Tue, Nov 08, 2011 at 03:57:29PM -0800, Justin Pettit wrote:
>> This will be useful later when we add support for matching the ECN bits
>> within the TOS field.
>>
>> Signed-off-by: Justin Pettit <jpet...@nicira.com>
>
> I think that these |=s can become =s:
There's some instances of this in the userspace flow_extract() as well.
> Did you mean to update the comment on 'frag' below?
>
>> struct sw_flow_key {
>> struct {
>> __be64 tun_id; /* Encapsulating tunnel ID. */
>> @@ -48,8 +44,8 @@ struct sw_flow_key {
>> } eth;
>> struct {
>> u8 proto; /* IP protocol or lower 8 bits of ARP
>> opcode. */
>> - u8 tos_frag; /* IP ToS DSCP in high 6 bits,
>> - * OVS_FRAG_TYPE_* in low 2 bits. */
>> + u8 tos; /* IP ToS DSCP in high 6 bits. */
>> + u8 frag; /* OVS_FRAG_TYPE_* in low 2 bits. */
>> } ip;
>> union {
>> struct {
I think the comments here are still accurate.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
