pkarashchenko commented on code in PR #5962:
URL: https://github.com/apache/incubator-nuttx/pull/5962#discussion_r841283611
##
arch/risc-v/src/common/riscv_percpu.h:
##
@@ -38,10 +38,11 @@
* Pre-processor Definitions
**
xiaoxiang781216 commented on code in PR #5962:
URL: https://github.com/apache/incubator-nuttx/pull/5962#discussion_r841350940
##
arch/risc-v/src/common/riscv_percpu.h:
##
@@ -38,10 +38,11 @@
* Pre-processor Definitions
davids5 opened a new pull request #1: imxrt fixes
URL: https://github.com/apache/incubator-nuttx/pull/1
In bringing up the NXP RDDRONE-FMURT6 these issues were discovered and fixed.
- False detection
- No Detection I2C
- System lock up hang due to interrupt storm
Pr
Apache9 commented on issue #1: imxrt fixes
URL: https://github.com/apache/incubator-nuttx/pull/1#issuecomment-568188369
So we will merge PR to master branch directly? No dev branch?
This is an automated message from the Apach
davids5 commented on issue #1: imxrt fixes
URL: https://github.com/apache/incubator-nuttx/pull/1#issuecomment-568198479
> So we will merge PR to master branch directly? No dev branch?
@Apache9
As it stands master has been dev. If we had release branches then master
could still
patacongo commented on issue #1: imxrt fixes
URL: https://github.com/apache/incubator-nuttx/pull/1#issuecomment-568266571
'master' has never been 'dev' in this repository. You are thinking of a
different repository that was managed by a single person.
davids5 commented on issue #1: imxrt fixes
URL: https://github.com/apache/incubator-nuttx/pull/1#issuecomment-568267090
> 'master' has never been 'dev' in this repository. You are thinking of a
different repository that was managed by a single person.
Yes - I am so glad you are so e
patacongo commented on issue #1: imxrt fixes
URL: https://github.com/apache/incubator-nuttx/pull/1#issuecomment-568268123
With a single committer, you can greatly simplify things since it is the
sole reponsibility of that single committed to go from the patch to PR to its
clean incorporat
davids5 opened a new pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2
@patacongo -
This will get us off the ground on the formatting tool we can get in to the
workfow.
We are going to need your expertise on the the makefile
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725335
##
File path: tools/nxstyle.c
##
@@ -50,6 +50,45 @@
#define LINE_SIZE512
+#define FATAL(m) message(F
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725352
##
File path: tools/nxstyle.c
##
@@ -50,6 +50,45 @@
#define LINE_SIZE512
+#define FATAL(m) message(F
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725366
##
File path: tools/nxstyle.c
##
@@ -50,6 +50,45 @@
#define LINE_SIZE512
+#define FATAL(m) message(F
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725385
##
File path: tools/nxstyle.c
##
@@ -61,6 +100,34 @@ static void show_usage(char *progname, int exitcode)
exit(e
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725443
##
File path: tools/nxstyle.c
##
@@ -50,6 +50,45 @@
#define LINE_SIZE512
+#define FATAL(m) message(FATA
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725416
##
File path: tools/nxstyle.c
##
@@ -50,6 +50,45 @@
#define LINE_SIZE512
+#define FATAL(m) message(FATA
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725475
##
File path: tools/nxstyle.c
##
@@ -477,7 +543,7 @@ int main(int argc, char **argv, char **envp)
(strcm
Ouss4 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725448
##
File path: tools/nxstyle.c
##
@@ -50,6 +50,45 @@
#define LINE_SIZE512
+#define FATAL(m) message(FATAL,
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725490
##
File path: tools/nxstyle.c
##
@@ -477,7 +543,7 @@ int main(int argc, char **argv, char **envp)
(strcm
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725573
##
File path: tools/Makefile.unix
##
@@ -192,11 +192,18 @@ NUTTXNAME = nuttx
BIN = $(NUTTXNAME)$(EXEEXT)
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725585
##
File path: tools/nxstyle.c
##
@@ -477,7 +543,7 @@ int main(int argc, char **argv, char **envp)
(strcmp(l
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725573
##
File path: tools/Makefile.unix
##
@@ -192,11 +192,18 @@ NUTTXNAME = nuttx
BIN = $(NUTTXNAME)$(EXEEXT)
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725633
##
File path: tools/Makefile.unix
##
@@ -192,11 +192,18 @@ NUTTXNAME = nuttx
BIN = $(NUTTXNAME)$(EXEEXT)
all
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725723
##
File path: tools/nxstyle.c
##
@@ -171,20 +238,21 @@ int main(int argc, char **argv, char **envp)
}
else
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725817
##
File path: tools/nxstyle.c
##
@@ -50,6 +50,45 @@
#define LINE_SIZE512
+#define FATAL(m) message(FATA
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725490
##
File path: tools/nxstyle.c
##
@@ -477,7 +543,7 @@ int main(int argc, char **argv, char **envp)
(strcm
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725833
##
File path: tools/nxstyle.c
##
@@ -50,6 +50,45 @@
#define LINE_SIZE512
+#define FATAL(m) message(FATA
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360726015
##
File path: tools/nxstyle.c
##
@@ -50,6 +50,45 @@
#define LINE_SIZE512
+#define FATAL(m) message(F
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725880
##
File path: tools/nxstyle.c
##
@@ -50,6 +50,45 @@
#define LINE_SIZE512
+#define FATAL(m) message(FATA
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725846
##
File path: tools/nxstyle.c
##
@@ -50,6 +50,45 @@
#define LINE_SIZE512
+#define FATAL(m) message(FATA
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725908
##
File path: tools/nxstyle.c
##
@@ -61,6 +100,34 @@ static void show_usage(char *progname, int exitcode)
exit(exit
Ouss4 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360726048
##
File path: tools/nxstyle.c
##
@@ -50,6 +50,45 @@
#define LINE_SIZE512
+#define FATAL(m) message(FATAL,
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725892
##
File path: tools/nxstyle.c
##
@@ -50,6 +50,45 @@
#define LINE_SIZE512
+#define FATAL(m) message(FATA
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725965
##
File path: tools/nxstyle.c
##
@@ -477,7 +543,7 @@ int main(int argc, char **argv, char **envp)
(strcmp(l
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360726228
##
File path: tools/nxstyle.c
##
@@ -50,6 +50,45 @@
#define LINE_SIZE512
+#define FATAL(m) message(F
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360726498
##
File path: tools/Makefile.unix
##
@@ -192,11 +192,18 @@ NUTTXNAME = nuttx
BIN = $(NUTTXNAME)$(EXEEXT)
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360726623
##
File path: tools/Makefile.unix
##
@@ -697,3 +704,8 @@ apps_distclean:
ifneq ($(APPDIR),)
$(Q) $(MAKE) -
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360726623
##
File path: tools/Makefile.unix
##
@@ -697,3 +704,8 @@ apps_distclean:
ifneq ($(APPDIR),)
$(Q) $(MAKE) -
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360727266
##
File path: tools/Makefile.unix
##
@@ -697,3 +704,8 @@ apps_distclean:
ifneq ($(APPDIR),)
$(Q) $(MAKE) -
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360727266
##
File path: tools/Makefile.unix
##
@@ -697,3 +704,8 @@ apps_distclean:
ifneq ($(APPDIR),)
$(Q) $(MAKE) -
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360727425
##
File path: tools/check_code_style.sh
##
@@ -0,0 +1,33 @@
+#!/usr/bin/env bash
+
+if [ -z "$1" ]; then
+ FI
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360727398
##
File path: tools/check_code_style.sh
##
@@ -0,0 +1,33 @@
+#!/usr/bin/env bash
+
+if [ -z "$1" ]; then
+ FI
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360727667
##
File path: tools/Makefile.unix
##
@@ -192,11 +192,18 @@ NUTTXNAME = nuttx
BIN = $(NUTTXNAME)$(EXEEXT)
all
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360727717
##
File path: tools/Makefile.unix
##
@@ -697,3 +704,8 @@ apps_distclean:
ifneq ($(APPDIR),)
$(Q) $(MAKE) -C "
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360727720
##
File path: tools/check_code_style.sh
##
@@ -0,0 +1,33 @@
+#!/usr/bin/env bash
+
+if [ -z "$1" ]; then
+ FILES
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360727718
##
File path: tools/check_code_style.sh
##
@@ -0,0 +1,33 @@
+#!/usr/bin/env bash
+
+if [ -z "$1" ]; then
+ FILES
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360728147
##
File path: tools/Makefile.unix
##
@@ -192,11 +192,18 @@ NUTTXNAME = nuttx
BIN = $(NUTTXNAME)$(EXEEXT)
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360728147
##
File path: tools/Makefile.unix
##
@@ -192,11 +192,18 @@ NUTTXNAME = nuttx
BIN = $(NUTTXNAME)$(EXEEXT)
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360728415
##
File path: tools/Makefile.unix
##
@@ -192,11 +192,18 @@ NUTTXNAME = nuttx
BIN = $(NUTTXNAME)$(EXEEXT)
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360728732
##
File path: tools/Makefile.unix
##
@@ -697,3 +704,8 @@ apps_distclean:
ifneq ($(APPDIR),)
$(Q) $(MAKE) -
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360726623
##
File path: tools/Makefile.unix
##
@@ -697,3 +704,8 @@ apps_distclean:
ifneq ($(APPDIR),)
$(Q) $(MAKE) -
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360728789
##
File path: tools/Makefile.unix
##
@@ -697,3 +704,8 @@ apps_distclean:
ifneq ($(APPDIR),)
$(Q) $(MAKE) -
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360728886
##
File path: tools/nxstyle.c
##
@@ -171,20 +238,21 @@ int main(int argc, char **argv, char **envp)
}
else
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360729083
##
File path: tools/nxstyle.c
##
@@ -140,7 +207,7 @@ int main(int argc, char **argv, char **envp)
maxline = 7
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360730399
##
File path: tools/Makefile.unix
##
@@ -697,3 +704,8 @@ apps_distclean:
ifneq ($(APPDIR),)
$(Q) $(MAKE) -
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360730444
##
File path: tools/Makefile.unix
##
@@ -697,3 +704,8 @@ apps_distclean:
ifneq ($(APPDIR),)
$(Q) $(MAKE) -
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360730444
##
File path: tools/Makefile.unix
##
@@ -697,3 +704,8 @@ apps_distclean:
ifneq ($(APPDIR),)
$(Q) $(MAKE) -
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360732967
##
File path: tools/check_code_style.sh
##
@@ -0,0 +1,33 @@
+#!/usr/bin/env bash
+
Review comment:
Missing li
patacongo closed pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
patacongo commented on issue #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#issuecomment-568309238
I added Xiao Xiang to the reviewers. We need to have a lot of concurrence
here since this PR implements a portion of the workflow while there no workf
patacongo edited a comment on issue #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#issuecomment-568309238
I added Xiao Xiang to the reviewers. We need to have a lot of concurrence
here since this PR implements a portion of the workflow while there n
patacongo commented on issue #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#issuecomment-568317600
What is this? How did I do this? What does closed mean? What was closed?
This is an
patacongo edited a comment on issue #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#issuecomment-568317600
What is this? How did I do this? What does closed mean? Is that like
declined? What was closed?
Do I need to unclose something?
-
patacongo edited a comment on issue #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#issuecomment-568317600
What is this? How did I do this? What does closed mean? Is that like
declined? What was closed?
Do I need to unclose something?
...
davids5 opened a new pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2
@patacongo -
This will get us off the ground on the formatting tool we can get in to the
workfow.
We are going to need your expertise on the the makefile
Ouss4 commented on issue #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#issuecomment-568318466
Yes close without merging is like decline.
It's still closed btw.
This is an automated
patacongo commented on issue #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#issuecomment-568319546
@Ouss4 Thanks! It said it was open in my page. I must have hit close
again? It is kind of goosey but I attribute that to the fact the I am a github
Ouss4 commented on issue #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#issuecomment-568320150
> I must have hit close again?
I don't know, it never said re-opened, eventhough it should re-open the
moment you comment.
btashton commented on issue #1: imxrt fixes
URL: https://github.com/apache/incubator-nuttx/pull/1#issuecomment-568330736
@davids5 This touches some of the same IO stuff that I have been working on
on the imxrt platform, some of the changes are style. Did you make these
changes via one of
btashton commented on issue #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#issuecomment-568350703
@xiaoxiang781216 You can create a script that you recommend is run as
pre-commit, but the actual hooks are outside of the git working directory, so
it
xiaoxiang781216 commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360783003
##
File path: tools/check_code_style.sh
##
@@ -0,0 +1,33 @@
+#!/usr/bin/env bash
+
+if [ -z "$1" ]; then
+
xiaoxiang781216 commented on issue #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#issuecomment-568378194
@btashton @davids5 What I mean here is that we don't need modify Makefile,
is engouh to add a script invoke nxstyle(maybe build it too) to check
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360791455
##
File path: tools/check_code_style.sh
##
@@ -0,0 +1,33 @@
+#!/usr/bin/env bash
+
+if [ -z "$1" ]; then
+ FILES
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360794087
##
File path: tools/check_code_style.sh
##
@@ -0,0 +1,33 @@
+#!/usr/bin/env bash
+
+if [ -z "$1" ]; then
+ FILES
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360798664
##
File path: tools/Makefile.unix
##
@@ -697,3 +704,8 @@ apps_distclean:
ifneq ($(APPDIR),)
$(Q) $(MAKE) -C "
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360803384
##
File path: tools/check_code_style.sh
##
@@ -0,0 +1,33 @@
+#!/usr/bin/env bash
+
Review comment:
I was looking
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360728789
##
File path: tools/Makefile.unix
##
@@ -697,3 +704,8 @@ apps_distclean:
ifneq ($(APPDIR),)
$(Q) $(MAKE) -
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360804008
##
File path: tools/Makefile.unix
##
@@ -697,3 +704,8 @@ apps_distclean:
ifneq ($(APPDIR),)
$(Q) $(MAKE) -C "
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360804370
##
File path: tools/nxstyle.c
##
@@ -140,7 +207,7 @@ int main(int argc, char **argv, char **envp)
maxline = 78;
davids5 commented on issue #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#issuecomment-568402453
> I added Xiao Xiang to the reviewers. We need to have a lot of concurrence
here since this PR implements a portion of the workflow while there no workfl
davids5 commented on issue #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#issuecomment-568445894
> Maybe we can use git pre-commit hook to ensure anyone run nxsytle before
commit to his/her local working branch:
> https://eing.github.io/technology
davids5 commented on issue #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#issuecomment-568446656
Oh I should also mention that the this was from before I added the class of
error and treated long lines as warnings in H files.
```
exec < /de
davids5 commented on issue #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#issuecomment-568456453
> @btashton @davids5 What I mean here is that we don't need modify Makefile,
is engouh to add a script invoke nxstyle(maybe build it too) to check the st
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360866861
##
File path: tools/Makefile.unix
##
@@ -697,3 +704,8 @@ apps_distclean:
ifneq ($(APPDIR),)
$(Q) $(MAKE) -C "
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360730399
##
File path: tools/Makefile.unix
##
@@ -697,3 +704,8 @@ apps_distclean:
ifneq ($(APPDIR),)
$(Q) $(MAKE) -
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360868178
##
File path: tools/Makefile.unix
##
@@ -697,3 +704,8 @@ apps_distclean:
ifneq ($(APPDIR),)
$(Q) $(MAKE) -
jarivanewijk commented on issue #1: imxrt fixes
URL: https://github.com/apache/incubator-nuttx/pull/1#issuecomment-568463453
Thank you for your work, @davids5!
> We should warn all the NXP IMXRT and I think NXP S32K users the code will
hang the OS.
A lot of the peripheral co
jarivanewijk edited a comment on issue #1: imxrt fixes
URL: https://github.com/apache/incubator-nuttx/pull/1#issuecomment-568463453
Thank you for your work, @davids5!
> We should warn all the NXP IMXRT and I think NXP S32K users the code will
hang the OS.
A lot of the periph
jarivanewijk edited a comment on issue #1: imxrt fixes
URL: https://github.com/apache/incubator-nuttx/pull/1#issuecomment-568463453
Thank you for your work, @davids5!
> We should warn all the NXP IMXRT and I think NXP S32K users the code will
hang the OS.
A lot of the periph
davids5 commented on issue #1: imxrt fixes
URL: https://github.com/apache/incubator-nuttx/pull/1#issuecomment-568469970
> Thank you for your work, @davids5!
>
> > We should warn all the NXP IMXRT and I think NXP S32K users the code
will hang the OS.
>
> A lot of the periphera
davids5 commented on issue #1: imxrt fixes
URL: https://github.com/apache/incubator-nuttx/pull/1#issuecomment-568473865
@btashton
> @davids5 This touches some of the same IO stuff that I have been working
on on the imxrt platform, some of the changes are style. Did you make these
davids5 edited a comment on issue #1: imxrt fixes
URL: https://github.com/apache/incubator-nuttx/pull/1#issuecomment-568473865
@btashton
> @davids5 This touches some of the same IO stuff that I have been working
on on the imxrt platform, some of the changes are style. Did you make
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360886136
##
File path: tools/check_code_style.sh
##
@@ -0,0 +1,33 @@
+#!/usr/bin/env bash
+
+if [ -z "$1" ]; then
+ FILES
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360886392
##
File path: tools/check_code_style.sh
##
@@ -0,0 +1,33 @@
+#!/usr/bin/env bash
+
+if [ -z "$1" ]; then
+ FILES
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360886535
##
File path: tools/Makefile.unix
##
@@ -697,3 +704,8 @@ apps_distclean:
ifneq ($(APPDIR),)
$(Q) $(MAKE) -C "
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360887055
##
File path: tools/Makefile.unix
##
@@ -324,6 +324,14 @@ tools/cnvwindeps$(HOSTEXEEXT):
# $(Q) echo "No .con
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360887345
##
File path: tools/check_code_style.sh
##
@@ -0,0 +1,33 @@
+#!/usr/bin/env bash
+
+if [ -z "$1" ]; then
+ FI
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360887522
##
File path: tools/Makefile.unix
##
@@ -324,6 +324,14 @@ tools/cnvwindeps$(HOSTEXEEXT):
# $(Q) echo "No .config
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360889472
##
File path: tools/Makefile.unix
##
@@ -324,6 +324,14 @@ tools/cnvwindeps$(HOSTEXEEXT):
# $(Q) echo "No .config
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360898824
##
File path: README.txt
##
@@ -1368,6 +1368,15 @@ Build Targets and Options
Removes derived object files, arc
xiaoxiang781216 commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360904297
##
File path: tools/Makefile.unix
##
@@ -324,6 +324,14 @@ tools/cnvwindeps$(HOSTEXEEXT):
# $(Q) echo "N
1 - 100 of 588 matches
Mail list logo
