pkarashchenko commented on code in PR #5962: URL: https://github.com/apache/incubator-nuttx/pull/5962#discussion_r841283611
########## arch/risc-v/src/common/riscv_percpu.h: ########## @@ -38,10 +38,11 @@ * Pre-processor Definitions ****************************************************************************/ -#ifdef __ASSEMBLY__ -#define SCRATCH_HARTID_OFFSET (0 * INT_REG_SIZE) -#else -#define SCRATCH_HARTID_OFFSET offsetof(riscv_percpu_s, hartid) +#define RISCV_PERCPU_HARTID_OFFSET (0 * INT_REG_SIZE) + +#ifndef __ASSEMBLY__ +static_assert(RISCV_PERCPU_HARTID_OFFSET == offsetof(riscv_percpu_s, hartid), Review Comment: I think we need to move static assert to C file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
