davids5 commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360791455
########## File path: tools/check_code_style.sh ########## @@ -0,0 +1,33 @@ +#!/usr/bin/env bash + +if [ -z "$1" ]; then + FILES=$(git diff master --name-only); Review comment: @xiaoxiang781216 - Right! If you read [here](https://github.com/apache/incubator-nuttx/pull/2#issue-356115637) I asked for help on the tooling. In the absence of a workflow I was assuming a best practices "upstream submission" workflow It assumes the dev has to checkout "upstream master". Then branches it to master-pr-xxxxx. Then cherry picks their fork's commits to it. At that point the diff is the delta of dev/master-pr-xxxxx to upstream/master and this is checking for that. I think this mimic `git format-patch master` is that not how you submit? How do you want this to work (what git commands do you use)? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
