davids5 commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360803384
########## File path: tools/check_code_style.sh ########## @@ -0,0 +1,33 @@ +#!/usr/bin/env bash + Review comment: I was looking at this as in incremental steps with reusable pieces that we are free to evolve. The real value add in this PR is the ability to fix in ones editor the CS violations. NuttX has no complete CS solution. It is impossible to enforce a CS without tools that work 100% and is not go-no-go. for CI and pr-commit hooks. We should not expect professional developers and new members of the community to have to read 10 emails on how each one of the current tools do not work and have them understand that the indent.sh will destroy a formatted file. What will help is a proper tool like Astyle, Uncurstify, clang-format that can detect and FIX the code allong with a few gold standard files (h,c,Kconfig) to validate it with. At this point. I think there are there options. 1. We fix the tooling with all your suggestions. 2. We remove the tooling commit (I keep them separate on purpose) until we have the work flow nailed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
