Re: [VOTE] KIP-951: Leader discovery optimisations for the client

The KIP LGTM. Thanks for the design. I am looking forward to the implementation. +1 (binding). Thanks! -- -José

Re: [DISCUSS] Apache Kafka 3.4.1 release

Hey Luke, Thanks for working on the release for 3.4.1. I was working on some cherry picks and I noticed that branch 3.4 doesn't contain the commit/tag for 3.4.1. I think we are supposed to merge the tag back to the 3.4 branch. E.g.: > Merge the last version change / rc tag into the release branch

Re: Unable to start the Kafka with Kraft in Windows 11

Thanks for bringing this to my attention. I agree that it should be a blocker. On Wed, Sep 6, 2023 at 9:41 AM Greg Harris wrote: > > Hi Ziming, > > Thanks for finding that! I've mentioned that in the 3.6.0 release > thread as a potential blocker since this appears to have a pretty > substantial i

Re: Apache Kafka 3.6.0 release

Hi Satish, On Wed, Sep 6, 2023 at 4:58 PM Satish Duggana wrote: > > Hi Greg, > It seems https://issues.apache.org/jira/browse/KAFKA-14273 has been > there in 3.5.x too. I also agree that it should be a blocker for 3.6.0. It should have been a blocker for those previous releases. I didn't fix it

Re: [kafka-clients] [VOTE] 3.6.0 RC1

On Sat, Sep 23, 2023 at 3:08 AM Luke Chen wrote: > > Hi Satish, > > I found the current KRaft implementation will have "split brain" issue when > network partition happens, which will cause inconsistent metadata returned > from the controller. > Filed KAFKA-15489

Re: UncleanLeaderElectionsPerSec metric and Raft

Hi Neil, You are correct. I don't think we have implemented the unclean election configuration. The kafka-leader-election CLI works with KRaft. Have you looked at that option for performing unclean leader elections with the CLI? Does it meet your requirements? In general using the unclean leader

Re: [DISCUSS] Road to Kafka 4.0

Hi all, If we do a 3.8 release before 4.0 and we implement KIP-853 in 3.8, the user will be able to migrate to a KRaft cluster that supports dynamically changing the set of voters and has better support for disk failures. What are the disadvantages of adding the 3.8 release before 4.0? This would

Re: [VOTE] KIP-1001; CurrentControllerId Metric

LGTM. +1 binding. On Mon, Nov 20, 2023 at 1:48 PM Jason Gustafson wrote: > > The KIP makes sense. +1 > > On Mon, Nov 20, 2023 at 12:37 PM David Arthur > wrote: > > > Thanks Colin, > > > > +1 from me > > > > -David > > > > On Tue, Nov 14, 2023 at 3:53 PM Colin McCabe wrote: > > > > > Hi all, > >

Re: [VOTE] KIP-896: Remove old client protocol API versions in Kafka 4.0

Thanks. LGTM. +1. On Tue, Nov 21, 2023 at 2:54 PM Jun Rao wrote: > > Hi, Ismael, > > Thanks for the KIP. +1 > > It would be useful to clarify in the KIP that the new metric and new > request log attribute will be added in Apache 3.7. > > Jun > > On Tue, Nov 21, 2023 at 1:57 PM Colin McCabe wrote

Re: [DISCUSS] KIP-853: KRaft Voters Change

On Mon, Nov 27, 2023 at 2:32 AM Josep Prat wrote: > I wanted to revive this thread and see if there is anything preventing it to > be voted on. Happy to help unblocking anything that might be holding this > back. Hi Josep, Thanks for reviving the thread. I need to make some changes to the KIP.

Re: [DISCUSS] KIP-996: Pre-Vote

Hi Alyssa On Mon, Nov 27, 2023 at 1:40 PM Jason Gustafson wrote: > 2. Do you think the pretend epoch bump is necessary? Would it be simpler to > change the prevote acceptance check to assert a greater than or equal epoch? I agree with Jason it would be better if all of the requests always sent t

Re: [VOTE] KIP-909: DNS Resolution Fallures Should Not Fail the Client

25, 2023 at 8:52 PM Philip Nee wrote: > > > > > > > Thanks for the vote. We've decided to make a minor change to the > > default > > > > timeout from 5min to 2min. > > > > > > > > On Tue, Apr 25, 2023 at 11:42 AM David Jacot >

Re: [DISCUSS] Apache Kafka 3.8.0 release

Hi Josep, See my comments below. On Wed, May 29, 2024 at 10:52 AM Josep Prat wrote: > So I would propose to leave the deadlines as they are and manually cherry > pick the commits related to KIP-853 and KIP-966. Your proposal sounds good to me. I suspect that will be doing feature development fo

Re: [DISCUSS] Apache Kafka 3.8.0 release

Hi Josep, See my comment below. On Wed, Jun 12, 2024 at 1:17 PM Josep Prat wrote: > How long do you think it will take to bring KIP-853 to completion? We are still missing a few issues/jiras that need to get implemented for the feature to be usable. I would say a few more weeks. May be early Ju

Re: [DISCUSS] Apache Kafka 3.8.0 release

n > > > >> > > the 3.9 > > > >> > > > > > > release. > > > >> > > > > > > > > > >> > > > > > > What are your thoughts? > > > >> > > > > &

Re: [DISCUSS] Apache Kafka 3.9.0 release

+1 for me. Thanks Colin for volunteering to be the release manager. On Mon, Jun 17, 2024 at 4:15 PM Ismael Juma wrote: > > Hi all, > > I think we should actually look at the target dates vs just looking at the > release length. 3.9 is an August release. I suggest we aim for a November > release f

Re: [DISCUSS] Apache Kafka 3.9.0 release

Would it be better to start a DISCUSS thread for 4.0 and keep this thread for 3.9 discussions? We seem to have agreement on 3.9. On Mon, Jun 17, 2024 at 4:29 PM José Armando García Sancio wrote: > > +1 for me. Thanks Colin for volunteering to be the release manager. > > On Mon, Jun 1

Re: [VOTE] KIP-1022 Formatting and Updating Features

; - There will be a new v4 for ApiVersionsRequest > > >> > > >> - Clients that sent v4 will promise to correctly handle ranges that > > start > > >> with 0, such as [0, 1] > > >> > > >> - The server will simply leave out the feature

Re: [DISCUSS] KIP-1060: Expose advertised.listeners for KRaft controllers

Hi Gantigmaa, I am implementing this as part of the KIP-853 implementation. I have a PR for this here: https://github.com/apache/kafka/pull/16235 Take a look at my KafkaConfig changes and related code. Thanks On Mon, Jun 24, 2024 at 8:04 AM Gantigmaa Selenge wrote: > > Hello > > I would like t

Re: [DISCUSS] KIP-1060: Expose advertised.listeners for KRaft controllers

being implemented! > > I raised a small PR <https://github.com/apache/kafka/pull/16473> to make > users aware that they can configure advertised.listeners for controllers. I > will also move the KIP to the discarded section. > > Regards, > Gantigmaa Selenge > On Mon, Jun 24,

Re: New release branch 3.9

Thanks Colin. For KIP-853 (KRaft Controller Membership Changes), we still have the following features that are in progress. 1. UpdateVoter RPC and request handling 2. Storage tool changes for KIP-853

Re: New release branch 3.9

>> > > > > >>> > >> > > We have a lot of contributors waiting to pick-up 4.0 > tickets, > > and > > >>> I'll > > >>> > >> > > go ahead a tell them that we are ready and they can start to > > pick > > >>> them > > >>&

Re: New release branch 3.9

; > > > > > >> > > > -Matthias > > >> > > > > > >> > > > On 7/30/24 3:51 PM, Colin McCabe wrote: > > >> > > >> Hi Chia-Ping Tsai, > > >> > > >> > > >> > > &g

Re: New release branch 3.9

On Wed, Jul 31, 2024 at 12:28 AM Ismael Juma wrote: > I would recommend against large refactorings in trunk until the first RC > for 3.9 - that will reduce cherry-pick friction. Once we have the first RC, > subsequent changes to 3.9 should be limited in scope. > I agree. We should specially dela

Re: [DISCUSS] KIP-1073 Return inactive observer nodes in DescribeQuorum response

Thanks for the KIP Gantigmaa! I agree with the motivation but it is not clear to me that this should be solved in the KRaft layer. The KRaft leader only keeps track, in-memory, of observers that have fetched. It is possible, after a kraft leader change, for this state to get lost. If the shutdown

Re: [DISCUSS] KIP-996: Pre-Vote

Hi Alyssa, 1. In the schema for VoteRequest and VoteResponse, you are using "boolean" as the type keyword. The correct keyword should be "bool" instead. 2. In the states and state transaction table you have the following entry: > * Candidate transitions to: > *... > *Prospective: After e

Re: [DISCUSS] KIP-996: Pre-Vote

Hi Alyssa, Thanks for the answers and the updates to the KIP. I took a look at the latest version and it looks good to me. -- -José

Re: [VOTE] KIP-996: Pre-Vote

+1. Thanks for the KIP. Looking forward to the implementation! -- -José

Re: [DISCUSS] KIP-853: KRaft Voters Change

Josep Prat wrote: > > Hi Jose, > Did you have any time to update the KIP? Let me know if we can help in any > way. > > Thanks in advance, > > On Mon, Nov 27, 2023 at 7:04 PM José Armando García Sancio > wrote: > > > On Mon, Nov 27, 2023 at 2:32 AM Josep Prat wrote:

Re: [DISCUSS] KIP-1013: Drop broker and tools support for Java 11 in Kafka 4.0 (deprecate in 3.7)

Hi Ismael, Looks good to me. Looking forward to programming using features and types included in JDK17 in 4.0 and not having to program using a 10 year old programming language and library. Thanks! -- -José

Re: [DISCUSS] Road to Kafka 4.0

Hi Divij, Thanks for the feedback. I agree that having a 3.8 release is beneficial but some of the comments in this message are inaccurate and could mislead the community and users. On Thu, Dec 21, 2023 at 7:00 AM Divij Vaidya wrote: > 1\ Durability/availability bugs in kraft - Even though kraft

Re: [ANNOUNCE] New Kafka PMC Member: Divij Vaidya

Congratulations Divij! On Thu, Dec 28, 2023 at 10:48 AM Divij Vaidya wrote: > > Thank you everyone for your warm wishes 🙏 > > -- > Divij Vaidya > > > > On Thu, Dec 28, 2023 at 2:37 PM Yash Mayya wrote: > > > Congratulations Divij! > > > > On Wed, Dec 27, 2023 at 5:15 PM Luke Chen wrote: > > > >

[DISCUSS] KIP-853: KRaft Controller Membership Changes

Hi all, KIP-853: KRaft Controller Membership Changes is ready for another round of discussion. There was a previous discussion thread at https://lists.apache.org/thread/zb5l1fsqw9vj25zkmtnrk6xm7q3dkm1v I have changed the KIP quite a bit since that discussion. The core idea is still the same. I c

Re: [DISCUSS] KIP-853: KRaft Controller Membership Changes

Thanks for the feedback Colin. Comments below. On Tue, Jan 9, 2024 at 4:58 PM Colin McCabe wrote: > 1. restarting a controller with an empty storage directory > > The controller can contact the quorum to get the cluster ID and current MV. > If the MV doesn't support quorum reconfiguration, it ca

Re: [DISCUSS] KIP-853: KRaft Controller Membership Changes

Thanks for your feedback Jason and excuse the delayed response. See comments below. On Tue, Jan 9, 2024 at 5:08 PM Jason Gustafson wrote: > > Hi Jose, > > Thanks for the KIP! A few initial questions below: > > 1. In the user experience section, the user is expected to provide supply > the UUID f

Re: [DISCUSS] KIP-853: KRaft Controller Membership Changes

Thanks Jason. Comments below. On Wed, Jan 10, 2024 at 9:06 AM Jason Gustafson wrote: > One additional thought. It would be helpful to have an example to justify > the need for this: > > > Wait for the fetch offset of the replica (ID, UUID) to catch up to the > log end offset of the leader. > > It

Re: [DISCUSS] KIP-853: KRaft Controller Membership Changes

Thanks for the feedback Luke. See my comments below: On Wed, Jan 24, 2024 at 4:20 AM Luke Chen wrote: > 1. About "VotersRecord": > > > When a KRaft voter becomes leader it will write a KRaftVersionRecord and > VotersRecord to the log if the log or the latest snapshot doesn't contain > any VotersR

Re: [DISCUSS] KIP-853: KRaft Controller Membership Changes

Hi Jason, Colin and Luke, I updated the KIP based on your feedback and my comments. Here is what has changed: https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=217391519&selectedPageVersions=54&selectedPageVersions=52 Here is an outline of all of the protocol changes: 1.

Re: [DISCUSS] KIP-853: KRaft Controller Membership Changes

Hi all, I have updated the KIP to include information on how KRaft controller automatic joining will work. Thanks, -- -José

Re: [DISCUSS] KIP-853: KRaft Voters Change

Hi all, This DISCUSS thread was continue in a new thread at: [DISCUSS] KIP-853: KRaft Controller Membership Changes: https://lists.apache.org/thread/6o3sjvcb8dx1ozqfpltb7p0w76b4nd46 Thanks! -- -José

Re: [DISCUSS] KIP-853: KRaft Controller Membership Changes

Hi Jack, see my comments below. On Thu, Feb 1, 2024 at 7:26 AM Jack Vanlightly wrote: > After thinking it through, it occurs to me that in examples 1 and 2, the > leader (of the latest configuration) should be sending BeginQuorumEpoch > requests to r3 after a certain timeout? r3 can start electio

Re: [DISCUSS] KIP-853: KRaft Controller Membership Changes

I updated the KIP to include the information discussed in this thread. I updated the sections "Reference explanation / Endpoints information" and "Reference explanation / Leader election". On Sun, Feb 11, 2024 at 1:06 PM José Armando García Sancio wrote: > Great exampl

Re: [DISCUSS] KIP-853: KRaft Controller Membership Changes

Hi Jun, Thanks for the feedback. Excuse the delay, it took me a while to properly address your detailed feedback. See my comments below. I am going to update the KIP as outlined in this email. I will send another email when I have made all of the changes. On Fri, Feb 2, 2024 at 10:54 AM Jun Rao

Re: [DISCUSS] KIP-853: KRaft Controller Membership Changes

Thanks for the feedback Jason. See my comments below. On Mon, Feb 5, 2024 at 3:11 PM Jason Gustafson wrote: > 1. When adding a voter, the KIP proposes to return a timeout error if the > voter cannot catch up in time. It might be more useful to return a more > specific error so that an operator ca

Re: [DISCUSS] KIP-853: KRaft Controller Membership Changes

Hi Jason and Jun, I have updated the KIP to incorporate your feedback. Some of the changes are: 1. Removed security protocol from the listener definition. The local replica is going to assume that the remote replica has the same listener name to security group mapping. 2. Reverted most of the cha

Re: [DISCUSS] KIP-853: KRaft Controller Membership Changes

Thanks for the additional feedback Jun. Comments below. On Fri, Feb 16, 2024 at 4:09 PM Jun Rao wrote: > 10. "The controller state machine will instead push the brokers' > kraft.version information to the KRaft client". If we do that, why do we > need KRaftVersionRecord? I am doing this as a rea

Re: [DISCUSS] KIP-853: KRaft Controller Membership Changes

Jun, I updated one of the rejected ideas to better explain why KRaft can't rely on information stored by the metadata layer. Thanks, -- -José

Re: [DISCUSS] KIP-966: Eligible Leader Replicas

Hi Calvin On Fri, Feb 23, 2024 at 9:23 AM Calvin Liu wrote: > As we agreed to implement the pagination for the new API > DescribeTopicPartitions, the client side must also add a proper interface > to handle the pagination. > The current KafkaAdminClient.describeTopics returns > the DescribeTopics

Re: [DISCUSS] KIP-853: KRaft Controller Membership Changes

Hi Jun, see my comments below. I need to make some changes to the KIP to reflect our conversation. On Fri, Feb 23, 2024 at 1:39 PM Jun Rao wrote: > 15.1 "In this configuration, the local replica needs to use > CONTROLLER_PLAINTEXT because that is what is supported by all of the > voters." >H

Re: [DISCUSS] KIP-853: KRaft Controller Membership Changes

Hi Jun, Thanks for the comments. See my comments below. On Mon, Feb 26, 2024 at 4:48 PM Jun Rao wrote: > 15.1 It would be useful to document the process of changing the controller > listener. For example, what configs need to be changed in what order and > how a voter/observer selects the listen

Re: [DISCUSS] KIP-1022 Formatting and Updating Features

Hi Justine and Jun, Thanks for the KIP Justine. See my comments below. On Wed, Feb 28, 2024 at 3:09 PM Jun Rao wrote: > 13. KIP-853 also extends the tools to support a new feature kraft.version. > It would be useful to have alignment between that KIP and this one. I agree. I took a look at this

Re: [DISCUSS] KIP-853: KRaft Controller Membership Changes

Hi Jun and Luke, Jun, I added a section the documents the process for upgrading the controller listeners endpoints: https://cwiki.apache.org/confluence/display/KAFKA/KIP-853%3A+KRaft+Controller+Membership+Changes#KIP853:KRaftControllerMembershipChanges-Upgradingcontrollerlistener Jun and Luke,

Re: [DISCUSS] KIP-1022 Formatting and Updating Features

Thanks for the reply Justine. See my comments below: On Thu, Feb 29, 2024 at 3:39 PM Justine Olshan wrote: > I wanted to include multiple features in one command, so it seems like > features is a better name. I discuss more below about why I think we should > allow setting multiple features at on

Re: [DISCUSS] KIP-853: KRaft Controller Membership Changes

Hi Jun, Thanks for the feedback. See my comments below. On Tue, Feb 27, 2024 at 11:27 AM Jun Rao wrote: > 30. Who controls RPCs like Fetch, FetchSnapshot, DescribeQuorum RPC? They > are shared between voters and observers. For Fetch and FetchSnapshot, this KIP adds the tagged field ReplicaUuid

Re: [DISCUSS] KIP-853: KRaft Controller Membership Changes

Hi Luke, Thanks for the feedback. See my comments below. I have also updated the KIP to reflect this discussion. On Wed, Feb 28, 2024 at 4:34 AM Luke Chen wrote: > > > 2. After "RemoveVoter", what is the role of the node? > > It looks like after the voter got removed from the voter set, it is n

Re: [DISCUSS] KIP-853: KRaft Controller Membership Changes

Hi Jun, Thanks for the feedback. See my comments below. On Fri, Mar 1, 2024 at 11:36 AM Jun Rao wrote: > 30. Historically, we used MV to gate the version of Fetch request. Are you > saying that voters will ignore MV and only depend on raft.version when > choosing the version of Fetch request? B

Re: [DISCUSS] KIP-853: KRaft Controller Membership Changes

Hi Jun, See my comments below. On Tue, Mar 5, 2024 at 2:57 PM Jun Rao wrote: > 37. We don't batch multiple topic partitions in AddVoter, RemoveVoter and > UpdateVoter requests while other requests like Vote and BeginQuorumEpoch > support batching. Should we make them consistent? Originally I ha

Re: [DISCUSS] KIP-853: KRaft Controller Membership Changes

Hi Jun Thanks for the feedback. See my comments below. On Wed, Mar 6, 2024 at 4:47 PM Jun Rao wrote: > 20.1. It seems that the PreferredSuccessors field didn't get fixed. It's > still there together with PreferredCandidates. > +{ "name": "PreferredSuccessors", "type": "[]int32", "version

Re: [DISCUSS] Personal branches under apache/kafka

On Wed, Mar 13, 2024 at 11:02 AM Mickael Maison wrote: > What do you think? I agree. I wouldn't be surprised if these branches (not trunk or release branches) were created by mistake by the committer. Thanks, -- -José

Re: [DISCUSS] KIP-1022 Formatting and Updating Features

Hi Justine, Thanks for the update. Some comments below. On Wed, Mar 13, 2024 at 10:53 AM Justine Olshan wrote: > 4. Include an API to list the features for a given metadata version I am not opposed to designing and implementing this. I am just wondering if this is strictly required? Would havi

Re: [DISCUSS] KIP-853: KRaft Controller Membership Changes

Hi Jun, See my comments below. On Thu, Mar 14, 2024 at 3:38 PM Jun Rao wrote: > 37. Have you updated the wiki? It seems that LeaderIdAndEpoch and > NodeEpoint are still two separate structs. It is updated now. Apologies for the delayed wiki updates but I was dealing with other issues in the pas

Re: [DISCUSS] KIP-853: KRaft Controller Membership Changes

Hi Jun, On Thu, Mar 14, 2024 at 3:38 PM Jun Rao wrote: > 52. Admin client: Could you provide a bit more details on the changes? I updated the KIP to include the API changes to the Admin client. Thanks, -- -José

Re: [DISCUSS] KIP-853: KRaft Controller Membership Changes

Hi Claude, On Fri, Mar 22, 2024 at 4:36 AM Claude Warren wrote: > Is there test code, or initial POC code for this KIP somewhere? I would like > to help move this forward but need a few pointers to associated resources. I > have read KIP-853 and it is beginning to sink in, but code would be n

Re: [DISCUSS] KIP-853: KRaft Controller Membership Changes

Hi Jun, See my comments below. On Fri, Mar 22, 2024 at 1:30 PM Jun Rao wrote: > 54. Admin.addMetadataVoter: It seems that Endpoint shouldn't include > securityProtocol since it's not in DescribeQuorumResponse. Yeah. I noticed that when I made the Admin changes. We either use a different type in

Re: [DISCUSS] KIP-1022 Formatting and Updating Features

Hi Justine, Thanks for the update. See my comments below. On Mon, Mar 25, 2024 at 2:51 PM Justine Olshan wrote: > I've updated the KIP with the changes I mentioned earlier. I have not yet > removed the --feature-version flag from the upgrade tool. What's the "--feature-version" flag? This is th

Re: [DISCUSS] KIP-1022 Formatting and Updating Features

Hi Justine, On Mon, Mar 25, 2024 at 5:09 PM Justine Olshan wrote: > The reason it is not removed is purely for backwards > compatibility. Colin had strong feelings about not removing any flags. We are not saying that we should remove that flag. That would break backward compatibility of 3.8 with

Re: [DISCUSS] KIP-853: KRaft Controller Membership Changes

Hi Jun, Thanks for the feedback. See my comments below. On Mon, Mar 25, 2024 at 2:21 PM Jun Rao wrote: > 54. Yes, we could include SecurityProtocol in DescribeQuorumResponse. Then, > we could include it in the output of kafka-metadata-quorum --describe. Yes, I updated the DescribeQuorumResponse

Re: [DISCUSS] KIP-1022 Formatting and Updating Features

Hi Justine, See my comment below. On Wed, Mar 27, 2024 at 1:31 PM Justine Olshan wrote: > The feature command includes the upgrade or downgrade command along with > the --release-version flag. If some features are not moving in the > direction mentioned (upgrade or downgrade) the command will fa

Re: [DISCUSS] KIP-853: KRaft Controller Membership Changes

Hi Jun, On Wed, Mar 27, 2024 at 2:26 PM Jun Rao wrote: > 55.1 How does the broker and non-leader controller know the pending voters? They are in the log. Pending voter sets are VotersRecords between the HWM and the LEO. The leader will make sure that there is at most one VoterRecord that is unco

Re: [DISCUSS] KIP-853: KRaft Controller Membership Changes

Hi Jun, On Thu, Mar 28, 2024 at 10:35 AM Jun Rao wrote: > The following are the steps of AddVoter. The bulk of the time is probably > in step 5, but the updated VotersRecord won't be written until step 6. So, > ideally, the controller leader should report the pending voter as soon as > step 1. Th

Re: [DISCUSS] KIP-853: KRaft Controller Membership Changes

Hi Jun, See my comments below. On Thu, Mar 28, 2024 at 11:09 AM Jun Rao wrote: > If I am adding a new voter and it takes a long time (because the new voter > is catching up), I'd want to know if the request is indeed being processed. > I thought that's the usage of uncommitted-voter-change. The

Re: [DISCUSS] KIP-853: KRaft Controller Membership Changes

Jun, thanks a lot for your help. I feel that the KIP is much better after your detailed input. If there is no more feedback, I'll start a voting thread tomorrow morning. I'll monitor KIP-1022's discussion thread and update this KIP with anything that affects the KIP's specification. Thanks, -- -

[VOTE] KIP-853: KRaft Controller Membership Changes

Hi all, I would like to call a vote to adopt KIP-853. KIP: https://cwiki.apache.org/confluence/x/nyH1D Discussion thread: https://lists.apache.org/thread/6o3sjvcb8dx1ozqfpltb7p0w76b4nd46 Thanks, -- -José

Re: [DISCUSS] KIP-1022 Formatting and Updating Features

Hi Justine, See my comments below. On Mon, Apr 1, 2024 at 4:43 PM Justine Olshan wrote: > 20. I can update the KIP. I took a look at the latest KIP. * Should the output of this command "bin/kafka-features.sh version-mapping --release-version 3.6-IV1" be something like this: metadata.version=13

Re: [DISCUSS] KIP-1022 Formatting and Updating Features

Hi Justine, Thanks for the KIP. I see that the KIP doesn't make any updates to the UpdateFeatures RPC. I was trying to understand how errors will be communicated to the client. Are you planning to use the INVALID_UPDATE_VERSION error and overwrite the ErrorMessage field for all of the validations

Re: [DISCUSS] KIP-1022 Formatting and Updating Features

Hi Justine, On Tue, Apr 9, 2024 at 4:19 PM Justine Olshan wrote: > As for the validation criteria. It seems like one bit of code that > validates whether a version is allowed is in the method > `reasonNotSupported` which checks the range of features available for the > given feature. > For metada

Re: [VOTE] KIP-1022 Formatting and Updating Features

Hi Justine, +1 (binding) Thanks for the improvement. -- -José

Re: [VOTE] KIP-853: KRaft Controller Membership Changes

+1 binding. On Mon, Apr 22, 2024 at 9:28 AM Jason Gustafson wrote: > > Thanks Jose. +1. Great KIP! > > On Fri, Mar 29, 2024 at 11:16 AM Jun Rao wrote: > > > Hi, Jose, > > > > Thanks for the KIP. +1 > > > > Jun > > > > On Fri, Mar

Re: [VOTE] KIP-853: KRaft Controller Membership Changes

I am going to close the vote tomorrow morning (PST). On Mon, Apr 22, 2024 at 10:06 AM José Armando García Sancio wrote: > > +1 binding. > > On Mon, Apr 22, 2024 at 9:28 AM Jason Gustafson > wrote: > > > > Thanks Jose. +1. Great KIP! > > > > On Fri,

Re: [VOTE] KIP-853: KRaft Controller Membership Changes

Hi all, I am closing the voting. The KIP passed with: Jun Rao +1 binding Jason Gustafson +1 binding José Armando García Sancio +1 binding Thank you all, On Mon, Apr 22, 2024 at 11:57 AM José Armando García Sancio wrote: > > I am going to close the vote tomorrow morning (PST). > >

Re: [DISCUSS] KIP-1073 Return inactive observer nodes in DescribeQuorum response

Thanks for the KIP Gantigmaa, > { "name": "IncludeFencedBrokers", "type": "bool", "versions": "2+", "about": > "Whether to include fenced brokers." } Did you consider making "includeFencedBroker" field value implicitly based on the DescribeClusterRequest version and the EndpointType? For example

Re: [DISCUSS] KIP-1073 Return inactive observer nodes in DescribeQuorum response

Gantigmaa, thanks for the changes, they look good to me in general, I have some UX questions. The KIP mentions the following: > Also if there is no rack information for any of the nodes, the RACK column > will be omitted from the output. What will the tool output for nodes that don't have a rack

Re: [DISCUSS] KIP-1073 Return inactive observer nodes in DescribeQuorum response

Thanks Gantigmaa. See comments below. The KIP LGTM after this. On Thu, Sep 12, 2024 at 4:50 AM Gantigmaa Selenge wrote: > Will this make it more confusing for combined nodes? Users might expect to > see both controller and broker under ROLES if it is a combined node. Since > we would be able to o

Re: [DISCUSS] Apache Kafka 3.3.0 Release

Hello Kafka users, developers and client-developers, This is the first candidate for release of Apache Kafka 3.3.0. Release notes for the 3.3.0 release: https://home.apache.org/~jsancio/kafka-3.3.0-rc1/RELEASE_NOTES.html Please download and test. Kafka's KEYS file containing PGP keys we use to

Re: [DISCUSS] Apache Kafka 3.3.0 Release

The documentation and protocol links are not working. Looking into it. https://kafka.apache.org/33/documentation.html https://kafka.apache.org/33/protocol.html Thanks, -José

Re: [DISCUSS] Apache Kafka 3.3.0 Release

Thanks Artem and Colin for identifying and fixing the issues KAFKA-14156 and KAFKA-14187. I have marked both of them as blocker for this release. I also don't think that these issues should block testing other parts of the release. Thanks José

[VOTE] Apache Kafka 3.3.0 RC1

Hello Kafka users, developers and client-developers, This is the first candidate for the release of Apache Kafka 3.3.0. There are some issues that we still have to resolve before we can make a final release. Those issues are documented here: https://issues.apache.org/jira/issues/?jql=project%20%3D

Re: [DISCUSS] Apache Kafka 3.3.0 Release

+1 from me. Thanks for your help David. Much appreciated. On Mon, Sep 19, 2022 at 10:29 AM David Arthur wrote: > > Hey folks, José has asked me to help push the release along this week while > he's out of the office. > > -David > > On Tue, Aug 30, 2022 at 12:01 PM

[VOTE] 3.3.1 RC0

Hello Kafka users, developers and client-developers, This is the first candidate for release of Apache Kafka 3.3.1. This release fixes two issues with the 3.3.0 release. * [KAFKA-14259] - BrokerRegistration#toString throws an exception, terminating metadata replay * [KAFKA-14265] - Prefix ACLs ma

Re: [VOTE] 3.3.1 RC0

On Thu, Sep 29, 2022 at 2:39 PM José Armando García Sancio wrote: > Please download, test and vote by Tuesday, October 4, 9am PT. The vote will be open for 72 hours. Please vote by Sunday, October 2nd, 3 PM PT. Thanks! -- -José

Re: [VOTE] 3.3.1 RC0

Thanks for the votes John, Bill and David. Here are the system test results: http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/3.3/2022-09-30--001.system-test-kafka-3.3--1664605767--confluentinc--3.3--eefe867118/report.html There are two failures. I reran those tests. I will r

Re: [VOTE] 3.3.1 RC0

-builder--1664643010--apache--3.3--cdb25e10dc/2022-10-01--001./2022-10-01--001./report.html On Sat, Oct 1, 2022 at 9:14 AM José Armando García Sancio wrote: > > Thanks for the votes John, Bill and David. > > Here are the system test results: > http://confluent-kafka-system-test-resul

Re: [VOTE] 3.3.1 RC0

Hi all, All of the system tests for 3.3 passed. http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/3.3/2022-09-30--001.system-test-kafka-3.3--1664605767--confluentinc--3.3--eefe867118/report.html This build ran all of the tests and there were two failures: kafkatest.tests.core

[RESULTS] [VOTE] Release Apache Kafka version 3.3.1

Hi all, The vote passed with 4 +1 votes (3 binding votes) and no 0 or -1 votes. +1 votes: PMC Members: David Jacot Bill Bejeck John Roesler Community: Jakub Scholz Vote thread: https://lists.apache.org/thread/ykcqs5rkrrnjzts2p5tfxrbccdjrhxqs I'll continue with the release process and the relea

[ANNOUNCE] Apache Kafka 3.3.1

Armando García Sancio, jparag, Justine Olshan, K8sCat, Kirk True, Konstantine Karantasis, Kvicii, Lee Dongjin, Levani Kokhreidze, Liam Clarke-Hutchinson, Lucas Bradstreet, Lucas Wang, Luke Chen, Manikumar Reddy, Marco Aurelio Lotz, Matthew de Detrich, Matthias J. Sax, Mickael Maison, Mike Lothian

Re: [ANNOUNCE] Apache Kafka 3.3.1

On Mon, Oct 3, 2022 at 2:00 PM Igor Soarez wrote: > > Thanks Jose and David for running this patch release. Congratulations to all! > > I don't see the tag or the usual commit sequence in the 3.3 branch for this > release. I'd expect a `3.3.1` and a commit moving the version to > 3.3.2-SNAPSHOT.

3.3.1 release and permission to S3 bucket

Hey Kafka committers, Can anyone help me with these commands: Upload the new release and kafka-stream-x.x.x-test.jar (can be found in the .release_work_dir created by the release.py script) to the S3 bucket "kafka-packages". Use the AWS console to upload the files in the bucket or the CLI if you h

Re: 3.3.1 release and permission to S3 bucket

I talked to Manikumar offline. He explained to me that this is a bucket owned by Confluent. I was unblocked and was able to upload the artifacts to the S3 bucket. I am updating the release process page to better document this. On Tue, Oct 4, 2022 at 10:38 AM José Armando García Sancio wrote

Re: [DISCUSS] Apache Kafka 3.4.0 release

Thanks for volunteering Sophie. On Wed, Oct 5, 2022 at 3:01 PM Sophie Blee-Goldman wrote: > > Hey all, > > I'd like to volunteer as release manager for the next feature release, > which will be Apache > Kafka 3.4.0. If that sounds good to everyone I'll update this thread with > the release plan i

Re: [ANNOUNCE] New committer: Deng Ziming

Congratulations Ziming. Well deserved and I much appreciate your contributions to the project. -- -José

  1   2   3   >