Thanks. LGTM. +1. On Tue, Nov 21, 2023 at 2:54 PM Jun Rao <j...@confluent.io.invalid> wrote: > > Hi, Ismael, > > Thanks for the KIP. +1 > > It would be useful to clarify in the KIP that the new metric and new > request log attribute will be added in Apache 3.7. > > Jun > > On Tue, Nov 21, 2023 at 1:57 PM Colin McCabe <cmcc...@apache.org> wrote: > > > Ah. I forget that KIP-724 not only deprecated, but proposed a removal in > > 4.0. Great. > > > > +1 (binding) for KIP-896 > > > > best, > > Colin > > > > On Tue, Nov 21, 2023, at 12:36, Ismael Juma wrote: > > > Hi Colin, > > > > > > That change was proposed and approved via KIP-724: > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-724%3A+Drop+support+for+message+formats+v0+and+v1 > > > > > > Ismael > > > > > > On Tue, Nov 21, 2023, 12:21 PM Colin McCabe <cmcc...@apache.org> wrote: > > > > > >> Hi Ismael, > > >> > > >> Can we state somewhere that the message.format.version configuration > > will > > >> be gone in 4.0? We only will support one message format version (for > > now, > > >> at least). If we do want more versions later, I don't think we'll want > > to > > >> configure them via a static config. > > >> > > >> best, > > >> Colin > > >> > > >> > > >> On Tue, Nov 21, 2023, at 12:06, Ismael Juma wrote: > > >> > Hi all, > > >> > > > >> > I would like to start a vote on KIP-896. Please take a look and let us > > >> know > > >> > what you think. > > >> > > > >> > Even though most of the changes in this KIP will be done for Apache > > Kafka > > >> > 4.0, I would like to introduce a new metric and new request log > > attribute > > >> > in Apache 3.7 to help users identify usage of deprecated protocol api > > >> > versions. > > >> > > > >> > Link: > > >> > > > >> > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-896%3A+Remove+old+client+protocol+API+versions+in+Kafka+4.0 > > >> > > > >> > Thanks, > > >> > Ismael > > >> > >
-- -José
