Thanks Gantigmaa. See comments below. The KIP LGTM after this.

On Thu, Sep 12, 2024 at 4:50 AM Gantigmaa Selenge <gsele...@redhat.com> wrote:
> Will this make it more confusing for combined nodes? Users might expect to
> see both controller and broker under ROLES if it is a combined node. Since
> we would be able to output only one depending on the bootstrap option, I
> wonder if it's better to stay consistent with the information in the result
> returned by the API.

How about ENDPOINT-TYPE for the column name? That matches the keyword
used in the request and better matches the semantic of the output.

Also, I am okay if you want to leave it out. I thought the user may
find it useful but if you find it confusing we can leave it out.

Thanks,
-- 
-José

Reply via email to