[
https://issues.apache.org/jira/browse/KAFKA-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13615355#comment-13615355
]
Jun Rao commented on KAFKA-828:
---
Thanks for patch v3. A couple of comments:
1. There is a co
[
https://issues.apache.org/jira/browse/KAFKA-830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-830:
Attachment: kafka-830-v1.patch
- Changed any replica list to a set. This makes sense since replica i
[
https://issues.apache.org/jira/browse/KAFKA-830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on KAFKA-830 stopped by Neha Narkhede.
> partition replica assignment map in the controller should be a Set
>
[
https://issues.apache.org/jira/browse/KAFKA-830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on KAFKA-830 started by Neha Narkhede.
> partition replica assignment map in the controller should be a Set
>
[
https://issues.apache.org/jira/browse/KAFKA-830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on KAFKA-830 started by Neha Narkhede.
> partition replica assignment map in the controller should be a Set
>
[
https://issues.apache.org/jira/browse/KAFKA-830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-830:
Status: Patch Available (was: In Progress)
> partition replica assignment map in the controller
[
https://issues.apache.org/jira/browse/KAFKA-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13615416#comment-13615416
]
Neha Narkhede commented on KAFKA-828:
-
Agree with Jun on 1, 2 and 3.
The issue with yo
[
https://issues.apache.org/jira/browse/KAFKA-830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13615448#comment-13615448
]
Jun Rao commented on KAFKA-830:
---
Thanks for the patch. One problem with changing assigned rep
[
https://issues.apache.org/jira/browse/KAFKA-830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-830:
Attachment: kafka-830-v2.patch
Good catch! However, it doesn't make sense to keep it sequence since
[
https://issues.apache.org/jira/browse/KAFKA-830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13615586#comment-13615586
]
Neha Narkhede commented on KAFKA-830:
-
Actually, thinking about it more, even picking t
[
https://issues.apache.org/jira/browse/KAFKA-830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13615645#comment-13615645
]
Swapnil Ghike commented on KAFKA-830:
-
collection.mutable.LinkedHashSet will iterate th
[
https://issues.apache.org/jira/browse/KAFKA-830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13615697#comment-13615697
]
Jun Rao commented on KAFKA-830:
---
+1 on patch v2.
> partition replica assignm
[
https://issues.apache.org/jira/browse/KAFKA-830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-830:
Resolution: Fixed
Status: Resolved (was: Patch Available)
> partition replica assignmen
[
https://issues.apache.org/jira/browse/KAFKA-830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede closed KAFKA-830.
---
Thanks for the review
> partition replica assignment map in the controller should be a Se
[
https://issues.apache.org/jira/browse/KAFKA-830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13615750#comment-13615750
]
Neha Narkhede commented on KAFKA-830:
-
Swapnil, thanks for pointing that out, we can re
[
https://issues.apache.org/jira/browse/KAFKA-819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Fung updated KAFKA-819:
Attachment: kafka-819-v1.patch
Uploaded kafka-819-v1.patch
> System Test : Add validation o
[
https://issues.apache.org/jira/browse/KAFKA-819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Fung updated KAFKA-819:
Status: Patch Available (was: Open)
> System Test : Add validation of log segment index to offset
> ---
[
https://issues.apache.org/jira/browse/KAFKA-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13615809#comment-13615809
]
John Fung commented on KAFKA-819:
-
This patch is tested with an older 0.8 branch (before ka
[
https://issues.apache.org/jira/browse/KAFKA-829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on KAFKA-829 started by Neha Narkhede.
> Mirror maker needs to share the migration tool request channel
> ---
[
https://issues.apache.org/jira/browse/KAFKA-829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-829:
Status: Patch Available (was: In Progress)
> Mirror maker needs to share the migration tool req
[
https://issues.apache.org/jira/browse/KAFKA-829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-829:
Attachment: kafka-829-v1.patch
- Mirror maker shares the producer data channel and producer thread f
[
https://issues.apache.org/jira/browse/KAFKA-819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-819:
--
Resolution: Fixed
Fix Version/s: 0.8
Status: Resolved (was: Patch Available)
Thanks for the p
[
https://issues.apache.org/jira/browse/KAFKA-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13616045#comment-13616045
]
Jason Rosenberg commented on KAFKA-253:
---
Was this change merged to the 0.7 branch?
[
https://issues.apache.org/jira/browse/KAFKA-828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Swapnil Ghike updated KAFKA-828:
Attachment: kafka-828-v4.patch
Agree with all comments, uploading patch v4.
Defined a new LeaderEl
24 matches
Mail list logo
