[ https://issues.apache.org/jira/browse/KAFKA-830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13615586#comment-13615586 ]
Neha Narkhede commented on KAFKA-830: ------------------------------------- Actually, thinking about it more, even picking the smallest replica id does not make sense. This is because if we pick the first replica to be the largest broker id, the rest of the replica ids are smaller than the preferred replica in this case. We will have to keep this a sequence and be careful while adding a replica id to the assigned replica list > partition replica assignment map in the controller should be a Set > ------------------------------------------------------------------ > > Key: KAFKA-830 > URL: https://issues.apache.org/jira/browse/KAFKA-830 > Project: Kafka > Issue Type: Bug > Components: controller > Reporter: Neha Narkhede > Assignee: Neha Narkhede > Priority: Blocker > Labels: kafka-0.8, p1 > Fix For: 0.8 > > Attachments: kafka-830-v1.patch, kafka-830-v2.patch > > > partitionReplicaAssignment currently stores the list of assigned replicas as > a sequence. When a broker comes online, the replica state machine adds the > broker to the list of assigned replicas. It should do that only if the > replica is already not in the list of assigned replicas. This causes the > replication factor to be incorrectly calculated -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira