[ https://issues.apache.org/jira/browse/KAFKA-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13615416#comment-13615416 ]
Neha Narkhede commented on KAFKA-828: ------------------------------------- Agree with Jun on 1, 2 and 3. The issue with your change to the leader selector is that it doesn't achieve the objective of KAFKA-814 completely. If a preferred replica is already the leader, we *do not* want to update zookeeper and send the become leader request to the replica again. It should just continue to work on the next partition. It doesn't achieve that. One way of handling that is throwing a special exception LeaderAlreadyElectedException (or a better name) and then catching and swallowing it inside electLeaderForPartition() > Preferred Replica Election does not delete the admin path on controller > failover > -------------------------------------------------------------------------------- > > Key: KAFKA-828 > URL: https://issues.apache.org/jira/browse/KAFKA-828 > Project: Kafka > Issue Type: Bug > Affects Versions: 0.8 > Reporter: Swapnil Ghike > Assignee: Swapnil Ghike > Priority: Blocker > Labels: bugs, kafka-0.8, p1 > Fix For: 0.8 > > Attachments: kafka-828-v1.patch, kafka-828-v2.patch, > kafka-828-v3.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira