[
https://issues.apache.org/jira/browse/KAFKA-830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13615448#comment-13615448
]
Jun Rao commented on KAFKA-830:
-------------------------------
Thanks for the patch. One problem with changing assigned replicas from a list
to a set is that it breaks the preferred replica logic. We assume that the
first replica is the preferred one. So the ordering of the replicas is
important. Perhaps we should keep replicas as a list and make sure that we
don't add duplicates when changing it.
> partition replica assignment map in the controller should be a Set
> ------------------------------------------------------------------
>
> Key: KAFKA-830
> URL: https://issues.apache.org/jira/browse/KAFKA-830
> Project: Kafka
> Issue Type: Bug
> Components: controller
> Reporter: Neha Narkhede
> Assignee: Neha Narkhede
> Priority: Blocker
> Labels: kafka-0.8, p1
> Fix For: 0.8
>
> Attachments: kafka-830-v1.patch
>
>
> partitionReplicaAssignment currently stores the list of assigned replicas as
> a sequence. When a broker comes online, the replica state machine adds the
> broker to the list of assigned replicas. It should do that only if the
> replica is already not in the list of assigned replicas. This causes the
> replication factor to be incorrectly calculated
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
