[ 
https://issues.apache.org/jira/browse/KAFKA-830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13615645#comment-13615645
 ] 

Swapnil Ghike commented on KAFKA-830:
-------------------------------------

collection.mutable.LinkedHashSet will iterate the elements in the same sequence 
they were inserted. But using it will require changes at more places than the 
one line change in patch v2.
                
> partition replica assignment map in the controller should be a Set
> ------------------------------------------------------------------
>
>                 Key: KAFKA-830
>                 URL: https://issues.apache.org/jira/browse/KAFKA-830
>             Project: Kafka
>          Issue Type: Bug
>          Components: controller
>            Reporter: Neha Narkhede
>            Assignee: Neha Narkhede
>            Priority: Blocker
>              Labels: kafka-0.8, p1
>             Fix For: 0.8
>
>         Attachments: kafka-830-v1.patch, kafka-830-v2.patch
>
>
> partitionReplicaAssignment currently stores the list of assigned replicas as 
> a sequence. When a broker comes online, the replica state machine adds the 
> broker to the list of assigned replicas. It should do that only if the 
> replica is already not in the list of assigned replicas. This causes the 
> replication factor to be incorrectly calculated

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to