Re: Review Request 24006: Patch for KAFKA-1420

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24006/#review80620 --- Thanks for the patch. Sorry for the late review. A few comments belo

Re: Review Request 24006: Patch for KAFKA-1420

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24006/#review50264 --- Looks good to me. Can other committers double-check it? - Guozhang

Re: Review Request 24006: Patch for KAFKA-1420

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24006/ --- (Updated Aug. 11, 2014, 6:03 a.m.) Review request for kafka. Bugs: KAFKA-1420

Re: Review Request 24006: Patch for KAFKA-1420

Ah, gotcha. Given that, I think I made the right adjustment. Thanks for the clarification! On Sun, Aug 10, 2014 at 10:38 PM, Guozhang Wang wrote: > > > > On Aug. 10, 2014, 9:12 p.m., Jonathan Natkins wrote: > > > core/src/test/scala/unit/kafka/admin/AdminTest.scala, line 114 > > > < > https://r

Re: Review Request 24006: Patch for KAFKA-1420

> On Aug. 10, 2014, 9:12 p.m., Jonathan Natkins wrote: > > core/src/test/scala/unit/kafka/admin/AdminTest.scala, line 114 > > > > > > I wasn't totally sure I understood this comment, so I made a change > > that I th

Re: Review Request 24006: Patch for KAFKA-1420

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24006/#review50137 --- Thanks for the patch. One comment below. core/src/test/scala/unit/

Re: Review Request 24006: Patch for KAFKA-1420

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24006/ --- (Updated Aug. 10, 2014, 9:11 p.m.) Review request for kafka. Bugs: KAFKA-1420

Re: Review Request 24006: Patch for KAFKA-1420

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24006/#review50126 --- core/src/test/scala/unit/kafka/admin/AdminTest.scala

Re: Review Request 24006: Patch for KAFKA-1420

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24006/#review50060 --- Ship it! Looks good to me, just a couple minor comments below. co

Re: Review Request 24006: Patch for KAFKA-1420

> On Aug. 1, 2014, 9:27 p.m., Guozhang Wang wrote: > > core/src/test/scala/unit/kafka/admin/AdminTest.scala, line 134 > > > > > > What I was actually thinking is that probably we can define these two > > variables at

Re: Review Request 24006: Patch for KAFKA-1420

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24006/ --- (Updated Aug. 2, 2014, 6:04 p.m.) Review request for kafka. Bugs: KAFKA-1420

Re: Review Request 24006: Patch for KAFKA-1420

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24006/#review49382 --- core/src/test/scala/unit/kafka/admin/AdminTest.scala

Re: Review Request 24006: Patch for KAFKA-1420

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24006/#review49139 --- core/src/test/scala/unit/kafka/admin/AdminTest.scala

Re: Review Request 24006: Patch for KAFKA-1420

> On July 30, 2014, 12:22 a.m., Guozhang Wang wrote: > > core/src/test/scala/unit/kafka/admin/AdminTest.scala, line 314 > > > > > > Is there a specific reason we want to use 10 seconds instead of default > > 5 seconds

Re: Review Request 24006: Patch for KAFKA-1420

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24006/ --- (Updated July 30, 2014, 6:24 p.m.) Review request for kafka. Bugs: KAFKA-1420

Re: Review Request 24006: Patch for KAFKA-1420

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24006/ --- (Updated July 30, 2014, 6:18 p.m.) Review request for kafka. Bugs: KAFKA-1420

Re: Review Request 24006: Patch for KAFKA-1420

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24006/#review49049 --- core/src/test/scala/unit/kafka/admin/AdminTest.scala

Re: Review Request 24006: Patch for KAFKA-1420

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24006/ --- (Updated July 28, 2014, 8:52 p.m.) Review request for kafka. Bugs: KAFKA-1420

Review Request 24006: Patch for KAFKA-1420

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24006/ --- Review request for kafka. Bugs: KAFKA-1420 https://issues.apache.org/jira/b