----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24006/#review80620 -----------------------------------------------------------
Thanks for the patch. Sorry for the late review. A few comments below. core/src/test/scala/unit/kafka/admin/AdminTest.scala <https://reviews.apache.org/r/24006/#comment130720> This is a case where we probably want to explicitly specify the replica assignment. We don't want to depend on the current assignment strategy since it may change in the future. core/src/test/scala/unit/kafka/admin/AdminTest.scala <https://reviews.apache.org/r/24006/#comment130721> Ditto as the above. core/src/test/scala/unit/kafka/admin/AdminTest.scala <https://reviews.apache.org/r/24006/#comment130722> Ditto as the above. core/src/test/scala/unit/kafka/admin/AdminTest.scala <https://reviews.apache.org/r/24006/#comment130728> This may not be a reliable way to wait for replica 0 to be in isr. Perhaps, we can explicitly check the isr set in Partition through ReplicaManager in the leader broker. core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala <https://reviews.apache.org/r/24006/#comment130731> Should we use replicaIdsForPartition instead of Seq(0,1,2,3)? - Jun Rao On Aug. 11, 2014, 6:03 a.m., Jonathan Natkins wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24006/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2014, 6:03 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1420 > https://issues.apache.org/jira/browse/KAFKA-1420 > > > Repository: kafka > > > Description > ------- > > KAFKA-1420 Replace AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZK > with TestUtils.createTopic in unit tests > > > Diffs > ----- > > core/src/test/scala/unit/kafka/admin/AdminTest.scala > e28979827110dfbbb92fe5b152e7f1cc973de400 > core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala > 29cc01bcef9cacd8dec1f5d662644fc6fe4994bc > core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala > f44568cb25edf25db857415119018fd4c9922f61 > core/src/test/scala/unit/kafka/utils/TestUtils.scala > c4e13c5240c8303853d08cc3b40088f8c7dae460 > > Diff: https://reviews.apache.org/r/24006/diff/ > > > Testing > ------- > > Automated > > > Thanks, > > Jonathan Natkins > >
