Ah, gotcha. Given that, I think I made the right adjustment. Thanks for the clarification!
On Sun, Aug 10, 2014 at 10:38 PM, Guozhang Wang <guw...@linkedin.com> wrote: > > > > On Aug. 10, 2014, 9:12 p.m., Jonathan Natkins wrote: > > > core/src/test/scala/unit/kafka/admin/AdminTest.scala, line 114 > > > < > https://reviews.apache.org/r/24006/diff/3-4/?file=646111#file646111line114 > > > > > > > > I wasn't totally sure I understood this comment, so I made a > change that I think reflects what you were looking for. Let me know if I > missed the mark. > > What I meant is that we need to guarantee the preferred replica would be > the first replica in the list. For our case, it just that > > range(0, 10).map(i => (i -> i % brokers.size)).toMap > > gets the same result that it gets the first replica of the lists returned > by > > combinations(brokers, replicationFactor) > > but it may not always be the case. > > > - Guozhang > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24006/#review50126 > ----------------------------------------------------------- > > > On Aug. 10, 2014, 9:11 p.m., Jonathan Natkins wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/24006/ > > ----------------------------------------------------------- > > > > (Updated Aug. 10, 2014, 9:11 p.m.) > > > > > > Review request for kafka. > > > > > > Bugs: KAFKA-1420 > > https://issues.apache.org/jira/browse/KAFKA-1420 > > > > > > Repository: kafka > > > > > > Description > > ------- > > > > KAFKA-1420 Replace > AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZK with > TestUtils.createTopic in unit tests > > > > > > Diffs > > ----- > > > > core/src/test/scala/unit/kafka/admin/AdminTest.scala > e28979827110dfbbb92fe5b152e7f1cc973de400 > > core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala > 29cc01bcef9cacd8dec1f5d662644fc6fe4994bc > > > core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala > f44568cb25edf25db857415119018fd4c9922f61 > > core/src/test/scala/unit/kafka/utils/TestUtils.scala > c4e13c5240c8303853d08cc3b40088f8c7dae460 > > > > Diff: https://reviews.apache.org/r/24006/diff/ > > > > > > Testing > > ------- > > > > Automated > > > > > > Thanks, > > > > Jonathan Natkins > > > > > >
