> On Aug. 1, 2014, 9:27 p.m., Guozhang Wang wrote: > > core/src/test/scala/unit/kafka/admin/AdminTest.scala, line 134 > > <https://reviews.apache.org/r/24006/diff/3/?file=646111#file646111line134> > > > > What I was actually thinking is that probably we can define these two > > variables at the top of testTopicCreationInZK and crate the > > expectedReplicaAssignment and leaderForPartitionMap programmatically > > instead of hand-written them.
This would admittedly be easier in later versions of Scala, which have some combinatorial functionality, but I've written a little code to do this. Take a look at it...I'm not totally sure it's what you had in mind, so let me know if you just meant for me to use AdminTools.assignReplicasToBrokers or something like that. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24006/#review49382 ----------------------------------------------------------- On Aug. 2, 2014, 6:04 p.m., Jonathan Natkins wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24006/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2014, 6:04 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1420 > https://issues.apache.org/jira/browse/KAFKA-1420 > > > Repository: kafka > > > Description > ------- > > KAFKA-1420 Replace AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZK > with TestUtils.createTopic in unit tests > > > Diffs > ----- > > core/src/test/scala/unit/kafka/admin/AdminTest.scala > e28979827110dfbbb92fe5b152e7f1cc973de400 > core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala > 29cc01bcef9cacd8dec1f5d662644fc6fe4994bc > core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala > f44568cb25edf25db857415119018fd4c9922f61 > core/src/test/scala/unit/kafka/utils/TestUtils.scala > c4e13c5240c8303853d08cc3b40088f8c7dae460 > > Diff: https://reviews.apache.org/r/24006/diff/ > > > Testing > ------- > > Automated > > > Thanks, > > Jonathan Natkins > >
