> On July 30, 2014, 12:22 a.m., Guozhang Wang wrote: > > core/src/test/scala/unit/kafka/admin/AdminTest.scala, line 314 > > <https://reviews.apache.org/r/24006/diff/1/?file=643839#file643839line314> > > > > Is there a specific reason we want to use 10 seconds instead of default > > 5 seconds?
Sorry, I'd added this in the midst of debugging, and forgotten to remove it. I've actually changed this call, because I realized that it didn't necessarily assure me that broker 0 had caught up to the ISR yet. The test has been changed to be more reliable. > On July 30, 2014, 12:22 a.m., Guozhang Wang wrote: > > core/src/test/scala/unit/kafka/admin/AdminTest.scala, line 317 > > <https://reviews.apache.org/r/24006/diff/1/?file=643839#file643839line317> > > > > Is this println intended? Removed > On July 30, 2014, 12:22 a.m., Guozhang Wang wrote: > > core/src/test/scala/unit/kafka/utils/TestUtils.scala, line 186 > > <https://reviews.apache.org/r/24006/diff/1/?file=643842#file643842line186> > > > > Could we just set the default value of configs parameter to null, > > instead of creating a separate function? The reason I'd done this is that the Scala compiler complained because there's another implementation of createTopic that defines default parameter values. However, I was able to change the calls to this API to the one that uses numPartitions and replicationFactor, and stuck the Properties parameter over there. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24006/#review49049 ----------------------------------------------------------- On July 30, 2014, 6:18 p.m., Jonathan Natkins wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24006/ > ----------------------------------------------------------- > > (Updated July 30, 2014, 6:18 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1420 > https://issues.apache.org/jira/browse/KAFKA-1420 > > > Repository: kafka > > > Description > ------- > > KAFKA-1420 Replace AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZK > with TestUtils.createTopic in unit tests > > > Diffs > ----- > > core/src/test/scala/unit/kafka/admin/AdminTest.scala > e28979827110dfbbb92fe5b152e7f1cc973de400 > core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala > 29cc01bcef9cacd8dec1f5d662644fc6fe4994bc > core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala > f44568cb25edf25db857415119018fd4c9922f61 > core/src/test/scala/unit/kafka/utils/TestUtils.scala > c4e13c5240c8303853d08cc3b40088f8c7dae460 > > Diff: https://reviews.apache.org/r/24006/diff/ > > > Testing > ------- > > Automated > > > Thanks, > > Jonathan Natkins > >
