Re: Review Request 19626: Patch for KAFKA-1323

2014-04-04 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19626/#review39553 --- Ship it! Ship It! - Jun Rao On April 2, 2014, 7:18 p.m., Timothy

Re: Review Request 19626: Patch for KAFKA-1323

2014-04-03 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19626/#review39450 --- core/src/test/scala/unit/kafka/log/LogManagerTest.scala

Re: Review Request 19626: Patch for KAFKA-1323

2014-04-02 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19626/ --- (Updated April 2, 2014, 7:18 p.m.) Review request for kafka. Bugs: KAFKA-1323

Re: Review Request 19626: Patch for KAFKA-1323

2014-04-01 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19626/#review39158 --- core/src/test/scala/unit/kafka/log/LogManagerTest.scala

Re: Review Request 19626: Patch for KAFKA-1323

2014-03-31 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19626/ --- (Updated March 31, 2014, 6:57 p.m.) Review request for kafka. Bugs: KAFKA-132

Re: Review Request 19626: Patch for KAFKA-1323

2014-03-27 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19626/ --- (Updated March 27, 2014, 11:17 p.m.) Review request for kafka. Bugs: KAFKA-13

Re: Review Request 19626: Patch for KAFKA-1323

2014-03-26 Thread Timothy Chen
> On March 26, 2014, 12:55 a.m., Neha Narkhede wrote: > > My guess is that we may have to review and make a similar change in the > > following places - > > 1. LogManager.checkpointRecoveryPointOffsets() > > 2. LogManager.nextLogDir() > > > > The unit test in ReplicaManagerTest cover checkpoint

Re: Review Request 19626: Patch for KAFKA-1323

2014-03-26 Thread Neha Narkhede
> On March 26, 2014, 12:55 a.m., Neha Narkhede wrote: > > My guess is that we may have to review and make a similar change in the > > following places - > > 1. LogManager.checkpointRecoveryPointOffsets() > > 2. LogManager.nextLogDir() > > > > The unit test in ReplicaManagerTest cover checkpoint

Re: Review Request 19626: Patch for KAFKA-1323

2014-03-25 Thread Timothy Chen
> On March 26, 2014, 12:55 a.m., Neha Narkhede wrote: > > My guess is that we may have to review and make a similar change in the > > following places - > > 1. LogManager.checkpointRecoveryPointOffsets() > > 2. LogManager.nextLogDir() > > > > The unit test in ReplicaManagerTest cover checkpoint

Re: Review Request 19626: Patch for KAFKA-1323

2014-03-25 Thread Timothy Chen
> On March 26, 2014, 12:55 a.m., Neha Narkhede wrote: > > core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala, line 66 > > > > > > This method can be private. > > > > This method seems to indicate th

Re: Review Request 19626: Patch for KAFKA-1323

2014-03-25 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19626/#review38565 --- My guess is that we may have to review and make a similar change in

Re: Review Request 19626: Patch for KAFKA-1323

2014-03-25 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19626/#review38554 --- Ship it! Ship It! - Guozhang Wang On March 25, 2014, 6:54 p.m.,