----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19626/#review39450 -----------------------------------------------------------
core/src/test/scala/unit/kafka/log/LogManagerTest.scala <https://reviews.apache.org/r/19626/#comment71842> You can use the scala intercept[] annotation for expected exception. One example is in ProducerFailureHandlingTest. core/src/test/scala/unit/kafka/log/LogManagerTest.scala <https://reviews.apache.org/r/19626/#comment71879> Could we move the appending logic out of the verification function, so that we can also test the case when there is no data append to the logs, etc? core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala <https://reviews.apache.org/r/19626/#comment71880> Why we want to change the logic to waitUntilTrue here? - Guozhang Wang On April 2, 2014, 7:18 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19626/ > ----------------------------------------------------------- > > (Updated April 2, 2014, 7:18 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1323 > https://issues.apache.org/jira/browse/KAFKA-1323 > > > Repository: kafka > > > Description > ------- > > KAFKA-1323 Fix log directory to support relative directories > > > Diffs > ----- > > core/src/main/scala/kafka/cluster/Partition.scala > 6d6b4ab91608162201d2737d784580728193566a > core/src/main/scala/kafka/server/ReplicaManager.scala > 0f5aaa9888d6c0ca0b073f4742bee14ad72d0484 > core/src/test/scala/unit/kafka/log/LogManagerTest.scala > b4bee33191ebc0b4ab5a5f82fa232cd3bda8fef8 > core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala > 67497dd042dfd4ad54875fe29200d67f59137264 > core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala > b5936d4101b513baa805ab26361fe965bdf980aa > > Diff: https://reviews.apache.org/r/19626/diff/ > > > Testing > ------- > > > Thanks, > > Timothy Chen > >
