----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19626/#review39158 -----------------------------------------------------------
core/src/test/scala/unit/kafka/log/LogManagerTest.scala <https://reviews.apache.org/r/19626/#comment71524> Instead of duplicating most of the code btw the two test cases, could we put the common code in a util function? core/src/test/scala/unit/kafka/log/LogManagerTest.scala <https://reviews.apache.org/r/19626/#comment71523> Incorrect comment. - Jun Rao On March 31, 2014, 6:57 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19626/ > ----------------------------------------------------------- > > (Updated March 31, 2014, 6:57 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1323 > https://issues.apache.org/jira/browse/KAFKA-1323 > > > Repository: kafka > > > Description > ------- > > KAFKA-1323 Fix log directory to support relative directories > > > Diffs > ----- > > core/src/main/scala/kafka/cluster/Partition.scala > 0b88f14c4855b27242906cd45930bae501e26226 > core/src/main/scala/kafka/server/ReplicaManager.scala > 255be063ee247a849e527297c987da4625d749ca > core/src/test/scala/unit/kafka/log/LogManagerTest.scala > b4bee33191ebc0b4ab5a5f82fa232cd3bda8fef8 > core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala > 67497dd042dfd4ad54875fe29200d67f59137264 > core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala > b5936d4101b513baa805ab26361fe965bdf980aa > > Diff: https://reviews.apache.org/r/19626/diff/ > > > Testing > ------- > > > Thanks, > > Timothy Chen > >
