----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19626/#review38565 -----------------------------------------------------------
My guess is that we may have to review and make a similar change in the following places - 1. LogManager.checkpointRecoveryPointOffsets() 2. LogManager.nextLogDir() The unit test in ReplicaManagerTest cover checkpointing, but we also need to add coverage for log recovery and log cleaning since those are the places that touch the directory mapping core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala <https://reviews.apache.org/r/19626/#comment70833> This method can be private. This method seems to indicate that it creates a mock log manager, but actually it creates a real LogManager object. I'm not sure I understand the motivation behind moving away from the mock object to an actual LogManager object? - Neha Narkhede On March 25, 2014, 6:54 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19626/ > ----------------------------------------------------------- > > (Updated March 25, 2014, 6:54 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1323 > https://issues.apache.org/jira/browse/KAFKA-1323 > > > Repository: kafka > > > Description > ------- > > KAFKA-1323 Fix log directory to support relative directories > > > Diffs > ----- > > core/src/main/scala/kafka/cluster/Partition.scala > 0b88f14c4855b27242906cd45930bae501e26226 > core/src/main/scala/kafka/server/ReplicaManager.scala > 255be063ee247a849e527297c987da4625d749ca > core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala > b5936d4101b513baa805ab26361fe965bdf980aa > > Diff: https://reviews.apache.org/r/19626/diff/ > > > Testing > ------- > > > Thanks, > > Timothy Chen > >
