[jira] [Commented] (KAFKA-648) Use uniform convention for naming properties keys

2013-01-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551766#comment-13551766 ] Jun Rao commented on KAFKA-648: --- Merged to trunk and resolved conflicts. > U

[jira] [Commented] (KAFKA-648) Use uniform convention for naming properties keys

2013-01-11 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551666#comment-13551666 ] Swapnil Ghike commented on KAFKA-648: - Will it make sense to create a Utils function to

[jira] [Commented] (KAFKA-648) Use uniform convention for naming properties keys

2013-01-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551233#comment-13551233 ] Jun Rao commented on KAFKA-648: --- Thanks for patch v5. Some of the comments in those config fi

[jira] [Commented] (KAFKA-648) Use uniform convention for naming properties keys

2013-01-09 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13549075#comment-13549075 ] Jun Rao commented on KAFKA-648: --- Thanks for patch v4. Made another pass. Should we make the f

[jira] [Commented] (KAFKA-648) Use uniform convention for naming properties keys

2013-01-09 Thread John Fung (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13548989#comment-13548989 ] John Fung commented on KAFKA-648: - Tested v4 patch with KAFKA-688-v1.patch with the latest

[jira] [Commented] (KAFKA-648) Use uniform convention for naming properties keys

2013-01-09 Thread John Fung (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13548650#comment-13548650 ] John Fung commented on KAFKA-648: - Hi Sriram, The change in system_test/migration_tool_te

[jira] [Commented] (KAFKA-648) Use uniform convention for naming properties keys

2013-01-08 Thread John Fung (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547063#comment-13547063 ] John Fung commented on KAFKA-648: - The testcase__properties.json files in System Test w

[jira] [Commented] (KAFKA-648) Use uniform convention for naming properties keys

2013-01-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13546541#comment-13546541 ] Jun Rao commented on KAFKA-648: --- Thanks for patch v2. I missed a few items in the previous re

[jira] [Commented] (KAFKA-648) Use uniform convention for naming properties keys

2013-01-03 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543554#comment-13543554 ] Jun Rao commented on KAFKA-648: --- Thanks for the patch. Some comments: 1. ConsumerConfig: We

[jira] [Commented] (KAFKA-648) Use uniform convention for naming properties keys for clientId, groupId, consumerId, correlationId

2012-12-04 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510021#comment-13510021 ] Jay Kreps commented on KAFKA-648: - I actually recommend that we do a full config review and

[jira] [Commented] (KAFKA-648) Use uniform convention for naming properties keys for clientId, groupId, consumerId, correlationId

2012-12-04 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510016#comment-13510016 ] Jay Kreps commented on KAFKA-648: - A bunch of the config values are non standard. For examp

[jira] [Commented] (KAFKA-648) Use uniform convention for naming properties keys for clientId, groupId, consumerId, correlationId

2012-12-04 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509991#comment-13509991 ] Neha Narkhede commented on KAFKA-648: - Not sure I got the part about config.val, where

[jira] [Commented] (KAFKA-648) Use uniform convention for naming properties keys for clientId, groupId, consumerId, correlationId

2012-12-04 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509982#comment-13509982 ] Jay Kreps commented on KAFKA-648: - word. > Use uniform convention for nami