[
https://issues.apache.org/jira/browse/KAFKA-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551233#comment-13551233
]
Jun Rao commented on KAFKA-648:
-------------------------------
Thanks for patch v5. Some of the comments in those config files are outdated or
are missing. Made another pass.
50. SyncProducerConfig: max.message.size => max.message.bytes
51. KafkaConfig:
51.1 auto.create.topics => auto.create.topics.enable
51.2 We probably should remove the support of "log.dir" and default "log.dirs"
to /tmp/kafka-logs (defaulting to "" is confusing).
52. ConsumerConfig: Fix the following grammar.
"to immediate satisfy min.fetch.bytes" => "to immediately satisfy
min.fetch.bytes"
53. KafkaConfig:
53.1 replicaLagTimeMaxMs: add the following comments
//If a follower hasn't sent any fetch requests during this time, the leader
will remove the follower from isr.
53.2 replica.lag.max.bytes: The name is out dated since offsets are now
logical, instead of physical. So we need to change this property to
replica.lag.max.messages and add the following comment.
//If the lag in messages between a leader and a follower exceeds this number,
the leader will remove the follower from isr.
We also need to change the input parameter name in maybeShrinkIsr() and
getOutOfSyncReplicas() in Partition from bytes to messages too.
53.3 auto.create.topics => auto.create.topics.enable
"highwater mark" => "high watermark"
54. ProducerConfig:
54.1 messageSendMaxRetries: The comment is outdated. Let's change it to the
following:
//The leader may be unavailable transiently, which can fail the sending of a
message. This property specifies the number of retries when such failures occur.
54.2 retryBackoffMs: Let's add the following comment.
//Before each retry, the producer refreshes the metadata of relevant topics.
Since leader election takes a bit of time, this property specifies the amount
of time that the producer waits before refreshing the metadata.
> Use uniform convention for naming properties keys
> --------------------------------------------------
>
> Key: KAFKA-648
> URL: https://issues.apache.org/jira/browse/KAFKA-648
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Swapnil Ghike
> Assignee: Sriram Subramanian
> Priority: Blocker
> Fix For: 0.8, 0.8.1
>
> Attachments: configchanges-1.patch, configchanges-v2.patch,
> configchanges-v3.patch, configchanges-v4.patch, configchanges-v5.patch
>
>
> Currently, the convention that we seem to use to get a property value in
> *Config is as follows:
> val configVal = property.getType("config.val", ...) // dot is used to
> separate two words in the key and the first letter of second word is
> capitalized in configVal.
> We should use similar convention for groupId, consumerId, clientId,
> correlationId.
> This change will probably be backward non-compatible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
